Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push to staging #459

Merged
merged 15 commits into from
Mar 18, 2024
Merged

push to staging #459

merged 15 commits into from
Mar 18, 2024

Conversation

nora-codecov
Copy link
Contributor

Purpose/Motivation

Get staging up to date with main

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

joseph-sentry and others added 15 commits March 8, 2024 16:33
* fix: handle rate limit error in get pr info fn

We want to handle receiving a 429 or 403
status code response from gh that is related
to hitting the gh rate limit.

now we do that when we try to get PR info while
trying to auth with tokenless

we will return a `exceptions.Throttled` which
corresponds to a 429 status code

* fix: add detail string to rate limit error in tokenless auth

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>

* Modify rate limit failed message

Co-authored-by: Tom Hu <88201630+thomasrockhu-codecov@users.noreply.github.com>

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Co-authored-by: Tom Hu <88201630+thomasrockhu-codecov@users.noreply.github.com>
* test: fix query measurements after 30 days test

This test started failing ater 2024-03-10 because
the time at the query was not frozen to a specific
date so it was using the system's actual time and
the measurements were not a part of the last 30 days.

* fix: add comments to clarify test fix

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Currently the admin app can extend a org trial, but only after they have expired and turned back to basic plan.
This change allows the orgs' trials to be extended while they're still trialing.
These fields are being deprecated by bundleData and bundleChange. The app is no longer calling these fields anymore, it is safe to remove now.
* fix: use get_or_create in CommitSerializer.create

there is a possibility of creating commits concurrently
if that happens there is a possibility of getting an
IntegrityError when trying to create the Commit object

this commit solves this problem by using get_or_create to
create the Commit object in the serializer

* test: add test to make sure CommitSerializer create only creates one object in the db

---------

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
* Test with states

* second round

* Okta stuff

* quick fix for test

* fixing tests

* more tests

* test: fix query measurements after 30 days test (#442)

* test: fix query measurements after 30 days test

This test started failing ater 2024-03-10 because
the time at the query was not frozen to a specific
date so it was using the system's actual time and
the measurements were not a part of the last 30 days.

* fix: add comments to clarify test fix

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>

* [admin] allow trial extension for orgs currently on trial (#438)

Currently the admin app can extend a org trial, but only after they have expired and turned back to basic plan.
This change allows the orgs' trials to be extended while they're still trialing.

* Bundle Analysis: delete old code (#444)

These fields are being deprecated by bundleData and bundleChange. The app is no longer calling these fields anymore, it is safe to remove now.

* fix: use get_or_create in CommitSerializer.create (#437)

* fix: use get_or_create in CommitSerializer.create

there is a possibility of creating commits concurrently
if that happens there is a possibility of getting an
IntegrityError when trying to create the Commit object

this commit solves this problem by using get_or_create to
create the Commit object in the serializer

* test: add test to make sure CommitSerializer create only creates one object in the db

---------

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>

* Revert "Bundle Analysis: delete old code (#444)" (#445)

This reverts commit 7932e93.

* Remove state after login

---------

Signed-off-by: joseph-sentry <joseph.sawaya@sentry.io>
Co-authored-by: joseph-sentry <136376984+joseph-sentry@users.noreply.github.com>
Co-authored-by: JerrySentry <142266253+JerrySentry@users.noreply.github.com>
…for enterprise (#417)

* Update to block users if guest set to false

* Add a middleware

* Remove old code

* Remove old code

* Update enteprise settings

* Dev for tests

* Test middleware

* more tests, so we are safe

* Don't block users from logging in

* lint yelling
* Revert guest feature

* Delete the middleware
* Update ci.yml

* Update codecov.yml

* Update ci.yml
@nora-codecov nora-codecov requested review from a team as code owners March 18, 2024 19:16
@nora-codecov nora-codecov merged commit 13decc6 into staging Mar 18, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants