Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optparse Options class for standard options #4919

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Fix optparse Options class for standard options #4919

merged 1 commit into from
Jun 22, 2022

Conversation

MetRonnie
Copy link
Member

This is a small change with no associated Issue.

Allow standard options (CylcOptionParser(auto_add=True)) in Python API Options class

Before:

>>> from cylc.flow.scripts.clean import CleanOptions
>>> CleanOptions(verbosity=1)
ValueError: verbosity

After:
CleanOptions(verbosity=1) works as expected.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Applied any dependency changes to both setup.cfg and conda-environment.yml.
  • Appropriate tests are included (unit and/or functional).
  • No change log entry required (invisible to users).
  • No documentation update required.

@MetRonnie MetRonnie added bug Something is wrong :( small labels Jun 20, 2022
@MetRonnie MetRonnie added this to the cylc-8.0rc4 milestone Jun 20, 2022
@MetRonnie MetRonnie self-assigned this Jun 20, 2022
@MetRonnie MetRonnie mentioned this pull request Jun 22, 2022
Closed
7 tasks
@MetRonnie
Copy link
Member Author

1 review should do

@MetRonnie MetRonnie merged commit 622a1dd into cylc:master Jun 22, 2022
@MetRonnie MetRonnie deleted the optparse branch June 22, 2022 16:02
wxtim added a commit to wxtim/cylc that referenced this pull request Jul 4, 2022
@wxtim
Merge branch 'master' into cylc-linter.bk
8dec7ca 
* master: (30 commits)
  Log dir tidy (cylc#4836)
  Cut down on back-compat warnings, plus other tidying (cylc#4943)
  Validate platform settings (background job runner) (cylc#4938)
  clean: push error message to stderr
  Update cylc/flow/id_match.py
  Fix unintended directory stripping during cylc install (cylc#4931)
  stop cylc validate swallowing useful errors (cylc#4936)
  Improve config reference docs (cylc#4916)
  glblcfg: increase default rolling archive length
  Fix job state with pre-submitted failure
  Update tests/functional/cylc-reinstall/02-failures.t
  reinstall: require workflow ID argument
  play: upgrade --start-task's specified in legacy format (cylc#4925)
  expand schema docstring internally (cylc#4926)
  Added a new task filtering test.
  Add comment [skip ci]
  Fix optparse Options class for std options (cylc#4919)
  uid: warn if the run number is provided as a cycle
  Tweak prev.
  Fix task filtering.
  ...
@hjoliver hjoliver modified the milestones: cylc-8.0rc4, cylc-8.0.0 Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliver-sanders oliver-sanders oliver-sanders approved these changes

Assignees

@MetRonnie MetRonnie

Labels
bug Something is wrong :( small
Projects
None yet
Milestone
cylc-8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MetRonnie @oliver-sanders @hjoliver