-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate platform settings (background job runner) #4938
Merged
oliver-sanders
merged 9 commits into
cylc:master
from
hjoliver:background-platform-tweak
Jun 30, 2022
Merged
Validate platform settings (background job runner) #4938
oliver-sanders
merged 9 commits into
cylc:master
from
hjoliver:background-platform-tweak
Jun 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjoliver
force-pushed
the
background-platform-tweak
branch
from
June 28, 2022 03:01
54d613c
to
7cb4402
Compare
1 task
hjoliver
changed the title
Validate platform settings.
Validate platform settings (background job runner)
Jun 28, 2022
(This broke some functional tests that actually use the background job runner with multiple hosts. I have a fix in the works, will push it up later; out of time for now). |
wxtim
reviewed
Jun 28, 2022
wxtim
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Read, seems OK.
- Tried it out locally.
Happy that this is functionally OK, I've put a couple of thoughts about style/naming and testing in.
hjoliver
force-pushed
the
background-platform-tweak
branch
from
June 30, 2022 00:06
d46d22e
to
86f5a6b
Compare
oliver-sanders
approved these changes
Jun 30, 2022
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Jul 4, 2022
* master: (30 commits) Log dir tidy (cylc#4836) Cut down on back-compat warnings, plus other tidying (cylc#4943) Validate platform settings (background job runner) (cylc#4938) clean: push error message to stderr Update cylc/flow/id_match.py Fix unintended directory stripping during cylc install (cylc#4931) stop cylc validate swallowing useful errors (cylc#4936) Improve config reference docs (cylc#4916) glblcfg: increase default rolling archive length Fix job state with pre-submitted failure Update tests/functional/cylc-reinstall/02-failures.t reinstall: require workflow ID argument play: upgrade --start-task's specified in legacy format (cylc#4925) expand schema docstring internally (cylc#4926) Added a new task filtering test. Add comment [skip ci] Fix optparse Options class for std options (cylc#4919) uid: warn if the run number is provided as a cycle Tweak prev. Fix task filtering. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #4922
Requirements check-list
CONTRIBUTING.md
and added my name as a Code Contributor.setup.cfg
andconda-environment.yml
.