Fix unintended directory stripping during cylc install #4931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should have at least one functional test for this, especially given that we accidentally implemented, then un-implemented this before 🤣. |
MetRonnie
requested changes
Jun 23, 2022
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
Co-authored-by: Ronnie Dutta <61982285+MetRonnie@users.noreply.github.com>
hjoliver
approved these changes
Jun 28, 2022
|
Works fine for workflows installed by "name" or "path", however, we get a flat installation when installing from "$PWD". $ cd ~/cylc-src
$ mkdir a/b/c -p
$ touch a/b/c/flow.cylc
$ cylc install a/b/c
INSTALLED a/b/c/run1 from ~/cylc-src/a/b/c
$ cylc install ~/cylc-src/a/b/c
INSTALLED a/b/c/run2 from ~/cylc-src/a/b/c
$ cd a/b/c
$ cylc install
INSTALLED c/run1 from ~/cylc-src/a/b/c |
|
Agh, |
MetRonnie
approved these changes
Jun 29, 2022
wxtim
approved these changes
Jun 29, 2022
wxtim
added a commit
to wxtim/cylc
that referenced
this pull request
Jul 4, 2022
* master: (30 commits) Log dir tidy (cylc#4836) Cut down on back-compat warnings, plus other tidying (cylc#4943) Validate platform settings (background job runner) (cylc#4938) clean: push error message to stderr Update cylc/flow/id_match.py Fix unintended directory stripping during cylc install (cylc#4931) stop cylc validate swallowing useful errors (cylc#4936) Improve config reference docs (cylc#4916) glblcfg: increase default rolling archive length Fix job state with pre-submitted failure Update tests/functional/cylc-reinstall/02-failures.t reinstall: require workflow ID argument play: upgrade --start-task's specified in legacy format (cylc#4925) expand schema docstring internally (cylc#4926) Added a new task filtering test. Add comment [skip ci] Fix optparse Options class for std options (cylc#4919) uid: warn if the run number is provided as a cycle Tweak prev. Fix task filtering. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #4930
Fix bug where hierarchical source workflows (e.g
~/cylc-src/dogs/fido/) would lose the multi-level name on installation ifglobal.cylc[install]source dirscontained~or env vars.Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.cfgandconda-environment.yml.