Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting using mplfinance uses the default theme instead of our theme #2079

Open
mofojed opened this issue Mar 9, 2022 · 1 comment
Open
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Mar 9, 2022

Description

A clear and concise description of what the bug is.

Steps to reproduce

  1. Start up a docker image with deephaven-plugin-matplotlib, mplfinance, and yfinance modules installed:
FROM ghcr.io/deephaven/server:edge
RUN pip install deephaven-plugin-matplotlib
RUN pip install yfinance
RUN pip install mplfinance
  1. Create an mplfinance plot:
import matplotlib.pyplot as plt
import pandas as pd
import yfinance as yf
import mplfinance as mpf

TICKER = "AAPL"

plt.figure()
df = yf.download(TICKER, 
                 start="2020-07-01", 
                 end="2020-12-31", 
                 auto_adjust=True)
mpf.plot(df["2020-12-01":])
f = plt.gcf()

Expected results

  1. Plot appears with the theme we've defined

Actual results

  1. Plot appears but with the default theme, sticking out like a sore thumb:
    image
@mofojed mofojed added bug Something isn't working triage matplotlib labels Mar 9, 2022
@mofojed
Copy link
Member Author

mofojed commented Mar 9, 2022

mplfinance has some additional theming specified, see examples: https://github.com/matplotlib/mplfinance/blob/master/examples/styles.ipynb

Not sure we can set this with just our deephaven-plugin-matplotlib or if we'd need a specific mplfinance one.

mofojed pushed a commit that referenced this issue Jul 17, 2024
## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.86.0

### Features

* Add option to disable WebGL rendering
([#2134](deephaven/web-client-ui#2134))
([011eb33](deephaven/web-client-ui@011eb33))
* Core plugins refactor, XComponent framework
([#2150](deephaven/web-client-ui#2150))
([2571fad](deephaven/web-client-ui@2571fad))
* IrisGridTheme iconSize
([#2123](deephaven/web-client-ui#2123))
([58ee88d](deephaven/web-client-ui@58ee88d)),
closes [#885](deephaven/web-client-ui#885)
* Partitioned Table UI Enhancements
([#2110](deephaven/web-client-ui#2110))
([de5ce40](deephaven/web-client-ui@de5ce40)),
closes [#2079](deephaven/web-client-ui#2079)
[#2066](deephaven/web-client-ui#2066)
[#2103](deephaven/web-client-ui#2103)
[#2104](deephaven/web-client-ui#2104)
[#2105](deephaven/web-client-ui#2105)
[#2106](deephaven/web-client-ui#2106)
[#2107](deephaven/web-client-ui#2107)
[#2108](deephaven/web-client-ui#2108)
[#2109](deephaven/web-client-ui#2109)
[#2049](deephaven/web-client-ui#2049)
[#2120](deephaven/web-client-ui#2120)
[#1904](deephaven/web-client-ui#1904)


### Bug Fixes

* error when edited cell is out of grid viewport
([#2148](deephaven/web-client-ui#2148))
([3fccd43](deephaven/web-client-ui@3fccd43)),
closes [#2087](deephaven/web-client-ui#2087)

## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.2


### Bug Fixes

* Fix missing scrim background on LoadingOverlay
([#2098](deephaven/web-client-ui#2098))
([c9ed895](deephaven/web-client-ui@c9ed895))

## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.1

##
[0.85.1](deephaven/web-client-ui@v0.85.0...v0.85.1)
(2024-07-08)


### Bug Fixes

* re-export remaining types needed by dh ui from @react-types/shared
([#2132](deephaven/web-client-ui#2132))
([2119a61](deephaven/web-client-ui@2119a61))



## Release notes
https://github.com/deephaven/web-client-ui/releases/tag/v0.85.0

### Features

* ComboBox - @deephaven/jsapi-components
([#2077](deephaven/web-client-ui#2077))
([115e057](deephaven/web-client-ui@115e057)),
closes [#2074](deephaven/web-client-ui#2074)


### Bug Fixes

* Allow ComboBox to accept the FocusableRef for ref
([#2121](deephaven/web-client-ui#2121))
([8fe9bad](deephaven/web-client-ui@8fe9bad))
* Ref was not being passed through for Picker
([#2122](deephaven/web-client-ui#2122))
([a11e2ce](deephaven/web-client-ui@a11e2ce))

Co-authored-by: deephaven-internal <66694643+deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants