reverse merge #13
Merged
reverse merge #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13342) * support deleteColumn for compactionTask by extending the record reader * format
* Refactor ADSS querysubmission stats to avoid missing servers * Address review comments.
…bles (#13107) * [Backfill] allow externally partitioned segment uploads for upsert tables * upload segment with partitionId * revise uploaded realtime segment name convention
…verride flag is set to true (#13320)
…figuration in table config (#13131)
…cord (#13352) * extend CompactedPinotSegmentRecordReader so that it can skip deleteRecord
* Checkpoint * Checkpoint * Add javadocs for new interfaces. * Code linting and java docs. * Add two quick starts for resource tracking. * Add a javadoc * Dont serialize thread info * Add auth to query debug resource
* Fix flaky gauge value issue * add UTs
* Fix query response time metric As of PR #13179, the query response time metrics started to get extremely high for all tables. The root cause tured out to be a missed initialization in which the query arrival time was set to 0 by default. The refactor broke the contract that the broker request handler always returns the time taken to handle the request. Added code to initialize the arrival time. Since the refactor attempted to include client pre-processing time, added this code under the condition that the value is not already set. Ideally, callers of the method should add on their own pre and post-processing time to the time returned by the handleRequest() method. * Changed as per review comments and offline discussion * Added comments
* Refactor PinotSchemaRestletResource for repetitive code around schema json parsing and access * Changes as per the PR comment.
* Build profiles for aarch64 * Add license header * Checkstyle * Download netty libs using the right OS classifier * Revert "Download netty libs using the right OS classifier" This reverts commit d77d166. * SkipTests on ARM progamatically
* enable parallel background refresh for lucene text index * lint * address comments
…3649) * Use debug logs in case we run into rate limit exceeded exception * lower kinesis rate limit * Fix exception --------- Co-authored-by: Kartik Khare <kharekartik@Kartiks-MacBook-Pro.local>
…able query parser (#13003) * Support custom Lucene analyzer with arguments and custom query parser * Add Apache license header to CsvParserTest.java * Adjusted dependency import order for javax.annotation.Nullable in CsvParser.java * Applied mvn spotless:apply on CsvParserTest.java * Correct a spelling mistake in the comments in RealtimeLuceneTextIndex.java * Adjusted parsing methods naming to improve clarity in TextIndexUtils.java * Removed redundant reflection logic in TextIndexUtils.java * Removed redundant string replacement Streaming pipeline in CsvParser.java * Break up long line over 120 char into two lines in TextIndexUtils.java * Adjusted the scenarios of when default Analyzers with custom arguments should be used. * Emit Class.getName() instead of Class.getCanonicalName() in logs within RealtimeLuceneTextIndex.java * Moved `||` operator in if condition to a new line to resolve style issue. * Addressed code review concerns from @Bill-hbrhbr * Fix style error. * Fix unit test. * Run maven spotless:apply * Patched argument parsing bug. * Updated PR with latest code base. * Addressed comments from @chenboat * Fix build issues resulting from merge conflicts * Removed trailing white-space * Fix style-check errors * Fix default Stopwords default initialization values * Refactored builder code in unit test inside LuceneMutableTextIndexTest.java Signed-off-by: Jack Luo <jluo14@ext.uber.com> * Fix style bug Signed-off-by: Jack Luo <jluo14@ext.uber.com> --------- Signed-off-by: Jack Luo <jluo14@ext.uber.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.