Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admittance with filters #45

Closed

Conversation

guihomework
Copy link

Re-introduced filters to the admittance_controller as originally done in ros-controls#382. Improved testing, variable names and comments.

Depends on ros-controls/control_toolbox#152 and ros-controls/control_toolbox#153

AndyZe and others added 30 commits July 23, 2022 18:07
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
…reaking

Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
This use of `auto` is causing a static assert on RHEL. Explicitly
specifying the type seems to resolve the failure and allow the test to
be compiled.
variables in JTC to not clutter other PR with them.
fixes of updating parameters on renewed configuration of JTC that were missed
…oal (ros-controls#368)

* hold position if tolerance is violated even during non-active goal

* rename abort

Co-authored-by: Michael Wiznitzer <michael.wiznitzer@resquared.com>
* Remove old CI setup.

* Adding adjusted CI configurationt to ros2_control repository.

* Fixup line for private repositories.

* Run format only on PR.

* Adjust repos files.
* Fix correct_initialization_using_parameters
* Fix configure_state_ignores_command
* Re-enable incorrect_initialization_using_interface_parameters
* Re-enable cleanup and activate tests
* Port gtest to gmock

Co-authored-by: Denis Štogl <denis@stogl.de>
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
- there is no foxy rhel docker image because it osrf doesn't publish rhel packages for foxy
…for following controllers in a chain. (ros-controls#380)

* [JTC] Add additional parameter to enable configuration of interfaces for following controllers in a chain.
* Use command_joint_states correctly in parameters depending on joint states.
* Fixup tests.
Signed-off-by: Tyler Weaver <tyler@picknik.ai>
* Use "steady" clocks when measuring changes in time
* Check if the "publish rate" tests pass now
swiz23 and others added 18 commits February 10, 2023 16:38
Co-authored-by: Solomon Wiznitzer <solomon.wiznitzer@resquared.com>
Co-authored-by: Michael Wiznitzer <michael.wiznitzer@resquared.com>
* Use RT buffer for gripper action controller's goal handle

* fix format

---------

Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Bumps [ros-tooling/setup-ros](https://github.com/ros-tooling/setup-ros) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/ros-tooling/setup-ros/releases)
- [Commits](ros-tooling/setup-ros@0.5.0...0.6.0)

---
updated-dependencies:
- dependency-name: ros-tooling/setup-ros
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ros-tooling/action-ros-ci](https://github.com/ros-tooling/action-ros-ci) from 0.2.7 to 0.3.0.
- [Release notes](https://github.com/ros-tooling/action-ros-ci/releases)
- [Commits](ros-tooling/action-ros-ci@0.2.7...0.3.0)

---
updated-dependencies:
- dependency-name: ros-tooling/action-ros-ci
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 1 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v1...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update JTC documentation

Update, e.g. parameter changed with ros-controls#520

* Fix whitespaces
Bumps [ros-tooling/setup-ros](https://github.com/ros-tooling/setup-ros) from 0.6.0 to 0.6.1.
- [Release notes](https://github.com/ros-tooling/setup-ros/releases)
- [Commits](ros-tooling/setup-ros@0.6.0...0.6.1)

---
updated-dependencies:
- dependency-name: ros-tooling/setup-ros
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
automatically_declare_parameters_from_overrides True hinders
from dynamically loading external libraries declaring
their own parameters.
@destogl
Copy link
Owner

destogl commented Mar 19, 2023

@please open this PR upstream and not here

christophfroehlich and others added 8 commits March 28, 2023 19:45
* Add missing controllers to doc index

* Fix wrong forward_command controller doc
…nterface (ros-controls#553)

* [AdmittanceController] Addintional argument in methods of ControllerInterface

* Update admittance_controller.cpp
Test currently fails at joint state matching commands, but this
should be expected as there is gravity compensation with a 2.3 kg mass
@guihomework guihomework force-pushed the admittance-with-filters-rolling branch from b3aa8a1 to 40d47f3 Compare April 3, 2023 11:10
@guihomework
Copy link
Author

closed in favor of ros-controls#560

@guihomework guihomework closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.