Sync: TestPR: remove me #44
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On remote clients (incl. Mac/Windows, excl. WSL2), file-based transports (oci-archive:, docker-archive:, docker-daemon:) are not supported. Also fix trailing whitespace per pre-commit. Signed-off-by: shiavm006 <shivammittal42006@gmail.com>
docs: Add --format flag examples to commands in man pages
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
docs: Add missing --ignore flag example to podman rm man page
Configurable GINKGOTIMEOUT in `winmake.ps1`
…om-onsi-ginkgo-v2-2.x fix(deps): update module github.com/onsi/ginkgo/v2 to v2.24.0
Add artifact tag to tags.yaml so API docs are ordered correctly (alphabetically with libpod endpoints first). Refactor artifact API documentation to be consistently formated. Refactor some descriptions and summaries to be more accurate and user friendly. Signed-off-by: Lewis Roy <lewis@redhat.com>
Check Content-Type header before unmarshaling errors to avoid unnecessary JSON parsing overhead for plain text responses. Signed-off-by: Jan Rodák <hony.com@seznam.cz>
Add support for loading images directly from machine paths to avoid unnecessary file transfers when the image archive is already accessible on the running machine through mounted directories. Changes include: - New /libpod/local/images/load API endpoint for direct machine loading - Machine detection and path mapping functionality - Fallback in tunnel mode to try optimized loading first This optimization significantly speeds up image loading operations when working with remote Podman machines by eliminating redundant file transfers for already-accessible image archives. Fixes: https://issues.redhat.com/browse/RUN-3249 Fixes: containers#26321 Signed-off-by: Jan Rodák <hony.com@seznam.cz>
Optimize image loading for Podman machines
…_api_doc [docs] Refactor Artifact API documentation
docs: Add missing flag examples to podman system connection add man page
docs: add missing groups and hgroups descriptors to podman top documentation
Signed-off-by: Tim Zhou <tizhou@redhat.com>
The winmake target is critical for the machine task as this is used to actually run the ginkgo command line. PR containers#26847 modified that line will not actually running the tests which means it is easy to break CI with this. Now the chnage of the PR was correct so it worked fine this time but for the future make sure we actually run the tests in such cases. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
In the journald driver there is a bug where the network event attributes are not preserved. This causes the network driver to be missing and that in turn causes the ToHumanReadable() function to print an empty line. Fix it by making sure we preserve the network driver in the event attributes. Fixes: https://issues.redhat.com/browse/RHEL-109790 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
…fixing-cpu-weight-test update tests duo to CRUN#1767 to support both values
Signed-off-by: Matt Heon <mheon@redhat.com>
docs: add LFX Insights badges
podman events: show network create/remove event with journald
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
So we know what we are actually running on in tests. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
…io-bbolt-1.x Update module go.etcd.io/bbolt to v1.4.3
unconfined is a special value and not a path as such it must not be converted otherwise --security-opt seccomp=unconfined fails as it tries to access a file called unconfined. Fixes: 3e8b2d7 ("Fix seccomp profile path on Windows") Fixes: containers#26855 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
…60_main Update release notes on main to reflect v5.6 release
ci: log wsl --version output
Relax _will_ to _may_ and add a clarifying _then_. Furthermore, we add a paragraph describing the behavior of the `--dns` command line option. This references containers#26812. Signed-off-by: Christoph Weiss <weiss@wsoptics.de>
…om-kevinburke-ssh_config-1.x Update module github.com/kevinburke/ssh_config to v1.4.0
…om-containers-gvisor-tap-vsock-0.x fix(deps): update module github.com/containers/gvisor-tap-vsock to v0.8.7
docs: add Containerfile doc link
…-golangci-lint-2.x chore(deps): update dependency golangci/golangci-lint to v2.5.0
Add creation timestamp to podman artifacts
Signed-off-by: Matt Heon <mheon@redhat.com>
Add a design document for Conmon v3
Adding a design document for Podman 6. it is a high level design that tries to encompasses proposed changes to Podman and its runtime environment. It should highlight major changes and features; but you will also find nitty detailed changes that have been idenitified. It is quite possible things in this document will change but it allows for open, transparent communication. Signed-off-by: Brent Baude <bbaude@redhat.com>
Add Podman 6 HLD
Signed-off-by: Celso Henrique Souza Silva <celsohenrique367@gmail.com>
* Added flags to point to TLS PEM files to use for exposing and connecting to an encrypted remote API socket with server and client authentication. * Added TLS fields for system connection ls templates. * Added special "tls" format for system connection ls to list TLS fields in human-readable table format. * Updated remote integration and system tests to allow specifying a "transport" to run the full suite against a unix, tcp, tls, or mtls system service. * Added system tests to verify basic operation of unix, tcp, tls, and mtls services, clients, and connections. Signed-off-by: Andrew Melnick <meln5674.5674@gmail.com>
Support for the subpath option was added the named volume mount type in [1] however this was missed from the docs. [1] https://github.com/containers/podman/pull/24532` Signed-off-by: Lewis Roy <lewis@redhat.com>
ContainerConfig has been removed from v1.45 InspectResponse.Container has also been removed but it seems we never implemented it. Ref: https://docs.docker.com/reference/api/engine/version-history/#v145-api-changes Signed-off-by: Lewis Roy <lewis@redhat.com>
- Change function signatures to return error instead of calling os.Exit() - Update cobra commands to use RunE instead of Run for proper error handling - Remove unused imports (fmt, os, define) - Remove FIXME comments about error handling inconsistency This allows defer statements to run properly and improves testability. Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
[compat api] Remove ContainerConfig field
…ds-error-handling cmd/podman/system: fix error handling in renumber and migrate commands
…al-size Added virtual size option in artifact ls format
…ount_options [DOCS] Update volume mount docs for subpath support
Update the Go Report Card badge in README.md to reference the current containers/podman repository instead of the outdated containers/libpod repository. This ensures consistency with other badges and prevents potential confusion for contributors. Signed-off-by: shiavm006 <shivammittal42006@gmail.com>
The code which comment refers to was removed by commit 2e4e1bb ("podman machine ssh handling"), so the comment is no longer valid. Remove it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Since Go 1.18, any is a type alias for interface{}. After commit 8631032
there is still one last instance of interface{} left -- replace it
manually.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This way we don't check the string twice. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Use github.com/containers/podman/v5 for both badge and report links so Go Report Card analyzes the v5 module instead of legacy root. Signed-off-by: shiavm006 <shivammittal42006@gmail.com>
…ibpod-reference docs: fix Go Report Card badge to reference current repository
Fixes: containers#27113 Signed-off-by: Volodymyr Pankin <volopank@gmail.com>
…pletion cmd: add autocomplete for network create --interface-name flag
Signed-off-by: ByoungUk Lee <nimdrak@gmail.com>
test: fix "run healthcheck" bindings test
Support (m)TLS API Socket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
33 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR automatically vendors changes from repo-A#3.