Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to override default days parameter on the command line #41

Conversation

AndrewFeeney
Copy link
Contributor

No description provided.

@freescout-helpdesk
Copy link
Contributor

Thanks. You need this option to run fetching emails manually for testing? The thing is that freescout:fetch-emails command is executed by cron at https://github.com/freescout-helpdesk/freescout/blob/master/app/Console/Kernel.php#L38

@AndrewFeeney
Copy link
Contributor Author

@freescout-helpdesk For testing yes, but mainly for initial import. The cron behaviour won't be affected as the default is still 3 days and the new option is optional.

@freescout-helpdesk freescout-helpdesk merged commit a23360c into freescout-help-desk:master Sep 21, 2018
@AndrewFeeney AndrewFeeney deleted the all_days_parameter_to_be_overridden_when_checking_emails branch September 21, 2018 06:49
@AndrewFeeney
Copy link
Contributor Author

@freescout-helpdesk Thanks!

@ghost ghost mentioned this pull request Apr 15, 2021
@mhktc mhktc mentioned this pull request May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants