Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Ackermann Steering to Citadel #1613

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Conversation

chapulina
Copy link
Contributor

🎉 New feature

Backport of:

Summary

The only change I needed to make for it to build on Citadel was removing IGN_UTILS_TEST_DISABLED_ON_WIN32 from the tests.

The goal is to use this in a demo world that will show up at the quick start dialog from #1536 .

Test it

Try the example world:

ign gazebo ackermann_steering.sdf

ign topic -t "/model/vehicle_blue/cmd_vel" -m ignition.msgs.Twist -p "linear: {x: 0.5}, angular: {z: 0.1}"

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

knoedler and others added 3 commits July 26, 2022 13:12
Signed-off-by: Kevin <ak619@lafn.org>

Co-authored-by: Kevin <ak619@lafn.org>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: LolaSegura <lsegura@ekumenlabs.com>
Signed-off-by: Andrew Ealovega <Andrew@Ealovega.dev>
Signed-off-by: Louise Poubel <louise@openrobotics.org>

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina added the OOBE 📦✨ Out-of-box experience label Jul 26, 2022
@chapulina chapulina added the 🏰 citadel Ignition Citadel label Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (ign-gazebo3@8552299). Click here to learn what that means.
The diff coverage is 85.54%.

@@              Coverage Diff               @@
##             ign-gazebo3    #1613   +/-   ##
==============================================
  Coverage               ?   78.02%           
==============================================
  Files                  ?      254           
  Lines                  ?    14932           
  Branches               ?        0           
==============================================
  Hits                   ?    11651           
  Misses                 ?     3281           
  Partials               ?        0           
Impacted Files Coverage Δ
src/systems/diff_drive/DiffDrive.hh 100.00% <ø> (ø)
...rc/systems/ackermann_steering/AckermannSteering.cc 85.49% <85.49%> (ø)
...rc/systems/ackermann_steering/AckermannSteering.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8552299...5f66b52. Read the comment docs.

@chapulina chapulina merged commit 61dc78d into ign-gazebo3 Jul 26, 2022
@chapulina chapulina deleted the chapulina/3/ackermann branch July 26, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel OOBE 📦✨ Out-of-box experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants