10 ➡️ master #462
Merged
10 ➡️ master #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… level (#251) SDFormat 9 requires the use of C++17 in its public headers, however it does not correctly expose this requirement in its installed imported targets. In particular, at the moment the requirement of C++17 is only documented via adding the -std=c++17 flag in the `SDFormat_CXX_FLAGS` variable, but this strategy has two problems: * It does not work unless a user explicitly pass this flags to its compilation targets, and this is definitely not obvious if it is not using directly SDFormat, but he is linking sdformat transitively through Gazebo 11. * If a different C++ version is set at the CMake level, it is possible that the `-std=c++17` flag is ignored (it depends what is the order with which the flags are passed to the compiler). For CMake consumers, a better strategy is to use the target_compile_features and explicitly mark that that this library requires the `cxx_std_17` feature, as `PUBLIC` because it also required in the public headers. As the minimum required version of CMake is 3.10, we can use cxx_std_17 as it is available in CMake 3.10, see https://cmake.org/cmake/help/v3.10/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html#prop_gbl:CMAKE_CXX_KNOWN_FEATURES . Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
* [sdf8] Changelog links to BitBucket backup Signed-off-by: Louise Poubel <louise@openrobotics.org> * more fixes, new version of script Signed-off-by: Louise Poubel <louise@openrobotics.org> * [sdf7] Changelog links to BitBucket backup (#238) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Update some more bitbucket issue references Signed-off-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: Steven Peters <scpeters@openrobotics.org>
* [sdf9] Changelog links to BitBucket backup Signed-off-by: Louise Poubel <louise@openrobotics.org> * [sdf8] Changelog links to BitBucket backup Signed-off-by: Louise Poubel <louise@openrobotics.org> * [sdf7] Changelog links to BitBucket backup (#238) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Convert bitbucket links for sdf9 Signed-off-by: Steven Peters <scpeters@openrobotics.org> * Fix link in API documentation Signed-off-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: Steven Peters <scpeters@openrobotics.org>
For backward compatibility if it is not defined compile the tests Signed-off-by: Silvio <silvio.traversaro@iit.it>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Changelog links to BitBucket backup Signed-off-by: Louise Poubel <louise@openrobotics.org> * Point to github issues, revert gazebo link Co-authored-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global> Co-authored-by: Steven Peters <scpeters@openrobotics.org>
* Add github action CI for uploading to codecov Signed-off-by: Steven Peters <scpeters@openrobotics.org> * Update codecov badge Signed-off-by: Steven Peters <scpeters@openrobotics.org>
This is an internal-only refactoring that changes the mechanics of how the sdf/** file data is embedded into the library. For one, it solves the "static initialization order fiasco" for the embedded data. The data is only loaded into memory upon first use, instead of as the library is being loaded. It also simplifies the ruby embedding code, making it more concise. I hope this is easier to maintain, but it also helps me when sharing Drake with consumers that always build from source, but will not install ruby as a compile-time prerequisite The EmbeddedSdf codegen now emits the cc file with the data; the header is stored in git. This provides an easier way to use a function to retrieve the embedded strings as static locals. The embedded SDF data is now combined into a single map. Embedding files should be boring, ala the WIP std::embed specification. It should not include application-layer logic encoding upgrade paths. This will also make it easier to avoid the "static destruction fiasco" in future commits, due to fewer functions to repair. Signed-off-by: Jeremy Nimmer <jeremy.nimmer@tri.global>
… level (#251) SDFormat 9 requires the use of C++17 in its public headers, however it does not correctly expose this requirement in its installed imported targets. In particular, at the moment the requirement of C++17 is only documented via adding the -std=c++17 flag in the `SDFormat_CXX_FLAGS` variable, but this strategy has two problems: * It does not work unless a user explicitly pass this flags to its compilation targets, and this is definitely not obvious if it is not using directly SDFormat, but he is linking sdformat transitively through Gazebo 11. * If a different C++ version is set at the CMake level, it is possible that the `-std=c++17` flag is ignored (it depends what is the order with which the flags are passed to the compiler). For CMake consumers, a better strategy is to use the target_compile_features and explicitly mark that that this library requires the `cxx_std_17` feature, as `PUBLIC` because it also required in the public headers. As the minimum required version of CMake is 3.10, we can use cxx_std_17 as it is available in CMake 3.10, see https://cmake.org/cmake/help/v3.10/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html#prop_gbl:CMAKE_CXX_KNOWN_FEATURES . Signed-off-by: Silvio Traversaro <silvio.traversaro@iit.it>
Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org> [sdf9] Changelog links to BitBucket backup (#240) * [sdf9] Changelog links to BitBucket backup Signed-off-by: Louise Poubel <louise@openrobotics.org> * [sdf8] Changelog links to BitBucket backup Signed-off-by: Louise Poubel <louise@openrobotics.org> * [sdf7] Changelog links to BitBucket backup (#238) Signed-off-by: Louise Poubel <louise@openrobotics.org> * Convert bitbucket links for sdf9 Signed-off-by: Steven Peters <scpeters@openrobotics.org> * Fix link in API documentation Signed-off-by: Steven Peters <scpeters@openrobotics.org> Co-authored-by: Steven Peters <scpeters@openrobotics.org>
* Remove unused includes of parser_urdf.hh in tests * mv include/sdf/parser_urdf.hh src, since the contents of this header were deprecated in 9.2 * parser_urdf.hh: remove deprecation macros and warning suppression * parser_urdf.hh: remove visibility macro * codecheck: helper functions public, use in test Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
…275) Signed-off-by: Eric Cousineau <eric.cousineau@tri.global>
…rating an error (#244) Currently, libsdformat silently ignores syntax errors when parsing values. For example, <pose>bad 0 0 0 0 0</pose> or <pose>0.1 0.2 0.3 0.4 0.5</pose> are both bad values for the <pose> tag, but the parsed values are <pose>0 0 0 0 0 0</pose> and <pose>0.1 0.2 0.3 0.4 0.5 0</pose> respectively. With this PR, libsdformat will generate an error for such values.
…s (Retry PR) (#303) Currently, some SDFormat description files contain min and max values, but the parser does not enforce those values in any way. This PR adds a validation step in the parser that checks if scalar values are within the allowed range. Note that this PR addresses only element values, not attributes.
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Simplify and fix copy constructors, restructure tests and increase coverage * Add joint and link tests * Add changelog Signed-off-by: Luca Della Vedova <luca@openrobotics.org> Co-authored-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
For backward compatibility if it is not defined compile the tests Signed-off-by: Silvio <silvio.traversaro@iit.it> Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
* add double sided materail param Signed-off-by: Ian Chen <ichen@osrfoundation.org> * fix loading param Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
…414) Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Currently there is a confusing error message if a file is loaded that finds a folder matching the name of a model to be included but the folder does not have a model.config file. This improves the first error message and stops further loading to prevent additional confusing messages. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This reverts part of commit 0e77816. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Merge forward sdf8 -> sdf9
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Looks like it uses gzdev which has been updated to use prereleases in gazebo-tooling/gzdev#26. I just needed to remove |
Codecov Report
@@ Coverage Diff @@
## master #462 +/- ##
==========================================
+ Coverage 87.56% 88.01% +0.45%
==========================================
Files 64 66 +2
Lines 9704 10069 +365
==========================================
+ Hits 8497 8862 +365
Misses 1207 1207
Continue to review full report at Codecov.
|
j-rivero
approved these changes
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge-forward from sdf10 to master. This replaces #432