-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11 ➡️ main #693
Merged
Merged
11 ➡️ main #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* STY: change booleans from 0 to "false" Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net> * STY: default=1 to default=true for bool Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>
Signed-off-by: Dre Westcook <dre.west@outlook.com> Signed-off-by: Dre Westcook <sir.dre.west@outlook.com> Signed-off-by: Ashton Larkin <ashton@openrobotics.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Ashton Larkin <ashton@openrobotics.org>
* BUG: make time type string [s ns] Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net> * FEAT: collapse whitespace Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net> Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net> Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Also point use a new codecov url now that sdformat is in the ignitionrobotics org Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* added reminder to update functions Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * corrected comment Signed-off-by: Jenn Nguyen <jenn@openrobotics.org> * TODO to Note Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net> (cherry picked from commit 232ac5c) Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
* update Ubuntu install docs Signed-off-by: Varun Agrawal <varagrawal@gmail.com> * use wget to get repo key Signed-off-by: Varun Agrawal <varagrawal@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Refactors two sections of the the function into helper functions, so that `sdf::readXml` doesn't go over 500 lines. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Utilizes ignition-cmake's IgnCodecheck module to create the codecheck target. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* add enable_orientation element to imu Signed-off-by: Ian Chen <ichen@osrfoundation.org> * codecheck Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
* Test URDF continuous joint effort/velocity limits * Fix parsing of URDF continuous joint effort/velocity limits Fixes #683. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## main #693 +/- ##
==========================================
+ Coverage 87.90% 87.99% +0.09%
==========================================
Files 72 73 +1
Lines 11022 11116 +94
==========================================
+ Hits 9689 9782 +93
- Misses 1333 1334 +1
Continue to review full report at Codecov.
|
chapulina
reviewed
Sep 8, 2021
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey
force-pushed
the
azeey/11_to_main_20210907
branch
from
September 8, 2021 18:25
9b7e6f9
to
a60501b
Compare
chapulina
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port 11 to main
Branch comparison: main...sdf11
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)