Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11 ➡️ main #693

Merged
merged 26 commits into from
Sep 8, 2021
Merged

11 ➡️ main #693

merged 26 commits into from
Sep 8, 2021

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Sep 8, 2021

➡️ Forward port

Port 11 to main

Branch comparison: main...sdf11

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

FirefoxMetzger and others added 25 commits August 11, 2021 10:40
* STY: change booleans from 0 to "false"

Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>

* STY: default=1 to default=true for bool

Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>
Signed-off-by: Dre Westcook <dre.west@outlook.com>
Signed-off-by: Dre Westcook <sir.dre.west@outlook.com>
Signed-off-by: Ashton Larkin <ashton@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Co-authored-by: Ashton Larkin <ashton@openrobotics.org>
* BUG: make time type string [s ns]

Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>

* FEAT: collapse whitespace

Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>

Co-authored-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Franco Cipollone <franco.c@ekumenlabs.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>

Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
Also point use a new codecov url now that sdformat is in the
ignitionrobotics org

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
* added reminder to update functions

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* corrected comment

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>

* TODO to Note

Signed-off-by: Jenn Nguyen <jenn@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: FirefoxMetzger <sebastian@wallkoetter.net>
(cherry picked from commit 232ac5c)

Co-authored-by: Addisu Z. Taddese <addisu@openrobotics.org>
* update Ubuntu install docs

Signed-off-by: Varun Agrawal <varagrawal@gmail.com>

* use wget to get repo key

Signed-off-by: Varun Agrawal <varagrawal@gmail.com>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Refactors two sections of the the function into helper functions, so that `sdf::readXml` doesn't go over 500 lines. 

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Utilizes ignition-cmake's IgnCodecheck module to create the codecheck target.


Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
* add enable_orientation element to imu

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

* codecheck

Signed-off-by: Ian Chen <ichen@osrfoundation.org>

Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
* Test URDF continuous joint effort/velocity limits
* Fix parsing of URDF continuous joint effort/velocity limits

Fixes #683.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey self-assigned this Sep 8, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #693 (a60501b) into main (96ac74e) will increase coverage by 0.09%.
The diff coverage is 92.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #693      +/-   ##
==========================================
+ Coverage   87.90%   87.99%   +0.09%     
==========================================
  Files          72       73       +1     
  Lines       11022    11116      +94     
==========================================
+ Hits         9689     9782      +93     
- Misses       1333     1334       +1     
Impacted Files Coverage Δ
include/sdf/Element.hh 100.00% <ø> (ø)
include/sdf/Exception.hh 100.00% <ø> (ø)
include/sdf/Param.hh 77.14% <ø> (ø)
src/Error.cc 100.00% <ø> (ø)
src/Joint.cc 97.61% <ø> (ø)
src/Param.cc 89.18% <ø> (ø)
src/ParamPassing.cc 97.41% <ø> (ø)
src/SDFExtension.hh 100.00% <ø> (ø)
src/Utils.cc 82.81% <ø> (ø)
src/ign.cc 74.41% <ø> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ac74e...a60501b. Read the comment docs.

@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey force-pushed the azeey/11_to_main_20210907 branch from 9b7e6f9 to a60501b Compare September 8, 2021 18:25
@azeey azeey merged commit f27e538 into main Sep 8, 2021
@azeey azeey deleted the azeey/11_to_main_20210907 branch September 8, 2021 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.