Fix for Maven Package Naming Convention Handling #33676
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: delvh <dev.lh@web.de>
Notice: some of pull requests haven't been added to the changelog - Which have been backported to v1.22 - https://github.com/go-gitea/gitea/pulls?q=sort%3Aupdated-desc+is%3Apr+milestone%3A1.23.0+is%3Amerged+label%3Abackport%2Fv1.22 - Which have skip-changelog - https://github.com/go-gitea/gitea/pulls?q=sort%3Aupdated-desc+is%3Apr+milestone%3A1.23.0+is%3Amerged+-label%3Abackport%2Fv1.22+label%3Askip-changelog - Build and Testing - https://github.com/go-gitea/gitea/pulls?q=sort%3Aupdated-desc+is%3Apr+milestone%3A1.23.0+is%3Amerged+label%3Abackport%2Fv1.22+label%3Atype%2Ftesting - https://github.com/go-gitea/gitea/pulls?q=sort%3Aupdated-desc+is%3Apr+milestone%3A1.23.0+is%3Amerged+label%3Abackport%2Fv1.22+label%3Atopic%2Fbuild - No `type` label marked may be missed, I need to check one by one, but I believe those are not too many. --------- Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…go-gitea#32882) Backport go-gitea#32881 by ExplodingDragon Incorrect content was introduced while generating the index, which has now been removed, and the missing fields have been added. Co-authored-by: Exploding Dragon <explodingfkl@gmail.com>
backport go-gitea#32896 to 1.23
…gitea#32901) (go-gitea#32912) Backport go-gitea#32901 by @lunny Fix go-gitea#32897 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
…ea#32913) Backport go-gitea#32908 by ExplodingDragon It is mentioned in https://man.archlinux.org/man/PKGBUILD.5: 'The variable is not allowed to contain colons, forward slashes, hyphens, or whitespace.' `_` is also an allowed character, and some software in the Arch Linux AUR uses this naming convention. Co-authored-by: Exploding Dragon <explodingfkl@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Backport go-gitea#32949 by wxiaoguang * Fix go-gitea#32871 * Fix go-gitea#32948 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…gitea#32945) (go-gitea#32959) Backport go-gitea#32945 by @katsusan Fix go-gitea#32428. Patch the regex to match `,`besides `.` `"` `'` `:` and space. Co-authored-by: katsu <evergonuaa@gmail.com>
Backport go-gitea#32958 by wxiaoguang Continue even if the avatar deleting fails Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Backport go-gitea#32944 by wxiaoguang Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Backport go-gitea#32953 by wxiaoguang Some PRs were before tmpl ctx refactoring and used outdated code Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…tea#32946) (go-gitea#32964) Backport go-gitea#32946 by wxiaoguang Fix go-gitea#23703 When Gitea starts, it reads GITEA_RUNNER_REGISTRATION_TOKEN or GITEA_RUNNER_REGISTRATION_TOKEN_FILE to add registration token. Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Backport go-gitea#32966 by metiftikci Co-authored-by: metiftikci <metiftikci@hotmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Backport go-gitea#32943 by wxiaoguang Fix go-gitea#30568 At the moment, here only `GroupID` (no `Version`) is parsed & used Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Backport go-gitea#32974 by Zettat123 Co-authored-by: Zettat123 <zettat123@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…2979) Backport go-gitea#32923 by @lunny Fix go-gitea#32887 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
…32983) Backport go-gitea#32980 by wxiaoguang Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…go-gitea#32996) Backport go-gitea#32988 by @Zettat123 Fix go-gitea#32891 Co-authored-by: Zettat123 <zettat123@gmail.com>
…vating user account (go-gitea#32998) (go-gitea#33001) Backport go-gitea#32998 by Zettat123 Fix go-gitea#32807 Co-authored-by: Zettat123 <zettat123@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Backport go-gitea#32999 by @a1012112796 user with read permission should also can create agit flow pull request. looks this logic was broken in go-gitea#31033 this pull request try fix it and add test code. Signed-off-by: a1012112796 <1012112796@qq.com> Co-authored-by: a1012112796 <1012112796@qq.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
) Backport go-gitea#33007 by metiftikci Co-authored-by: metiftikci <metiftikci@hotmail.com>
Backport go-gitea#33008 by @lunny A repository with no issue will display a random number on activities page. This is caused by wrong usage of `And` and `Or`.  Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
…3032) Backport go-gitea#33031 by henrygoodman Fixes go-gitea#33017 Co-authored-by: Henry Goodman <79623665+henrygoodman@users.noreply.github.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…33038) Backport go-gitea#33025 by TheFox0x7 Adds test for expected behavior Closes: go-gitea#33013 --- Co-authored-by: TheFox0x7 <thefox0x7@gmail.com>
Partial backport of go-gitea#33024
Backport go-gitea#33543 In the old `pickTask`, when getting secrets or variables failed, the task could get stuck in the `running` status (task status is `running` but the runner did not fetch the task). To fix this issue, these steps should be in one transaction. --------- Co-authored-by: Zettat123 <zettat123@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…, fuzzy prompt, mirror proxy, adopt git) (go-gitea#33569) (go-gitea#33577) Backport go-gitea#33569 by @wxiaoguang * Make artifact list output has stable order * Fix go-gitea#33506 * Fix go-gitea#33521 * Fix go-gitea#33288 * Fix go-gitea#33196 * Fix go-gitea#33561 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…itea#33580) Backport go-gitea#33262 by ExplodingDragon Only show the latest version of the package in the arch repo. closes go-gitea#33534 Co-authored-by: Exploding Dragon <explodingfkl@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…chments (go-gitea#33585) (go-gitea#33592) Backport go-gitea#33585 by @lunny Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
…o-gitea#33598) Backport go-gitea#33593 by @Zettat123 Use `git.timeout.DEFAULT` configuration instead of 60 seconds. Co-authored-by: Zettat123 <zettat123@gmail.com>
Backport go-gitea#33597 by @ericLemanissier follows-up be4e961 This is the same modification as go-gitea@be4e961 but for force-pushes. It is needed, because `git fetch` reveals force pushes for github mirrors: ``` $ git fetch --tags origin remote: Enumerating objects: 22, done. remote: Counting objects: 100% (22/22), done. remote: Compressing objects: 100% (4/4), done. remote: Total 9 (delta 5), reused 8 (delta 5), pack-reused 0 (from 0) Unpacking objects: 100% (9/9), 1.70 KiB | 12.00 KiB/s, done. From https://github.com/conan-io/conan-center-index 729f0f1b8f..48184eddeb refs/pull/26595/head -> refs/pull/26595/head + 0c31ab60a3...1283cca9e7 refs/pull/26595/merge -> refs/pull/26595/merge (forced update) ``` Fix go-gitea#33200 PS: I did not test the modification, but it is the exact same change as the last hunk in https://github.com/go-gitea/gitea/pull/33224/files#diff-bb5cdb90db0f0e7f6716c0e6d0b9cbb67f08d82052b03ab3a7b5e23a1d76aed7 , just moved to the previous case of the switch Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
Backport go-gitea#33594 by lunny --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
…o-gitea#33632) Backport go-gitea#33620 by lunny Fix go-gitea#33603 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
--------- Co-authored-by: Zettat123 <zettat123@gmail.com>
Backport go-gitea#33645 by ericLemanissier Co-authored-by: ericLemanissier <ericLemanissier@users.noreply.github.com>
Backport go-gitea#33659 by wxiaoguang Fix go-gitea#33658 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Backport go-gitea#33663 by @lunny Fix go-gitea#33660 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
… (go-gitea#33673) Backport go-gitea#33653 by @lunny Fix go-gitea#33634 Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
GiteaBot
added
the
lgtm/need 2
|
@dianaStr7 I noticed you've updated the locales for non-English languages. These will be overwritten during the sync from our translation tool Crowdin. If you'd like to contribute your translations, please visit https://crowdin.com/project/gitea. Please revert the changes done on these files. 🍵 |
github-actions
bot
added
modifies/translation
modifies/api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the bug reported in #33672 related to the handling of Maven packages with older naming conventions. The
getVersionByPackageNamemethod in thepackage_versionhas been updated to throw an exception ErrNotExist when no packages are found. This error already was expected for the call back mechanism for maven packages for legacy name handling.Changes Made
getVersionByPackageNamemethod now throws an exception utils.ErrNotExistRelated Ticket