-
Notifications
You must be signed in to change notification settings - Fork 7
Add Accessibility user preferences #714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jacbn
wants to merge
57
commits into
master
Choose a base branch
from
feature/accessibility-user-preference
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
=======================================
Coverage 36.53% 36.53%
=======================================
Files 536 536
Lines 23689 23689
Branches 2857 2857
=======================================
Hits 8655 8655
Misses 14175 14175
Partials 859 859 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This allows more granular control over test visibility. Instead of relying on `hiddenFromRoles` to hide certain tests from the list of available tests (which also implies making them inaccessible via a direct link), we can hide them from that list using `nofilter` while still allowing them to be accessed via direct link.
This means we won't need to clear and restore our local DB in order to work with test data - this one will load the integration test data by default.
…r-in-set-tests Respect `nofilter` in Set Tests
Add maxMarks to LLMFreeTextQuestionDTO
…ment/increase-gameboard-q-limit
…ment/increase-gameboard-q-limit
…ard-q-limit Load gameboard question limit from config
I believe that not providing an upper concept should be the same as providing a blank upper concept.
…ng strategy Restores original QF behaviour
…y existing strategy" This reverts commit e6cf256.
Dependency updates
Improve search for book questions by section number This commit significantly improves search relevance, particularly for finding book questions by section number (e.g., "A1.2") stored in the subtitle. It introduces high-priority, exact-string matches for id, title, and subtitle and increases their respective search weights. To reduce noise and improve performance, wildcard matching on general page content has been removed in favor of stricter, whole-word matching. This results in a 2-4x performance increase and much more accurate results for targeted queries. The trade-off is that partial-word searches within content (e.g., "supercond" for "superconductivity") will no longer return matches. In a few months, we should review that everything is fine, as part of this ticket: https://trello.com/c/26WQGXnn/5782-review-search-improvements.
Allow permissions & notes on fasttrack question pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new preference field,
ACCESSIBILITY
, to better separate accessibility features from display features.Also adds a migration to convert
REDUCED_MOTION
andPREFER_MATHML
fromDISPLAY_SETTINGS
toACCESSIBILITY
.