Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65161] Remove usage of Digester taken from Jenkins Core #5

Merged
merged 2 commits into from
May 18, 2021

Conversation

MRamonLeon
Copy link

@MRamonLeon MRamonLeon commented May 3, 2021

This is a follow up PR for jenkinsci/jenkins#5320 tracked by https://issues.jenkins.io/browse/JENKINS-65161

We're removing Digester from Jenkins core because it's not used there. This PR adds Digester to this plugin and builds the object to parse xmls safely.

I can't validate the changes because a repository is no longer available. Any help about where to get those dependencies from would be appreciated:

<repository>
   <id>praqma-repo</id>
   <url></url>
</repository>

Desired reviewers per https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-clearcase-ucm-plugin.yml:
@MadsNielsen, @Praqma

Additional reviewers:
@alecharp @rsandell @olamy @bitwiseman @car-roll

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@alecharp
Copy link
Member

alecharp commented May 4, 2021

@ewelinawilkosz sorry to ping you directly here, but could you help this PR to be merged here? The plugin cannot be built locally because the Praqma Maven Repository disappeared and I couldn't find it under eficode domaine.

If you (or your colleagues) cannot maintain this plugin, could it be mark as up for adoption? Thank you for any help you can provide here.

@atombrella
Copy link

@alecharp We'll mark the plugin for adoption. Thanks for highlighting this.

@MRamonLeon
Copy link
Author

@atombrella you should have permissions now. I asked to give you the permissions on IRC. If not, ask in the IRC channel that maybe some administrator has to trigger the bot to give you the permissions on GH. https://www.jenkins.io/projects/infrastructure/ircbot/#github-repo-management

@atombrella
Copy link

@MRamonLeon Could you have a look at making this mergeable? Somehow this fork wasn't updated with the commits from praqma, which unfortunately result in the code in this repository not being able to build. It should do that now.

Then I'll release a new version today.

@atombrella atombrella merged commit 4102822 into jenkinsci:master May 18, 2021
@MRamonLeon
Copy link
Author

Thank you @atombrella for your work here to get it released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants