-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-65161] Remove usage of Digester taken from Jenkins Core #5
Conversation
@ewelinawilkosz sorry to ping you directly here, but could you help this PR to be merged here? The plugin cannot be built locally because the Praqma Maven Repository disappeared and I couldn't find it under eficode domaine. If you (or your colleagues) cannot maintain this plugin, could it be mark as up for adoption? Thank you for any help you can provide here. |
@alecharp We'll mark the plugin for adoption. Thanks for highlighting this. |
@atombrella you should have permissions now. I asked to give you the permissions on IRC. If not, ask in the IRC channel that maybe some administrator has to trigger the bot to give you the permissions on GH. https://www.jenkins.io/projects/infrastructure/ircbot/#github-repo-management |
@MRamonLeon Could you have a look at making this mergeable? Somehow this fork wasn't updated with the commits from praqma, which unfortunately result in the code in this repository not being able to build. It should do that now. Then I'll release a new version today. |
Co-authored-by: Adrien Lecharpentier <adrien.lecharpentier@gmail.com>
Thank you @atombrella for your work here to get it released. |
This is a follow up PR for jenkinsci/jenkins#5320 tracked by https://issues.jenkins.io/browse/JENKINS-65161
We're removing Digester from Jenkins core because it's not used there. This PR adds Digester to this plugin and builds the object to parse xmls safely.
I can't validate the changes because a repository is no longer available. Any help about where to get those dependencies from would be appreciated:
Desired reviewers per https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-clearcase-ucm-plugin.yml:
@MadsNielsen, @Praqma
Additional reviewers:
@alecharp @rsandell @olamy @bitwiseman @car-roll