Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-65161] remove commons-digester2 from core and upgrade plugins to commons-digester3 #40

Merged
merged 5 commits into from
May 24, 2021

Conversation

olamy
Copy link
Member

@olamy olamy commented Mar 24, 2021

No description provided.

…s to commons-digester3

Signed-off-by: olivier lamy <olamy@apache.org>
@olamy
Copy link
Member Author

olamy commented Mar 24, 2021

jenkinsci/jenkins#5320

knapsu
knapsu previously approved these changes Mar 24, 2021
Copy link
Collaborator

@knapsu knapsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple changes. Looks good to me.

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and wrong: Likely creates a security vulnerability as described in jenkinsci/jenkins#5320 (comment)

Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
@olamy
Copy link
Member Author

olamy commented Apr 20, 2021

@knapsu @daniel-beck fixed

Signed-off-by: olivier lamy <olamy@apache.org>
pom.xml Outdated Show resolved Hide resolved
rsandell
rsandell previously approved these changes Apr 29, 2021
@olamy
Copy link
Member Author

olamy commented Apr 29, 2021

@mig42 @knapsu @miryamGSM ping (as you are the main maintainers)

@mig42
Copy link
Contributor

mig42 commented Apr 29, 2021

Thanks for finishing the PR! We'll get it merged ASAP, when we can allocate some time to also update the code in our internal repositories.

alecharp
alecharp previously approved these changes May 3, 2021
MRamonLeon
MRamonLeon previously approved these changes May 3, 2021
bitwiseman
bitwiseman previously approved these changes May 3, 2021
@olamy olamy dismissed stale reviews from bitwiseman, MRamonLeon, alecharp, and rsandell via 6ebc5ae May 3, 2021 20:22
@alecharp
Copy link
Member

alecharp commented May 4, 2021

@mig42 is there any blockers for a merge and release of the plugin? if so, please let us know, so we can try to help you.

@batmat batmat dismissed daniel-beck’s stale review May 4, 2021 19:46

concern addressed -- stale review

@olamy
Copy link
Member Author

olamy commented May 24, 2021

@mig42 ping :)

Copy link
Contributor

@mig42 mig42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. I'll give it a spin in my environment and merge it if everything works as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants