[JENKINS-65161] remove digester 2 from core

[olamy]

No description provided.

[olamy]

see jenkinsci/jenkins#5320

[dconneely]

LGTM, except for one minor suggestion I can fix later.

[olamy]

@dconneely ooops my bad sorry for the copy/paste typo :(
Thanks for merging this!

[batmat]

@dconneely +1, thanks for merging this!

May I ask you whether you would consider releasing a version with this fix? We're trying to adapt the ecosystem to support jenkinsci/jenkins#5320 so any release done is one plugin less to worry about :-).

Thanks a lot.

[dconneely]

@batmat @olamy Sure, I aim to cut a release in the next few days. Thanks for all the help with this!

[Wallace-EXE]

When using the latest Jenkins version with Dimensions plugin added (0.9.2) , I get the following error when building:

[DIMENSIONS] ) [DIMENSIONS] Calculating changes for directory '\'... FATAL: org/apache/commons/digester/Digester java.lang.NoClassDefFoundError: org/apache/commons/digester/Digester at hudson.plugins.dimensionsscm.DimensionsChangeLogParser.createDigester(DimensionsChangeLogParser.java:68)
It looks like Jenkins no longer has the Commons Digester Library: https://support.cloudbees.com/hc/en-us/articles/4402545935501--JEP-231-Commons-Digester-Library-Removal

[dconneely]

When using the latest Jenkins version with Dimensions plugin added (0.9.2) , I get the following error when building:

[DIMENSIONS] ) [DIMENSIONS] Calculating changes for directory '\'... FATAL: org/apache/commons/digester/Digester java.lang.NoClassDefFoundError: org/apache/commons/digester/Digester at hudson.plugins.dimensionsscm.DimensionsChangeLogParser.createDigester(DimensionsChangeLogParser.java:68) It looks like Jenkins no longer has the Commons Digester Library: https://support.cloudbees.com/hc/en-us/articles/4402545935501--JEP-231-Commons-Digester-Library-Removal

Looks like you are correct and the wrong version of Apache Commons Digester was included in the POM w.r.t. the version used by the source code when this PR was merged. One temporary workaround in the meantime is to drop commons-digester-2.1.jar file into the plugins/dimensionsscm/WEB-INF/lib/ folder to make the older JAR available, but I'll aim to make a new release ASAP.

[olamy]

jar is ok.

 unzip -l target/dimensionsscm.hpi|grep digester
   241614  06-23-2021 18:14   WEB-INF/lib/commons-digester3-3.2.jar

But my bad import should be changed in DimensionsChangeLogParser to digester3 package.

[olamy]

see #41

[batmat]

@dconneely just to make maintenance simpler, now also that time has passed, I would recommend just bumping the jenkins.version for this plugin to a Jenkins Core version including the commons-digester removal. This way it will be more immediately visible is something is off.

That means either:

• 2.303.1 if you go for the first LTS with it, or
• 2.297 if you aim for the weekly

[dconneely]

Not currently able to do a release (authentication failed for https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/dimensionsscm/0.9.3/dimensionsscm-0.9.3.hpi, status: 401 Unauthorized -> [Help 1]). I can use my Jenkins account (dconneely) to log in to accounts.jenkins.io and issues.jenkins.io, but the same credentials are not working with repo.jenkins-ci.org. I have tried changing my password on accounts.jenkins.io to no effect.