This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
[JENKINS-65161] remove commons-digester2 from core and upgrade plugins to commons-digester3 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to commons-digester3 Signed-off-by: olivier lamy <olamy@apache.org>
Signed-off-by: olivier lamy <olamy@apache.org>
@mig42 ping as you are the main maintainer |
Sure, we'll get this merged and released ASAP 😊 |
10 tasks
rsandell
reviewed
May 3, 2021
rsandell
previously approved these changes
May 3, 2021
MRamonLeon
reviewed
May 3, 2021
import hudson.scm.ChangeLogParser; | ||
import hudson.scm.ChangeLogSet; | ||
import hudson.scm.RepositoryBrowser; | ||
import org.apache.commons.digester3.Digester; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The important line
MRamonLeon
approved these changes
May 3, 2021
alecharp
approved these changes
May 4, 2021
@mig42 any blockers to get this PR merge and cut a release of the plugin? Thanks. |
@mig42 ping :) |
mig42
approved these changes
May 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I'll merge the PR once I verified it works in my environment.
basil
added a commit
to basil/jep
that referenced
this pull request
May 25, 2021
basil
added a commit
to basil/jep
that referenced
this pull request
May 25, 2021
basil
added a commit
to basil/jep
that referenced
this pull request
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.