Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade to commons-digester3 #4

Merged
merged 1 commit into from
May 5, 2021
Merged

upgrade to commons-digester3 #4

merged 1 commit into from
May 5, 2021

Conversation

car-roll
Copy link
Contributor

upgrade to commons-digester3. Follow up of jenkinsci/jenkins#5320

ping @nbelliot @TimSVector

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@car-roll car-roll force-pushed the commons-digester3 branch from 1016c18 to 306b304 Compare April 30, 2021 21:35
@olamy olamy mentioned this pull request May 1, 2021
Merged
10 tasks
@aytey
Copy link
Collaborator

aytey commented May 3, 2021

@car-roll @alecharp @MRamonLeon: this PR seems to make the VectorCAST plugin align with jenkinsci/jenkins#5320

What’s the impact of us merging this before #5320 gets merged in?

Does commons-digester3 already exist in a fully-released Jenkins?

@car-roll
Copy link
Contributor Author

car-roll commented May 3, 2021

@andrewvaughanj there should be no impact of merging in this early as commons-digester3 is not a part of Jenkins. jenkinsci/jenkins#5320 is removing commons-digester:2.1 from Jenkins so that plugins will have to explicitly call out the library in the dependencies.

aytey
aytey requested changes May 3, 2021
View reviewed changes
Copy link
Collaborator

@aytey aytey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes necessary, but there are outstanding questions on the PR.

@car-roll car-roll requested a review from aytey May 4, 2021 20:52
aytey
aytey approved these changes May 4, 2021
View reviewed changes
Copy link
Collaborator

@aytey aytey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @car-roll!

@aytey
Copy link
Collaborator

aytey commented May 4, 2021

@TimSVector, @nbelliot: these changes look good to me; do you want me to merge?

@nbelliot
Copy link
Collaborator

nbelliot commented May 5, 2021

Thanks for reviewing, @andrewvaughanj. I am going to create a branch off of master to run the change through our CI before merging it into master. I'll take it from here. Thanks, again.

@aytey
Copy link
Collaborator

aytey commented May 5, 2021

All yours!

@nbelliot
Copy link
Collaborator

nbelliot commented May 5, 2021

Test suite is clean. Thanks, everyone.

@nbelliot nbelliot merged commit 1f97cde into jenkinsci:master May 5, 2021
@MRamonLeon
Copy link

Thank you very much @nbelliot . May I ask you to cut a release with this change?

@nbelliot
Copy link
Collaborator

nbelliot commented May 6, 2021

@MRamonLeon: We plan on performing a release soon along with some of unrelated additional changes.

basil added a commit to basil/jep that referenced this pull request May 25, 2021
@basil
Noting the release of jenkinsci/vectorcast-coverage-plugin#4 and jenk…
3178fe4 
…insci/dimensionsscm-plugin#21.
basil added a commit to basil/jep that referenced this pull request May 25, 2021
@basil
Noting the release of jenkinsci/cvs-plugin#55, jenkinsci/vectorcast-c…
e7f0c2f 
…overage-plugin#4, and jenkinsci/dimensionsscm-plugin#21.
basil added a commit to basil/jep that referenced this pull request May 25, 2021
@basil
Noting the release of jenkinsci/cvs-plugin#55, jenkinsci/vectorcast-c…
c9e0e7e 
…overage-plugin#4, jenkinsci/dimensionsscm-plugin#21, and jenkinsci/plasticscm-mergebot-plugin#3.
basil added a commit to basil/jep that referenced this pull request May 25, 2021
@basil
Noting the release of jenkinsci/cvs-plugin#55, jenkinsci/clearcase-uc…
105ecc0 
…m-plugin#5, jenkinsci/vectorcast-coverage-plugin#4, jenkinsci/dimensionsscm-plugin#21, and jenkinsci/plasticscm-mergebot-plugin#3.
basil added a commit to basil/jep that referenced this pull request May 25, 2021
@basil
Noting the release of jenkinsci/cvs-plugin#55, jenkinsci/plasticscm-p…
70b6e66 
…lugin#40, jenkinsci/clearcase-ucm-plugin#5, jenkinsci/vectorcast-coverage-plugin#4, and jenkinsci/dimensionsscm-plugin#21.
basil added a commit to basil/jep that referenced this pull request May 25, 2021
@basil
Noting the release of jenkinsci/cvs-plugin#55, jenkinsci/plasticscm-p…
7165f5d 
…lugin#40, jenkinsci/clearcase-ucm-plugin#5, jenkinsci/vectorcast-coverage-plugin#4, jenkinsci/dimensionsscm-plugin#21, and jenkinsci/plasticscm-mergebot-plugin#3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecharp alecharp alecharp approved these changes

@MRamonLeon MRamonLeon MRamonLeon approved these changes

@aytey aytey aytey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@car-roll @aytey @nbelliot @MRamonLeon @alecharp