refactor(cypress): move memory cache tests out of payment for misc #6992
+742
−539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixincreate
added
A-CI-CD
pixincreate
force-pushed
the
refactor-add-memory-cache
branch
from
0cc9122 to
960f4ef
Compare
14 tasks
pixincreate
force-pushed
the
refactor-add-memory-cache
branch
from
5377539 to
76b0ffa
Compare
hyperswitch-bot
bot
added
M-database-changes
pixincreate
force-pushed
the
refactor-add-memory-cache
branch
from
76b0ffa to
08bfd71
Compare
pixincreate
force-pushed
the
refactor-add-memory-cache
branch
from
08bfd71 to
c18cdbd
Compare
hyperswitch-bot
bot
removed
M-database-changes
likhinbopanna
previously approved these changes
Jan 13, 2025
cypress-tests/cypress/e2e/spec/Routing/00001-VolumeBasedRouting.cy.js
Outdated
Show resolved
Hide resolved
cypress-tests/cypress/e2e/spec/Routing/00002-RuleBasedRouting.cy.js
Outdated
Show resolved
Hide resolved
likhinbopanna
previously approved these changes
Jan 13, 2025
likhinbopanna
previously approved these changes
Jan 13, 2025
…d-memory-cache * 'main' of github.com:juspay/hyperswitch: (38 commits) fix(cypress): uncaught exceptions thrown by `hyperswitch.io` (#7092) ci(workflows): Add code coverage reporting for v2 (#6884) chore(version): 2025.01.23.0 refactor: [CYBERSOURCE, BANKOFAMERICA, WELLSFARGO] Move code to crate hyperswitch_connectors (#6908) Documentation edits made through Mintlify web editor chore: enable 128-column-tables feature for diesel crate (#6857) feat(connector): [ADYEN ] Consume transaction id for PaymentsPreProcessing error (#7061) chore(version): 2025.01.22.0 feat(routing): Integrate global success rates (#6950) feat(email): Add mailhog by default in docker-compose for local smtp server (#6869) refactor: check allowed payment method types in enabled options (#7019) feat(router): add payment method-specific features to connector feature list (#6963) Refactor: Customer email and browser Information (#7034) feat(connectors): fiuu,novalnet,worldpay - extend NTI flows (#6946) fix(cypress): address cybersource redirection inconsistency (#7057) chore(version): 2025.01.21.0 refactor(payment-link): use shouldRemoveBeforeUnloadEvents flag for handling removal of beforeunload events through SDK (#7072) refactor(router): refactor ctp flow to fetch mca_id and get the connector creds instead of connector_name (#6859) chore(version): 2025.01.20.0 fix(relay): populate connector metadata in the refunds flow (#7045) ...
likhinbopanna
previously approved these changes
Jan 24, 2025
Sakilmostak
reviewed
Jan 24, 2025
| cy.updateConfigs(globalState, key, newValue); | ||
| cy.fetchConfigs(globalState, key, newValue); | ||
| cy.setConfigs(globalState, key, newValue, "UPDATE"); | ||
| cy.setConfigs(globalState, key, value, "FETCH"); |
There was a problem hiding this comment.
check for newValue variable
likhinbopanna
approved these changes
Jan 24, 2025
Sakilmostak
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6992 +/- ##
=======================================
Coverage ? 4.12%
=======================================
Files ? 1010
Lines ? 207403
Branches ? 0
=======================================
Hits ? 8548
Misses ? 198855
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR aims at refactoring:
cypress-testsfolder structure to reduce confusion and chaos in withine2edirectoryprevious:
. └── cypress ├── e2e │ ├── PaymentMethodListTest │ ├── PaymentMethodListUtils │ ├── PaymentTest │ ├── PaymentUtils │ ├── PayoutTest │ ├── PayoutUtils │ ├── RoutingTest │ └── RoutingUtils ├── fixtures ├── support └── utilspresent:
reduce / remove duplicate commands in memory cache (config calls) by unifying them
paymentsservice tomiscjust so that, tests that are independent of business profile, mca, merchant account can be added here in the futurenew command addition to miscellaneous tests:
npm run cypress:miscslight security improvement by forcing the api key to expire within
24hourscloses #6993
documentation will be updated later
Additional Changes
Motivation and Context
Too many boiler plates, too many useless code
How did you test it?
stripe:
memory cache:
health check:
ci:
Checklist
npm run formatnpm run lint