Confirmation emails have no FROM or FROM email address 2.2.4

[tstamplis]

Preconditions

Magento 2.2.4
PHP 7.1
Cpanel Server

Steps to reproduce

Production Mode
Single Store Mode
Add product to cart
Checkout

Expected result

Order confirmation email with FROM name and email address sent to customer per settings from store email addresses in config

Actual result

Order confirmation email contains no FROM or FROM EMAIL address.

[SamB-GB]

I can confirm I am also seeing this issue. In order to work around the problem I have had to force the FROM header from the php.ini file.

sendmail_path= "/usr/sbin/sendmail -t -i -f enter@emailaddresshere.com"

[chequille]

Have the same issue: Ticket #14945

[andy17612]

@SamB-GB So need to add the mine mail in the php.ini ?thank you

[chequille]

Hi @SambB-GB,
I guess this is a misunderstanding. gwharton closed my issue "Store Email Adresses are not used anymore" because it is the same as this one. It does not mean, that there will be no soultion for it.

Correct gwharton ?
BR Chequille

[gwharton]

@chequille yes. The solution to both will be tracked under this issue. Having it tracked in two places will just lead to confusion.

[SamB-GB]

Yes thats correct @rigu12

[gwharton]

This is the commit that introduced this bug.

f2bfdd9

Broken during fix applied for #11740

If you manually revert the changes in files according to that commit, you can get back to pre bug status.

app/code/Magento/Sales/Model/Order/Email/SenderBuilder.php
lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php

@RomaKis What was this commit trying to achieve?

[jsdupuis]

Facing the same issue here in Magento 2.2.4. We have one website with 2 stores (Thai + English).

[ozziel]

I had the same issue. after 2.2.3 >2.2.4 update. We have 4 websites with 2 stores each.

I did as gwharton suggested, I used the 2 files from 2,2,3 and it's working correctly now from what I can tell.

Thank you!

[andy17612]

so 2.2.4 recover 2.2.3 this file?? @ozziel
app/code/Magento/Sales/Model/Order/Email/SenderBuilder.php
lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php

[ozziel]

You will have to recover them from their source folders:
NOTE: if you can't tell your restore function where to restore files and it restores them to the original path BE SURE TO BACKUP ORIGINALS ALREADY THERE FROM 2.2.4 before restoring
vendor/magento/module-sales/Model/Order/Email/SenderBuilder.php
vendor/magento/framework/Mail/Template/TransportBuilder.php

and then create the above folders and put them there
app/code/Magento/Sales/Model/Order/Email/SenderBuilder.php
lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php

Keep in mind that this overrides magento default functions so if and when the corrections are made, you will need to remove these to use default functions again.

Hope this helps.

[jsdupuis]

I did as ozziel suggested (thanks for pointing to the vendor folder where my files were) and it fixed the problem.

[littlescrat]

Correct. The fix by @ozziel worked for me too.
I hope there will come up a patch for this issue.

[sashas777]

Have you tried to switch to any SMTP module if it would fix the issue until Magento patch will be available?

[littlescrat]

I have installed the module "Mageplaza_Smtp" and i tried "MagePal_GmailSmtpApp". Both gave me a blank from-sender. But that is obvious, because the problem is much further in the procedure. See answer from ozziel, the paths.

[sashas777]

Guys I made quick extension and forced it to be used only on Magento 2.2.4 version assume that bugfix will be in the next release.
I tested and it works on my websites. I hope it can help you as well:
https://github.com/sashas777/bug-from-email

You can install it using composer and then remove when will be new Magento 2 release. If you will forget to remove then you will have version compatibility error with any other Magento 2 release.

[rav-redchamps]

The problem is they created a new class

Magento\Framework\Mail\Template\TransportBuilderByStore

and correctly added FROM header to member "message" of the class.

But the "message" member of TransportBuilderByStore never used. Instead, the member "message" of the class TransportBuilder is getting used(which never updated with FROM email).

Moral of the story, they added FROM email correctly but never used it while sending the email.

The tiny extension by @sashas777 does the required job as of now.

@sashas777 Good Job!! Just one suggestion, it would be better if you can rename the folder 'Plugin' to 'Rewrite' or something else. Because the fix is done using class rewrite instead of the plugin. The folder name "Plugin" misleads ;-)

[rav-redchamps]

@sashas777 I did the required change and created a pull request. Please merge it if it makes sense 😃

[sashas777]

@ravinders-121

Thanks - I updated the package.

[gwharton]

Hi @bnymn I'm sorry i can't help with applying patches via composer, as I run from git.

However, if you scroll up through previous comments there is a downloadable patch for 2.2.8 and also some instructions (somewhere) on how to apply these. Unfortunately I can't help with this further.

I look forward to the 2.2.9 release when this issue can finally be put behind us!!! :)

[DanielRuf]

@bnymn see #14952 (comment)

[iKoala]

This bug still exists in 2.3.0.

[gwharton]

@iKoala Yes, Scheduled for 2.3.1 See #18471

[iKoala]

@iKoala Yes, Scheduled for 2.3.1 See #18471

@gwharton Thanks for the reply. Is there any work around at the meantime?

[seo99ita]

I had the same problem until 2.2.8.
I did an update installing 2.3.1 from scratch, the problem has been solved.

[good-geek]

fix ok only sales email, but not working in reset password or new customer or new user store

[gwharton]

Please raise new issue to cover those bugs.

[msawyers]

See issue #23199

[salelsol]

Has someone upgraded and verified if the error continues in version 2.2.9?

[msawyers]

Yes, it continues and got worse on 2.3.1 and 2.3.2 @salelsol

[DanielRuf]

#14952 (comment)

Please raise new issue to cover those bugs.

[lhall-amphibee]

I upgraded a store from 2.2.7 to 2.2.9 and the issue is fixed for me.

[salelsol]

• It continues to work well and the emails are received correctly after upgraded to Magento 2.2.9 ??

[mike-jianxin-mo]

Got this issue after upgrading from 2.2.5 to 2.2.9.

[lhall-amphibee]

@mike-jianxin-mo it was working before and now you have the issue ? Maybe you should try to open a new issue ?

[rishabhchd19]

Guyz, applying the patch resolving the issue.

…

On Tue, 23 Jul, 2019, 12:46 PM Loïc HALL, ***@***.***> wrote: @mike-jianxin-mo <https://github.com/mike-jianxin-mo> it was working before and now you have the issue ? Maybe you should try to open a new issue ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#14952?email_source=notifications&email_token=AHMDY3M4TCMSFU2IFUBL3NLQA2V37A5CNFSM4E6BQEWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2SE6XQ#issuecomment-514084702>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHMDY3LUHD5O3C53JIV7AEDQA2V37ANCNFSM4E6BQEWA> .

[ramandhillon31]

Hi,

I'm using Magento Ver. 2.3.0.
The order confirmation email is coming from a very strange email address.
I have updated all the store email address.
Please advise.

Thank you,
Raman

[DanielRuf]

Hi @ramandhillon31,

Please check the latest releases for the patch.
Also see #14952 (comment)

[msawyers]

@ramandhillon31

Fix will be in magento 2.3.3 version when it is released

[maxq]

Anyone have a solution for 2.3? I tried overwriting some of the files with ones from 2.3.3 but looks like only option is to upgrade, however that usually means incompatibility with some extensions.

[DanielRuf]

Please check the .patch URL of the linked PR. You may have to scroll a bit up. You can apply it with composer-patches.

[maxq]

Still getting up to speed with M2 and Github, not sure where that is and what I'm looking for.

[hostep]

@maxq, a lot of useful comments were already posted above, but I get it that it takes a while to read through them, here are some highlights which might help you further:

• check the link in: Confirmation emails have no FROM or FROM email address 2.2.4 #14952 (comment)
• a concrete example (for Magento 2.2.x) can be found in Confirmation emails have no FROM or FROM email address 2.2.4 #14952 (comment)

For further questions or assistance about how to apply patches, you'd best switch over to https://magento.stackexchange.com/ or https://community.magento.com/

[maxq]

I ended up using the composer patch MDVA-10993_EE_2.2.4_v1.composer.patch from Magento.
It says it's works up to 2.3 (maybe) but it did work for our 2.3 installation.
Thanks

[imebrijesh]

Guys I made quick extension and forced it to be used only on Magento 2.2.4 version assume that bugfix will be in the next release.
I tested and it works on my websites. I hope it can help you as well:
https://github.com/sashas777/bug-from-email

You can install it using composer and then remove when will be new Magento 2 release. If you will forget to remove then you will have version compatibility error with any other Magento 2 release.

Hi @hostep
This is not working for version 2.3.0... can you please help me to work for this version too?

[hostep]

@imebrijesh: if you are able to upgrade to a newer version of Magento, I would strongly recommend it, because this email bug is far from the only serious bug in version 2.3.0, later versions are a lot more stable (even though the still have other email bugs).

If you really need a patch, then I strongly recommend you learn how to create and apply patches, because you will need it a lot in this Magento universe where releases are only created every 3 months and every release contains new bugs.

If you have further questions, please refer to https://magento.stackexchange.com/ or https://community.magento.com/