…N parser if non-empty string

Updated via: `govendor fetch github.com/aws/aws-sdk-go/...@v1.15.68`

…go-v1.15.68

deps: aws/aws-sdk-go@v1.15.68

This makes the force delete flow more obvious and allows for easier reordering or parallelisation of delete behaviours

tests/provider: Fix unparam Linting Issues and Enable in TravisCI Testing

…tion about VPC peering restrictions

Allow parallel running of DX VIF acceptance tests

…y' of https://github.com/nodefortytwo/terraform-provider-aws into nodefortytwo-feature/delete-public-ssh-keys-on-iam_user-force-destroy

Fixes hashicorp#5176

…ss Keys and Login Profiles

```
--- PASS: TestAccAWSUser_disappears (7.15s)
--- PASS: TestAccAWSUser_ForceDestroy_SSHKey (9.38s)
--- PASS: TestAccAWSUser_importBasic (9.49s)
--- PASS: TestAccAWSUser_ForceDestroy_AccessKey (9.55s)
--- PASS: TestAccAWSUser_ForceDestroy_LoginProfile (9.78s)
--- PASS: TestAccAWSUser_pathChange (13.74s)
--- PASS: TestAccAWSUser_nameChange (13.80s)
--- PASS: TestAccAWSUser_basic (13.94s)
--- PASS: TestAccAWSUser_permissionsBoundary (31.21s)
```

…-force-destroy'

…vice

Changes:

* `govendor fetch github.com/pquerna/otp/totp`
* Implement MFA device code generation for acceptance testing

```
--- PASS: TestAccAWSUser_ForceDestroy_MFADevice (9.16s)
```

…rity_group_rule-vpc-peering-restrictions

docs/resource/aws_security_group*: Add note and link to AWS documentation about VPC peering restrictions

…user-mfa

tests/resource/aws_iam_user: Enable TestAccAWSUser_ForceDestroy_MFADevice

Usage of wrong attribute of aws_s3_bucket

…ating existing tags.

Changes:
* data-source/aws_efs_file_system: Add `arn` attribute
* data-source/aws_efs_mount_target: Add `file_system_arn` attribute
* resource/aws_efs_file_system: Add `arn` attribute
* resource/aws_efs_mount_target: Add `file_system_arn` attribute

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsEfsFileSystem (23.38s)
--- PASS: TestAccAWSEFSFileSystem_basic (47.76s)
--- PASS: TestAccDataSourceAwsEfsMountTargetByMountTargetId (220.04s)
--- PASS: TestAccAWSEFSMountTarget_basic (399.10s)
```

…melliff/terraform-provider-aws into tomelliff-dlm-lifecycle-policy-resource

```
--- PASS: TestAccAWSDlmLifecyclePolicy_Basic (15.16s)
--- PASS: TestAccAWSDlmLifecyclePolicy_Full (20.28s)
```

…-system-arn

service/efs: Add File System ARN attributes

Update acmpca_certificate_authority.html.markdown

create new resource during short_name update in aws_opsworks_application

fix typo

aws_ssm_parameter data source doesn't allow you to store a parameter

…ion argument

`aws_cloudwatch_log_group` `arn` attribute references will automatically contain `:*` due to the CloudWatch Logs API implementation. While we may in the future trim that attribute in the `aws_cloudwatch_log_group` resource in a major release, this provides a quick band aid for issues when using it with this resource.

Changes:
* resource/aws_flow_log: Automatically trim `:*` suffix from `log_destination` argument
* tests/resource/aws_flow_log: Switch acceptance testing to `resource.ParallelTest()`

```
--- PASS: TestAccAWSFlowLog_LogDestinationType_CloudWatchLogs (25.45s)
--- PASS: TestAccAWSFlowLog_LogDestinationType_S3 (28.20s)
--- PASS: TestAccAWSFlowLog_SubnetID (30.30s)
--- PASS: TestAccAWSFlowLog_VPCID (41.48s)
```

…4w/terraform-provider-aws into kl4w-kinesis-analytics-application

…_log-trim-log_destination-wildcard

resource/aws_flow_log: Automatically trim :* suffix from log_destination argument

r/aws_s3_bucket: Fix 'Error putting S3 replication configuration: MalformedXML' error

…elTest() and randomize naming

```
--- PASS: TestAccAWSKinesisAnalyticsApplication_basic (11.06s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_update (17.23s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_addCloudwatchLoggingOptions (25.38s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSource (30.47s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_updateCloudwatchLoggingOptions (38.74s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_referenceDataSourceUpdate (54.39s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsKinesisStream (87.98s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsKinesisStream (88.00s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsAdd (94.81s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsAdd (110.65s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_outputsUpdateKinesisStream (172.40s)
--- PASS: TestAccAWSKinesisAnalyticsApplication_inputsUpdateKinesisStream (172.42s)
```

…roject-name

Fix typo in aws_codebuild_webook docs

Update flow_log.html.markdown

…oc_examples

D format doc examples

… with `engine_version` and `snapshot_identifier` on creation

This is a similar refactoring to the `aws_db_instance` resource that has occurred recently over a few iterations. The refactoring prevents a class of potential bugs related to unexpected update errors or an extraneous update after restoring from snapshot or S3. Instead we should be left with "requires two applies" type issues, which are more workable.

Changes:
* resource/aws_rds_cluster: Refactor Create function to call ModifyDBCluster directly instead of Update function

Output from acceptance testing:

```
--- PASS: TestAccAWSRDSCluster_BacktrackWindow (177.25s)
--- PASS: TestAccAWSRDSCluster_backupsUpdate (194.40s)
--- PASS: TestAccAWSRDSCluster_basic (123.91s)
--- PASS: TestAccAWSRDSCluster_DeletionProtection (195.88s)
--- PASS: TestAccAWSRDSCluster_encrypted (124.72s)
--- PASS: TestAccAWSRDSCluster_EncryptedCrossRegionReplication (1578.13s)
--- PASS: TestAccAWSRDSCluster_EngineMode (378.92s)
--- PASS: TestAccAWSRDSCluster_EngineMode_ParallelQuery (128.98s)
--- PASS: TestAccAWSRDSCluster_EngineVersion (137.07s)
--- PASS: TestAccAWSRDSCluster_EngineVersionWithPrimaryInstance (1117.06s)
--- PASS: TestAccAWSRDSCluster_generatedName (145.47s)
--- PASS: TestAccAWSRDSCluster_iamAuth (156.83s)
--- PASS: TestAccAWSRDSCluster_importBasic (128.64s)
--- PASS: TestAccAWSRDSCluster_kmsKey (143.46s)
--- PASS: TestAccAWSRDSCluster_missingUserNameCausesError (2.34s)
--- PASS: TestAccAWSRDSCluster_namePrefix (123.69s)
--- PASS: TestAccAWSRDSCluster_Port (297.06s)
--- PASS: TestAccAWSRDSCluster_s3Restore (1391.94s)
--- PASS: TestAccAWSRDSCluster_ScalingConfiguration (281.57s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier (364.76s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_DeletionProtection (490.59s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EncryptedRestore (426.54s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_ParallelQuery (366.46s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineMode_Provisioned (355.81s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Different (386.44s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_EngineVersion_Equal (407.85s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredBackupWindow (355.70s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_PreferredMaintenanceWindow (386.74s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_Tags (364.61s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds (362.35s)
--- PASS: TestAccAWSRDSCluster_SnapshotIdentifier_VpcSecurityGroupIds_Tags (463.75s)
--- PASS: TestAccAWSRDSCluster_takeFinalSnapshot (186.68s)
--- PASS: TestAccAWSRDSCluster_updateCloudwatchLogsExports (163.99s)
--- PASS: TestAccAWSRDSCluster_updateIamRoles (143.56s)
--- PASS: TestAccAWSRDSCluster_updateTags (163.35s)
```

…ider-aws into flosell-issue-688

Changes:
* resource/aws_vpc: Add IPv6 CIDR block association waiter during VPC creation
* resource/aws_vpc: Refactor IPv6 CIDR block association waiters into separate functions
* tests/resource/aws_vpc: Stronger IPv6 checks and general refactoring

```
--- PASS: TestAccAWSVpc_coreMismatchedDiffs (22.74s)
--- PASS: TestAccAWSVpc_DisabledDnsSupport (27.42s)
--- PASS: TestAccAWSVpc_classiclinkOptionSet (28.19s)
--- PASS: TestAccAWSVpc_classiclinkDnsSupportOptionSet (28.40s)
--- PASS: TestAccAWSVpc_basic (28.41s)
--- PASS: TestAccAWSVpc_bothDnsOptionsSet (36.09s)
--- PASS: TestAccAWSVpc_update (40.07s)
--- PASS: TestAccAWSVpc_tags (45.86s)
--- PASS: TestAccAWSVpc_AssignGeneratedIpv6CidrBlock (64.86s)
--- PASS: TestAccAWSVpc_Tenancy (65.81s)
```

```
--- PASS: TestAccAWSEBSVolume_basic (23.19s)
--- PASS: TestAccAWSEBSVolume_withTags (23.28s)
--- PASS: TestAccAWSEBSVolume_NoIops (23.31s)
--- PASS: TestAccAWSEBSVolume_updateIops (43.79s)
--- PASS: TestAccAWSEBSVolume_updateType (43.95s)
--- PASS: TestAccAWSEBSVolume_updateSize (44.21s)
--- PASS: TestAccAWSEBSVolume_kmsKey (52.88s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (167.64s)
```

… test, and refactor for current practices

```
--- PASS: TestAccAWSEBSVolume_basic (23.19s)
--- PASS: TestAccAWSEBSVolume_withTags (23.28s)
--- PASS: TestAccAWSEBSVolume_NoIops (23.31s)
--- PASS: TestAccAWSEBSVolume_updateIops (43.79s)
--- PASS: TestAccAWSEBSVolume_updateType (43.95s)
--- PASS: TestAccAWSEBSVolume_updateSize (44.21s)
--- PASS: TestAccAWSEBSVolume_kmsKey (52.88s)
--- PASS: TestAccAWSEBSVolume_updateAttachedEbsVolume (167.64s)
```

…ipv6-on-create

resource/aws_vpc: Wait for IPv6 association on Create

…cluster-snapshot-version

resource/aws_rds_cluster: Prevent `InvalidParameterCombination` error with `engine_version` and `snapshot_identifier` on creation

…raform-provider-aws into domwong-bugfix/ec2_diff_tags

…er-aws into domwong-bugfix/ec2_diff_tags

…anics

…ontent

…nt resource

…policy_document-more-clarification

docs/service/iam: Further clarify issues with aws_iam_policy_attachment resource

Previously:

```
--- FAIL: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (9.08s)
    testing.go:538: Step 0 error: Error planning: 2 errors occurred:
        	* aws_cloudwatch_metric_alarm.test: "alarm_actions.0" doesn't look like a valid ARN ("^arn:[\\w-]+:([a-zA-Z0-9\\-])+:([a-z]{2}-(gov-)?[a-z]+-\\d{1})?:(\\d{12})?:(.*)$"): "arn:aws:automate:us-west-2:ec2:reboot"
        	* aws_cloudwatch_metric_alarm.test: "alarm_actions.0" does not match EC2 automation ARN ("^arn:[\\w-]+:automate:[\\w-]+:ec2:(recover|stop|terminate)$"): "arn:aws:automate:us-west-2:ec2:reboot"
```

```
--- PASS: TestAccAWSCloudWatchMetricAlarm_AlarmActions_EC2Automate (194.97s)
```

Updated via: `govendor fetch github.com/aws/aws-sdk-go/...@v1.15.72`

…n when protocol is -1/ALL

Previously:

```
--- FAIL: TestAccAWSSecurityGroupRule_Description_AllPorts (21.74s)
    testing.go:538: Step 2 error: Error applying: 1 error occurred:
        	* aws_security_group_rule.test: 1 error occurred:
        	* aws_security_group_rule.test: Error updating security group sg-0b6f5a54297754be3 rule description: InvalidParameterValue: When protocol is ALL, you cannot specify from-port.
```

Output from acceptance testing:

```
--- PASS: TestAccAWSSecurityGroupRule_Description_AllPorts (36.84s)
--- PASS: TestAccAWSSecurityGroupRule_Egress (21.08s)
--- PASS: TestAccAWSSecurityGroupRule_EgressDescription (21.13s)
--- PASS: TestAccAWSSecurityGroupRule_EgressDescription_updates (33.23s)
--- PASS: TestAccAWSSecurityGroupRule_ExpectInvalidCIDR (1.77s)
--- PASS: TestAccAWSSecurityGroupRule_ExpectInvalidTypeError (1.72s)
--- PASS: TestAccAWSSecurityGroupRule_Ingress_Classic (20.29s)
--- PASS: TestAccAWSSecurityGroupRule_Ingress_Ipv6 (42.93s)
--- PASS: TestAccAWSSecurityGroupRule_Ingress_Protocol (41.24s)
--- PASS: TestAccAWSSecurityGroupRule_Ingress_VPC (20.04s)
--- PASS: TestAccAWSSecurityGroupRule_IngressDescription (20.98s)
--- PASS: TestAccAWSSecurityGroupRule_IngressDescription_updates (35.99s)
--- PASS: TestAccAWSSecurityGroupRule_Issue5310 (20.12s)
--- PASS: TestAccAWSSecurityGroupRule_MultiDescription (82.07s)
--- PASS: TestAccAWSSecurityGroupRule_MultiIngress (22.57s)
--- PASS: TestAccAWSSecurityGroupRule_PartialMatching_basic (47.79s)
--- PASS: TestAccAWSSecurityGroupRule_PartialMatching_Source (44.23s)
--- PASS: TestAccAWSSecurityGroupRule_PrefixListEgress (51.97s)
--- PASS: TestAccAWSSecurityGroupRule_Race (274.72s)
--- PASS: TestAccAWSSecurityGroupRule_SelfReference (40.94s)
--- PASS: TestAccAWSSecurityGroupRule_SelfSource (41.11s)
```

…with configurable timeout

Tested by adding a deliberate 2 minute sleep inside the first `resource.Retry()` function before the CreateFunction call.

Previously:

```
--- FAIL: TestAccAWSLambdaFunction_basic (104.02s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_lambda_function.lambda_function_test: 1 error occurred:
        	* aws_lambda_function.lambda_function_test: Error creating Lambda function: timeout while waiting for state to become 'success' (timeout: 1m0s)
```

Now:

```
--- PASS: TestAccAWSLambdaFunction_basic (113.77s)
```

…ecking

…dwatch_metric_alarm-ec2-automate-reboot

resource/aws_cloudwatch_metric_alarm: Accept EC2 automate reboot ARN

…t attribute checks in TestAccAWSSecurityGroupRule_Description_AllPorts

```
--- PASS: TestAccAWSSecurityGroupRule_Description_AllPorts (25.78s)
```

…da_function-slow-uploads

resource/aws_lambda_function: Handle slower code uploads on creation with configurable timeout

…rity_rule_rule-all-update-description

resource/aws_security_group_rule: Properly handle updating description when protocol is -1/ALL

…go-v1.15.72

deps: aws/aws-sdk-go@v1.15.72

…meRateExceeded` errors on creation

Found via acceptance testing:

```
--- FAIL: TestAccAWSEbsSnapshotDataSource_MostRecent (27.42s)
    testing.go:538: Step 0 error: Error applying: 1 error occurred:
        	* aws_ebs_snapshot.test: 1 error occurred:
        	* aws_ebs_snapshot.test: SnapshotCreationPerVolumeRateExceeded: The maximum per volume CreateSnapshot request rate has been exceeded. Use an increasing or variable sleep interval between requests.
```

```
--- PASS: TestAccAWSEBSSnapshot_withDescription (26.62s)
--- PASS: TestAccAWSEbsSnapshotDataSource_basic (28.90s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (43.31s)
--- PASS: TestAccAWSEBSSnapshot_withKms (67.28s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (68.51s)
--- PASS: TestAccAWSEBSSnapshot_basic (85.15s)
```

…ng acceptance test

Also refactors the testing to be region agnostic.

```
--- PASS: TestAccAWSEbsSnapshotDataSource_basic (28.90s)
--- PASS: TestAccAWSEbsSnapshotDataSource_Filter (43.31s)
--- PASS: TestAccAWSEbsSnapshotDataSource_MostRecent (68.51s)
```