chore: adds disableButtonEnhancement on triggers #25211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9e33b17:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 5064d0a96759e753725fe5168d683471ee2a1a75 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1260 | 1285 | 5000 | |
| Button | mount | 914 | 924 | 5000 | |
| FluentProvider | mount | 1475 | 1476 | 5000 | |
| FluentProviderWithTheme | mount | 587 | 576 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 545 | 542 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 581 | 578 | 10 | |
| MakeStyles | mount | 1964 | 1973 | 50000 | |
| SpinButton | mount | 2353 | 2349 | 5000 |
bsunderhus
force-pushed
the
react-trigger/chore--adds-disableButtonEnhancement-on-triggers
branch
from
4021f39
to
6b090e0
Compare
bsunderhus
requested review from
a team,
chpalac,
ling1726,
GeoffCoxMSFT,
khmakoto,
behowell and
sopranopillow
as code owners
ling1726
approved these changes
Oct 14, 2022
sopranopillow
approved these changes
Oct 14, 2022
bsunderhus
force-pushed
the
react-trigger/chore--adds-disableButtonEnhancement-on-triggers
branch
2 times, most recently
from
1095155
to
315ac6e
Compare
bsunderhus
force-pushed
the
react-trigger/chore--adds-disableButtonEnhancement-on-triggers
branch
from
315ac6e
to
9e33b17
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Oct 27, 2022
* master: (21 commits) fix(react-tabster): make acceptCondition optional as Tabster dont require it (microsoft#25416) chore: adds disableButtonEnhancement on triggers (microsoft#25211) applying package updates feat: Add support for the wbtx whiteboard file extension (microsoft#25346) chore(react-select): migrate to new package structure (microsoft#25359) chore(react-divider): migrate to new package structure (microsoft#25360) fix(docsite): codesandbox exports now working properly for newly migrated v9 packages (microsoft#25388) Website: fix focus border on UHF footer links (microsoft#25389) applying package updates feat: re-export react-table logic hooks (microsoft#25386) chore(react-aria): migrate to new package structure (microsoft#25199) chore(babel-preset-global-context): migrate to new package structure (microsoft#25340) applying package updates fix: Improve Stack's style recalculation performance by selectively applying children selectors (microsoft#25381) applying package updates fix(projects-test): explicitly install next version 12 to fix CI (microsoft#25374) allow details element to be toggled inside selection and focus zones (microsoft#25324) fix(react-persona): Changing persona's versions to pinned versions (microsoft#25367) update fast element and foundation package versions stable (microsoft#25364) chore(keyboard-keys, priority-overflow, react-context-selector, react-conformance-griffel): migrate to new package structure (microsoft#25362) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* chore: adds disableButtonEnhancement on triggers * chore: removes unnecessary tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
As discussed over internal Tech Sync and also at #24960, triggers should not enhance their child to behave like buttons.
disableButtonEnhancementon every trigger usage everywhere.