-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Website: fix focus border on UHF footer links #25389
Website: fix focus border on UHF footer links #25389
Conversation
📊 Bundle size report🤖 This report was generated against 32865fdfad96c52b75ffdce36120e30940871229 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b4818d23565b104be9b2c8eb58453d514e431b12 (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2a23a33:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a before and after screenshot of the links to the PR description?
* Update Link.stories.tsx * Update Link.stories.tsx * update * chore(babel-preset-global-context): migrate to new package structure (microsoft#25340) * chore(react-aria): migrate to new package structure (microsoft#25199) * feat: re-export react-table logic hooks (microsoft#25386) * applying package updates * Website: fix focus border on UHF footer links (microsoft#25389) * use not uhf link to increase specificity instead of body tag * improve comment * fix(docsite): codesandbox exports now working properly for newly migrated v9 packages (microsoft#25388) * chore(react-divider): migrate to new package structure (microsoft#25360) * chore(react-select): migrate to new package structure (microsoft#25359) * feat: Add support for the wbtx whiteboard file extension (microsoft#25346) * revert some changes * update storywright version * rename * rename * updatE * update * update * update * update * not needed * update * update Co-authored-by: Tristan Watanabe <tristan.watanabe@gmail.com> Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com> Co-authored-by: Fluent UI Build <fluentui-internal@service.microsoft.com> Co-authored-by: Micah Godbolt <mgodbolt@microsoft.com> Co-authored-by: jieleiwang <51342814+jieleiwang@users.noreply.github.com>
* master: (21 commits) fix(react-tabster): make acceptCondition optional as Tabster dont require it (microsoft#25416) chore: adds disableButtonEnhancement on triggers (microsoft#25211) applying package updates feat: Add support for the wbtx whiteboard file extension (microsoft#25346) chore(react-select): migrate to new package structure (microsoft#25359) chore(react-divider): migrate to new package structure (microsoft#25360) fix(docsite): codesandbox exports now working properly for newly migrated v9 packages (microsoft#25388) Website: fix focus border on UHF footer links (microsoft#25389) applying package updates feat: re-export react-table logic hooks (microsoft#25386) chore(react-aria): migrate to new package structure (microsoft#25199) chore(babel-preset-global-context): migrate to new package structure (microsoft#25340) applying package updates fix: Improve Stack's style recalculation performance by selectively applying children selectors (microsoft#25381) applying package updates fix(projects-test): explicitly install next version 12 to fix CI (microsoft#25374) allow details element to be toggled inside selection and focus zones (microsoft#25324) fix(react-persona): Changing persona's versions to pinned versions (microsoft#25367) update fast element and foundation package versions stable (microsoft#25364) chore(keyboard-keys, priority-overflow, react-context-selector, react-conformance-griffel): migrate to new package structure (microsoft#25362) ...
* use not uhf link to increase specificity instead of body tag * improve comment
body a[href]:focus was removing the focus outlines of the footer links. This PR uses a not(footer link class) to both omit those links from the selector, and serve as the selector to increase the link specificity for the rest of our docs.
before
after