Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(projects-test): explicitly install next version 12 to fix CI #25374

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Oct 25, 2022

Changes:

  • next major bump to version 13.0.0 was just released which is causing projects-test to break since it now requires a peer dependency on React 18. This PR explicitly installs the previous major version of next which is version 12 to fix CI error.

Fixes error below:

verb @fluentui/projects-test test |  warning package.json: No license field
verb @fluentui/projects-test test |  $ /tmp/project-nextjs--1760-DcBG6QG62tc5/test-app/node_modules/.bin/next build
verb @fluentui/projects-test test |  warn  - No build cache found. Please configure build caching for faster rebuilds. Read more: https://nextjs.org/docs/messages/no-cache
verb @fluentui/projects-test test |  Attention: Next.js now collects completely anonymous telemetry regarding usage.
verb @fluentui/projects-test test |  This information is used to shape Next.js' roadmap and prioritize features.
verb @fluentui/projects-test test |  You can learn more, including how to opt-out if you'd not like to participate in this anonymous program, by visiting the following URL:
verb @fluentui/projects-test test |  https://nextjs.org/telemetry
verb @fluentui/projects-test test |  
verb @fluentui/projects-test test |  info  - Linting and checking validity of types...
verb @fluentui/projects-test test |  info  - Creating an optimized production build...
verb @fluentui/projects-test test |  
verb @fluentui/projects-test test |  > Build error occurred
verb @fluentui/projects-test test |  Error: Next.js requires React 18.2.0 to be installed.
verb @fluentui/projects-test test |      at Object.getBaseWebpackConfig [as default] (/tmp/project-nextjs--1760-DcBG6QG62tc5/test-app/node_modules/next/dist/build/webpack-config.js:59:19)
verb @fluentui/projects-test test |      at async Promise.all (index 0)
verb @fluentui/projects-test test |      at async Span.traceAsyncFn (/tmp/project-nextjs--1760-DcBG6QG62tc5/test-app/node_modules/next/dist/trace/trace.js:79:20)
verb @fluentui/projects-test test |      at async /tmp/project-nextjs--1760-DcBG6QG62tc5/test-app/node_modules/next/dist/build/index.js:449:33
verb @fluentui/projects-test test |      at async /tmp/project-nextjs--1760-DcBG6QG62tc5/test-app/node_modules/next/dist/build/index.js:433:13
verb @fluentui/projects-test test |      at async Span.traceAsyncFn (/tmp/project-nextjs--1760-DcBG6QG62tc5/test-app/node_modules/next/dist/trace/trace.js:79:20)
verb @fluentui/projects-test test |      at async Object.build [as default] (/tmp/project-nextjs--1760-DcBG6QG62tc5/test-app/node_modules/next/dist/build/index.js:64:29)
verb @fluentui/projects-test test |  error Command failed with exit code 1.
verb @fluentui/projects-test test |  info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
verb @fluentui/react-northstar test |  PASS test/specs/components/Carousel/CarouselPaddle-test.tsx (6.109 s)
verb @fluentui/projects-test test |  Error: child process exited with code 1
verb @fluentui/projects-test test |      at ChildProcess.<anonymous> (/mnt/vss/_work/1/s/scripts/gulp/sh.ts:29:14)
verb @fluentui/projects-test test |      at ChildProcess.emit (events.js:400:28)
verb @fluentui/projects-test test |      at maybeClose (internal/child_process.js:1058:16)
verb @fluentui/projects-test test |      at Process.ChildProcess._handle.onexit (internal/child_process.js:293:5)
verb @fluentui/projects-test test |  
verb @fluentui/projects-test test |  
verb @fluentui/projects-test test |  
verb @fluentui/projects-test test |  
verb @fluentui/projects-test test |  
verb @fluentui/projects-test test |  
verb @fluentui/projects-test test |  @fluentui/projects-test: The test suite failed, please check FAQ in "packages/fluentui/projects-test/README.md" for more details
verb @fluentui/projects-test test |  

@DustyTheBot
Copy link

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 0ff6cf8

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 2435ea50f924fa6467a07829f3d4715e545d93c0

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0ff6cf8:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 25, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2435ea50f924fa6467a07829f3d4715e545d93c0 (build)

@TristanWatanabe TristanWatanabe merged commit 7733f95 into microsoft:master Oct 25, 2022
@TristanWatanabe TristanWatanabe deleted the fix-CI branch October 25, 2022 20:38
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 27, 2022
* master: (21 commits)
  fix(react-tabster): make acceptCondition optional as Tabster dont require it (microsoft#25416)
  chore: adds disableButtonEnhancement on triggers (microsoft#25211)
  applying package updates
  feat: Add support for the wbtx whiteboard file extension (microsoft#25346)
  chore(react-select): migrate to new package structure (microsoft#25359)
  chore(react-divider): migrate to new package structure (microsoft#25360)
  fix(docsite): codesandbox exports now working properly for newly migrated v9 packages (microsoft#25388)
  Website: fix focus border on UHF footer links (microsoft#25389)
  applying package updates
  feat: re-export react-table logic hooks (microsoft#25386)
  chore(react-aria): migrate to new package structure (microsoft#25199)
  chore(babel-preset-global-context): migrate to new package structure (microsoft#25340)
  applying package updates
  fix: Improve Stack's style recalculation performance by selectively applying children selectors (microsoft#25381)
  applying package updates
  fix(projects-test): explicitly install next version 12 to fix CI (microsoft#25374)
  allow details element to be toggled inside selection and focus zones (microsoft#25324)
  fix(react-persona): Changing persona's versions to pinned versions (microsoft#25367)
  update fast element and foundation package versions stable (microsoft#25364)
  chore(keyboard-keys, priority-overflow, react-context-selector, react-conformance-griffel): migrate to new package structure (microsoft#25362)
  ...
@khmakoto khmakoto added Fluent UI react-northstar (v0) Work related to Fluent UI V0 and removed Fluent UI react-northstar labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants