Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-select): migrate to new package structure #25359

Merged
merged 3 commits into from
Oct 26, 2022

Conversation

TristanWatanabe
Copy link
Member

Changes:

Issue:

@TristanWatanabe TristanWatanabe self-assigned this Oct 24, 2022
@TristanWatanabe TristanWatanabe requested review from a team and smhigley as code owners October 24, 2022 21:52
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 24, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.94 kB
17.663 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.603 kB
52.909 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
react-select
Select
21.61 kB
7.568 kB
🤖 This report was generated against 07141711530bbdba82fd5198fe4bcef462403f40

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 24, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1305 1307 5000
Button mount 934 935 5000
FluentProvider mount 1569 1563 5000
FluentProviderWithTheme mount 630 641 10
FluentProviderWithTheme virtual-rerender 590 594 10
FluentProviderWithTheme virtual-rerender-with-unmount 622 622 10
MakeStyles mount 1907 1930 50000
SpinButton mount 2551 2529 5000

@size-auditor
Copy link

size-auditor bot commented Oct 24, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ab9bf285848173c8a3f2113b9dac63dbbebf7407 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5c6fb42:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@TristanWatanabe TristanWatanabe merged commit 2f9363c into microsoft:master Oct 26, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-select branch October 26, 2022 21:28
sunilsurana added a commit to sunilsurana/fluentuifork1 that referenced this pull request Oct 27, 2022
* Update Link.stories.tsx

* Update Link.stories.tsx

* update

* chore(babel-preset-global-context): migrate to new package structure (microsoft#25340)

* chore(react-aria): migrate to new package structure (microsoft#25199)

* feat: re-export react-table logic hooks (microsoft#25386)

* applying package updates

* Website: fix focus border on UHF footer links (microsoft#25389)

* use not uhf link to increase specificity instead of body tag

* improve comment

* fix(docsite): codesandbox exports now working properly for newly migrated v9 packages (microsoft#25388)

* chore(react-divider): migrate to new package structure (microsoft#25360)

* chore(react-select): migrate to new package structure (microsoft#25359)

* feat: Add support for the wbtx whiteboard file extension (microsoft#25346)

* revert some changes

* update storywright version

* rename

* rename

* updatE

* update

* update

* update

* update

* not needed

* update

* update

Co-authored-by: Tristan Watanabe <tristan.watanabe@gmail.com>
Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
Co-authored-by: Fluent UI Build <fluentui-internal@service.microsoft.com>
Co-authored-by: Micah Godbolt <mgodbolt@microsoft.com>
Co-authored-by: jieleiwang <51342814+jieleiwang@users.noreply.github.com>
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 27, 2022
* master: (21 commits)
  fix(react-tabster): make acceptCondition optional as Tabster dont require it (microsoft#25416)
  chore: adds disableButtonEnhancement on triggers (microsoft#25211)
  applying package updates
  feat: Add support for the wbtx whiteboard file extension (microsoft#25346)
  chore(react-select): migrate to new package structure (microsoft#25359)
  chore(react-divider): migrate to new package structure (microsoft#25360)
  fix(docsite): codesandbox exports now working properly for newly migrated v9 packages (microsoft#25388)
  Website: fix focus border on UHF footer links (microsoft#25389)
  applying package updates
  feat: re-export react-table logic hooks (microsoft#25386)
  chore(react-aria): migrate to new package structure (microsoft#25199)
  chore(babel-preset-global-context): migrate to new package structure (microsoft#25340)
  applying package updates
  fix: Improve Stack's style recalculation performance by selectively applying children selectors (microsoft#25381)
  applying package updates
  fix(projects-test): explicitly install next version 12 to fix CI (microsoft#25374)
  allow details element to be toggled inside selection and focus zones (microsoft#25324)
  fix(react-persona): Changing persona's versions to pinned versions (microsoft#25367)
  update fast element and foundation package versions stable (microsoft#25364)
  chore(keyboard-keys, priority-overflow, react-context-selector, react-conformance-griffel): migrate to new package structure (microsoft#25362)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants