Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-export react-table logic hooks #25386

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

bsunderhus
Copy link
Contributor

New Behavior

Exports @fluentui/react-table logic hooks on @fluentui/react-components/unstable

@bsunderhus bsunderhus marked this pull request as ready for review October 26, 2022 17:01
@bsunderhus bsunderhus requested a review from a team as a code owner October 26, 2022 17:01
@bsunderhus bsunderhus enabled auto-merge (squash) October 26, 2022 17:07
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 760ad64:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 26, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f6f3e4b27f850577890dce15000bf8d4dedc4381 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.94 kB
17.663 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.603 kB
52.909 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against f6f3e4b27f850577890dce15000bf8d4dedc4381

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1331 1347 5000
Button mount 992 991 5000
FluentProvider mount 1638 1653 5000
FluentProviderWithTheme mount 646 647 10
FluentProviderWithTheme virtual-rerender 602 610 10
FluentProviderWithTheme virtual-rerender-with-unmount 632 660 10
MakeStyles mount 1940 2000 50000
SpinButton mount 2702 2593 5000

@bsunderhus bsunderhus merged commit 32865fd into microsoft:master Oct 26, 2022
@bsunderhus bsunderhus deleted the react-table/re-export-hooks branch October 26, 2022 17:28
sunilsurana added a commit to sunilsurana/fluentuifork1 that referenced this pull request Oct 27, 2022
* Update Link.stories.tsx

* Update Link.stories.tsx

* update

* chore(babel-preset-global-context): migrate to new package structure (microsoft#25340)

* chore(react-aria): migrate to new package structure (microsoft#25199)

* feat: re-export react-table logic hooks (microsoft#25386)

* applying package updates

* Website: fix focus border on UHF footer links (microsoft#25389)

* use not uhf link to increase specificity instead of body tag

* improve comment

* fix(docsite): codesandbox exports now working properly for newly migrated v9 packages (microsoft#25388)

* chore(react-divider): migrate to new package structure (microsoft#25360)

* chore(react-select): migrate to new package structure (microsoft#25359)

* feat: Add support for the wbtx whiteboard file extension (microsoft#25346)

* revert some changes

* update storywright version

* rename

* rename

* updatE

* update

* update

* update

* update

* not needed

* update

* update

Co-authored-by: Tristan Watanabe <tristan.watanabe@gmail.com>
Co-authored-by: Bernardo Sunderhus <bernardo.sunderhus@gmail.com>
Co-authored-by: Fluent UI Build <fluentui-internal@service.microsoft.com>
Co-authored-by: Micah Godbolt <mgodbolt@microsoft.com>
Co-authored-by: jieleiwang <51342814+jieleiwang@users.noreply.github.com>
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Oct 27, 2022
* master: (21 commits)
  fix(react-tabster): make acceptCondition optional as Tabster dont require it (microsoft#25416)
  chore: adds disableButtonEnhancement on triggers (microsoft#25211)
  applying package updates
  feat: Add support for the wbtx whiteboard file extension (microsoft#25346)
  chore(react-select): migrate to new package structure (microsoft#25359)
  chore(react-divider): migrate to new package structure (microsoft#25360)
  fix(docsite): codesandbox exports now working properly for newly migrated v9 packages (microsoft#25388)
  Website: fix focus border on UHF footer links (microsoft#25389)
  applying package updates
  feat: re-export react-table logic hooks (microsoft#25386)
  chore(react-aria): migrate to new package structure (microsoft#25199)
  chore(babel-preset-global-context): migrate to new package structure (microsoft#25340)
  applying package updates
  fix: Improve Stack's style recalculation performance by selectively applying children selectors (microsoft#25381)
  applying package updates
  fix(projects-test): explicitly install next version 12 to fix CI (microsoft#25374)
  allow details element to be toggled inside selection and focus zones (microsoft#25324)
  fix(react-persona): Changing persona's versions to pinned versions (microsoft#25367)
  update fast element and foundation package versions stable (microsoft#25364)
  chore(keyboard-keys, priority-overflow, react-context-selector, react-conformance-griffel): migrate to new package structure (microsoft#25362)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants