Terminal must not depend on `IInlineChatSessionProvider` et al #213159

jrieken · 2024-05-21T14:42:23Z

The IInlineChatSessionProvider interface and service is for editor inline chat and are unrelated to terminal inline chat. Using the inline chat API to check if there is a terminal land is wrong, e.g here and should be clean-up quickly because all these things will go away

The text was updated successfully, but these errors were encountered:

jrieken · 2024-05-21T15:56:44Z

also here

vscode/src/vs/workbench/contrib/terminalContrib/chat/browser/terminal.initialHint.contribution.ts

Line 98 in 51bee12

    
           this._addon = this._register(this._instantiationService.createInstance(InitialHintAddon, this._instance.capabilities, this._inlineChatService.onDidChangeProviders));

…at hint (#213183) fix #213159

…at hint (microsoft#213183) fix microsoft#213159

@workspace

* Limit image width in chat (microsoft#213021) * Make sure child instantiation service instances are disposed/tracked for disposal (microsoft#212879) (microsoft#213002) * voice - limit `Escape` key to context key scopes (might help for microsoft#213017) (microsoft#213049) * Cleanup editor group context keys (microsoft#212955) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * chore: bump electron@29.4.0 (microsoft#213050) * chore: bump electron@29.4.0 * chore: remove io_uring workaround * chore: bump distro * chore: update dialog result for canceled save dialogs Refs electron/electron@fe01ed7 * chore: add back io_uring workaround for remote oss tests * chore: update nodejs v20.9.0 build * chore: add back io_uring workaround for remote tests * chore: update CLI dependences, add env var options for login * if no selected items, return to accessibility help dialog (microsoft#213075) * provider keyboard users with hover actions (microsoft#213077) * feat: allow ➡️ to add chat context in background (microsoft#213078) * eng: fix prelaunch task on recent node versions Closes microsoft#212888 * fix: limit width of chat attachment widgets * eng: fix off-by-1 error in selfhost test error messages (microsoft#213081) Fixes microsoft#212808 * Fix chat welcome message tooltip (microsoft#213084) * fix a few accessible view bugs (microsoft#213097) * Respect isSlow for chat attachments (microsoft#213105) * strip markdown from chat accessible view, maintain code block nav functionality (microsoft#213096) * resolve accessibility help dialog kbs in `accessibleViewService` (microsoft#213107) * feat: support dynamic variables in chat context picker * Fix misaligned jsdoc * Fix shared input history between chat locations (microsoft#213111) Fix microsoft/vscode-copilot-release#1228 * Fix merging chat anchors in markdown content (microsoft#213114) * Fix merging multiple chat anchors inside markdown content * Simplify types * Fix tests * make sure to push an undo stop after each request (microsoft#213137) fixes https://github.com/microsoft/vscode-copilot/issues/5736 * adjust max input part height for compact chat widget, keep input height separate when compute minHeight (microsoft#213139) fixes https://github.com/microsoft/vscode-copilot/issues/5707 * chore - inline chat controller tests works without agents only (no more glue provider-agent) (microsoft#213151) * Tabs Multi Select Polish (microsoft#212930) * Tabs Multi Select Polish * 💄 * add todo * add todo * update * 💄 * 💄 * 💄 * more review * 💄 * 💄 * fix bad function call * remove todo * jsdoc * 💄 * fix typo * 💄 * 💄 * 💄 multiEditorTabs * model accepts multiple editors * Use setSelection() * fix tests * 💄 * 💄 * discussion * discussion * fix selection * typo --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * remove bridge agents and agent providers because inline chat is all participants now * remove much of IInlineChatSessionProvider * deprecate IInlineChatService and move most consumers off * undo cell diag changes * fix: tsserver no longer crashes when log path includes spaces (microsoft#212752) * Treat normal markdown links as a single token for progressive chat rendering (microsoft#213091) Fixes our progressive chat renderer breaking up any markdown links that contain `-` or a space character. Doesn't support all the fancy markdown link syntaxes, just basic links for now * Pick up latest ts for building VS Code (microsoft#213170) * feat: allow extensions to attach chat context (microsoft#213172) * feat: allow extensions to attach chat context * fix: allow attaching different ranges from same file * fix: restore accepting files from picker * Use `resolveContentAndKeybindingItems` for diff editor, accessible view, and terminal (microsoft#213179) * Use `ChatAgentService` instead of `InlineChatService` for terminal chat hint (microsoft#213183) fix microsoft#213159 * Tweak confirmations pading * Properly handle errors thrown from renderer while invoking the chat agent (microsoft#213080) * Properly handle errors thrown from renderer while invoking the chat agent If we throw out of ChatService, then the request can't be canceled and stays "generating" forever * Update snapshot * Save on EH diagnostics (microsoft#213171) * added trace logs * another trace message * fix test ctors * remove test logs (microsoft#213188) * testing: exploratory UI for followup actions This adds an API that extensions can use to contribute 'followup' actions around test messages. Here just a dummy hello world using copilot, but extensions could have any action here, such as actions to update snapshots if a test failed: ![](https://memes.peet.io/img/24-05-c1f3e073-a2da-4f16-a033-c8f7e5cd4864.png) Implemented using a simple provider API. * Notebook Chat Controller does not need use agent directly * Hack to get it working * feat: persist chat attachments in history * Fix "open chat in editor" (microsoft#213198) Fix microsoft/vscode-copilot-release#1233 * chore - remove dead/stale commands (microsoft#213207) * chore - write error message so that it doesn't get confused as file path (microsoft#213210) * Perf: visualise memory efficiency (microsoft#211837) (microsoft#213208) * Perf: visualise memory efficiency (microsoft#211837) * feat: add telemetry logging for startup heap statistics * fix compile * feat: add used heap size to startup performance telemetry * refactor: remove allocated heap size from startup performance telemetry * comments * debt - some multi-tabs select cleanup (microsoft#213161) * chore: update deps for linux x64 client (microsoft#213221) chore: update linux client dependencies * editors - fix context on `EDITOR_CLOSE` (microsoft#213223) * SCM - add command to focus input (microsoft#213225) * allow customizing accessibility signal delays (microsoft#212834) * fix: set `id` and `name` for files in chat context * Disable VS Code file watching for yarn pnp (microsoft#213238) Disable VS Code file watching on yarn pnp * Enable roaming of inflight chat requests (microsoft#213239) This enables to remove the special handling for `/explain` - fixes https://github.com/microsoft/vscode-copilot/issues/2192 - fixes microsoft#208706 because inline chat now closes on "view in chat" - fixes https://github.com/microsoft/vscode-copilot/issues/5288 * Add VS device id (microsoft#213231) * NotebookChatController still manages ChatModel * Don't register chat participants in stable (microsoft#213244) * Don't register chat participants in stable And fork some Additions APIs into chatParticipantPrivate * Remove stale proposals * Move more API out of Additions * Start session when notebook chat widget is created * Implement Profiles Editor (microsoft#213246) * first cut * second cut * fix * add more features * support skipping copying resources while creating * enable behind internal setting * testing: polish followups a little, selfhost with copilot * Update for latest code mapper proposal (microsoft#213256) * Remove notebook chat menu * Rename vsDeviceId (microsoft#213261) * polish profiles editor (microsoft#213262) * refactor: clean up chat context types (microsoft#213264) * fix: prevent attaching the same chat context twice (microsoft#213266) * Bump distro (microsoft#213268) * more polish (microsoft#213267) * more polish * refactor actions * fix hover * Prevent using disposed of timers (microsoft#213271) * Prevent using disposed of timers If a timer has been disposed of, warn and don't schedule the callback. This is needed as otherwise the timer very likely ends up being leaked * Throw errors instead * Fix microsoft#213206. Migrate off IInlineChatService (microsoft#213263) * Fix microsoft#213206. Migrate off IInlineChatService * fix tests * Fix leaking uponSanitizeElement hook (microsoft#213277) * Tweak agent hover (microsoft#213278) "View in Marketplace" seems to be confusing people * Fix fillInIncompleteTokens for ordered lists (microsoft#213280) * fix: apply query filter to `additionPicks` (microsoft#213281) * Fix StableEditorBottomScrollState (microsoft#212970) * False positive "saving too long" dialog hindering saving a file (fix microsoft/vscode-internalbacklog#4943) (microsoft#213290) * Remove tree view show hover (microsoft#213212) * remove `IInlineChatService` and types around it (microsoft#213298) * increase listener refusal threshold significantly (microsoft#213292) * increase listener refusal threshold significantly * fix tests * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts (microsoft#213301) * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts * fix compiler * Polish the code that sets env in packageJSONContribution.ts (microsoft#213306) * fix this reference in instantiation service (microsoft#213311) * Fix unsafe type assertions on object literals (microsoft#213318) * Benibenj/registerContextKeyHandler (microsoft#213135) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup * first draft contexkt key registration * Make it a provider * Use group instead of active editor * getGroupContextKeyValue * doc * Fix merge error * 💄 --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * allow returning undefined if file was not saved (microsoft#213123) * allow returning undefined if file was not saved * bring back cancellation check * helper utility to convey optional result if cancelled * edit * inline function * test cancelled custom save * inline more --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Fix codicons padding in chat attachments * git: allow querying whether files are gitignore (microsoft#212982) * git: allow querying whether files are gitignore This exposes `checkIgnore`, which I want to use in copilot to determine which files I should go into when checking references. * rename method * Making API `editorHoverVerbosityLevel` use `verbosityLevel` instead of `action` (microsoft#213317) * allowing to cancel a previous request and jump directly to a request for a delta at a higher level * adding code in order to dispose the token sources when the full object is disposed * Fix issue with Cmd+W closing the window with opened tabs (microsoft#213335) fixes microsoft#213324 * Render html as plaintext when html not supported (microsoft#213265) * Support rendering unsupported html tags as plaintext for chat * Render html as plaintext when html not supported * Add comment and test for trusted domains * code action and lightbulb telemetry updates (microsoft#212929) * added additional telemetry and remove unused telemetry event * removed unused imports * Bump distro (microsoft#213340) * Part of microsoft#211878 (microsoft#212902) * SCM - add commands to focus next/previous input (microsoft#213337) * SCM - refactor commands to focus input * Ensure that the input node is expanded in the tree * getParent() should handle expanding the repository node * Use ArrayNavigator instead * Add support for looping in the array navigator * 💄 * use rot instead of array navigator * 💄 * more 💄 --------- Co-authored-by: João Moreno <joao.moreno@microsoft.com> * SCM - getParent() should handle resource groups (microsoft#213350) * refactor: replace direct process.pid usage with getProcessId method (microsoft#213352) * refactor: replace direct process.pid usage with getProcessId method * remove console.log * feat: enable attaching symbols to chat via `@` (microsoft#213347) * feat: enable attaching symbols to chat via `@` * Oop * SCM - add commands to focus previous/next resource group (microsoft#213377) * Initial implementation * 💄 * Fixed issue with focusing outside the tree * Joh/homely-damselfly (microsoft#213376) * chore - `ReplyResponse` cleanup * associate hunk data with response id * Associate hunk data with response state so that accepting hunks updates the text edit group * first cut of moving N-edits conversion from inline chat to panel * don't always consume mouse wheel (microsoft#213383) for chat widget (list) and for chat input editor (actually all simple editor cases) * clean up dead context keys and other dead code (microsoft#213387) * inline chat for notebook cell uses the `Notebook` chat location (microsoft#213385) * inline chat for notebook cell uses the `Notebook` chat location * fix tests * show filename for compare code blocks (microsoft#213389) * check uri when combining edits from different groups (microsoft#213390) * Fix issue microsoft#212877: Use Action context for Multi Diff Editor Actions (microsoft#213293) fix microsoft#212877 * Remove configure inline chat command from menu because it isn't popular at all and takes space (microsoft#213396) also fixes https://github.com/microsoft/vscode-copilot/issues/5662 * Scope custom editor and webview context keys to editor groups and global context (microsoft#213398) Properly scope custom editor and webview context keys * Fix broken codeblocks (microsoft#213399) * Fix broken codeblocks Fix microsoft#213382 * Fix tests * fix microsoft#194105 (microsoft#213403) * Add tests for editor group model (microsoft#213405) * Add test for editor group model * user helper function * web reporter refactor and issueFormService (microsoft#212951) * web version working * change to mainWindow * PROPER MOVEMENT * working for web as well * move issueFormService to workbench/contrib/issue * cleaning up{ * more cleanup, added setting * styling * use mainwindow to open and closee * css fixes * fix css again * fix CSS and wonky applyCSS rules * change gulpfile * add and update system info * address some of the comments * move files! small changes * move JS and non window specific back to electron sandbox * fix on issueReporter.js * fix build file * fix gulp file too.... * move everything into contrib * fix workbench import * move everything else into contrib, fix import * change name to web * applying more feedback fixes :D * fix command and remove unused import: * add back issueTroubleshoot * fix gulpile outputs * fix out exclusion: * Disable web TS type acquisition (microsoft#213412) We're waiting on some perf improvement for upstream types installer before turning this on everywhere * Hook up prototype paste with imports for JS/TS (microsoft#204665) * Hook up prototype paste with imports for JS/TS For microsoft/TypeScript#57262 but with proposed changes to ts protocol * Support new api * Update * issue reporter re-open save state (microsoft#213418) if anything is typed and we call open reporter again, saves issue title and data * provide default settings (microsoft#213419) fix microsoft#213411 * add item label (microsoft#213422) * add item label * update active window label * Add "when" clause to chat participants (microsoft#213425) * Add "when" clause to chat participants Fix microsoft#212447 * Change _agents to a Map and write some tests * Fix import * Change proposal for chat participant "when" clause (microsoft#213427) * Change proposal for chat participant "when" clause * This * feat: add top level `Symbol...` to Attach Context picker (microsoft#213435) * feat: enable attaching symbols to chat via `#` * feat: add `Symbol...` to Attach Context picker * feat: easier keyboard flow for removing chat attachments (microsoft#213436) * ts - enable use code watcher by default (microsoft#213450) * Fix menu computation when compact on right side (microsoft#213459) fix menu computation when compact on right side * Add focus indication for compact menu (microsoft#213463) indicate when compact menu is focused * Debt - dispose child instantiation service (microsoft#213471) * Fix "new chat" before focusing chat panel (microsoft#213478) Fix microsoft#213353 * Sort @workspace /explain above @Terminal /explain (microsoft#213482) Fix microsoft/vscode-copilot-release#1245 This is a bit of a hack but has some advantanges over adding an 'order' field to the chat participant or something like that. We can keep the order the same in other cases except for when the user is typing to filter the / list, then @Terminal slash commands will be pushed down. * Don't show chat agent hover on empty space in header (microsoft#213486) Fix microsoft/vscode-copilot#5271 * chore: update remote node.js (microsoft#213439) * chore: update remote node.js to v20.11.1 * chore: remove io_uring workaround * chore: update checksums * temp: update distro * ci: rebuild cache * chore: bump distro * Working sets - add preserveFocus (microsoft#213397) * Working sets - preserve focus when applying the working set was initiated by an action that was taken in the panel part (ex: switching branches from the terminal) * Pull request feedback * renames and cleanup * renames and cleanup * renames and cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Add "Open in Editor" button for chat history (microsoft#213518) Fix microsoft#213517 * fix microsoft#213526 (microsoft#213527) * fix microsoft#181407 (microsoft#213530) * Remove brackets from comments, strings and regexes before evaluating the indentation (microsoft#210641) * wip * polishing the code * adding code * adding the language * reshuffling the code to avoid cyclic dependency * polihsing code * uncommenting tests * also adopting the indentation rules within the reindentation operation * using instead the sliced line tokens instead of the scoped line tokens * polishing the code * using start indices instead * using value everywhere * using the token data to type the tokens * setting to number instead of standard token type * using token data from autoindenttest.ts * using same code in both test files * placing instantiation service into the registerLanguage method * copying object into the node js autoindent.ts * report new windo profile setting (microsoft#213531) * Add license for deviceid (microsoft#213536) * watcher - add the utility process worker to disposables (microsoft#213538) * Color theme preview not working with "window.systemColorTheme": "auto" (microsoft#213539) * watcher - more `dispose` and remove E15 workaround (microsoft#213540) * Fix comments memory leak (microsoft#213542) Fixes microsoft#213535 * Fix copyright statement (microsoft#213543) * Don't show the gutter menu in the chat diff editor. (microsoft#213546) * Fixes diff editor height issue. (microsoft#213547) Before: Always 100% of parent container. After: Uses passed in dimensions. * Fixes microsoft#209627 (microsoft#213554) * SCM - reveal resource in the source control tree (microsoft#213556) * Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#213557) Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#200091) * Fixes microsoft#209417 (microsoft#213549) * use refs/tags/release for 1espt (microsoft#213558) * debt - fix a few leaking listeners (microsoft#213560) * Ignore indentation rules when interacting with a string (microsoft#210761) * ignore indenation when interacting with a string * changes from discussion * remove the export keyword * adding changes to the PR * removing the console log * adding one more comment * extracting the method which forces the tokenization * Add license URIs for toml_edit and toml_datetime (microsoft#213562) Add licene uri fr toml_edit and toml_datetime * fix microsoft#213563 (microsoft#213564) * report new window profile switch (microsoft#213566) * Fixes microsoft#213573 (microsoft#213574) * fix microsoft#213576 (microsoft#213577) * Add editor.findMatchForeground (microsoft#213497) * feature: make find decoration foreground color configurable * Update license and third party notices (microsoft#213580) * editors - add test for transient group model changes (microsoft#213581) * Fixes microsoft#212771 (microsoft#213584) * Fix an issue where defaultLinesDiffComputer does not pass in the timeout variable (microsoft#213035) Update defaultLinesDiffComputer.ts * fix microsoft#212674 (microsoft#213583) * Fixes diff editor height in monaco editor playground example. (microsoft#213585) * Feat: Bolder Typeface + Configurable Letter Spacing for Minimap's Section Header Labels ✨ (microsoft#209990) * Rendering Section Header Labels with space in between the characters for better readability. * Making Section Headers Bold * Added settings for the Section Header Letter Spacing of the Minimap * a more performant and non-breaking way to render characters * fixed the git problems * add test default value * Allow fine-tuning the letter spacing, minor tweaks --------- Co-authored-by: Alexandru Dima <alexdima@microsoft.com> * Support diff merge editor for Notebooks (microsoft#213602) * Add Search in Cell Selection to Notebook Find Widget (microsoft#213409) * all search scope functionality except cell decorations * fix filter icon showing fake useage * decorations + css tweaking + PR feedback * Adding accessibility help for verbose hover (microsoft#212783) * adding code in order to provide accessibility help for the hover * adding the description of the possible commands that can be used * reusing the method * joining the content and changing the text in the help view * polishing the code * removing the question mark * changing the import * removing the setting ID from imports * adding code in order to update when the hover updates * adding methods to service * adding code in order to dispose the accessible hover view * fixing bug * polishing the code * checking that action not supported for the early return * using disposable store instead * using the appropriate string * polishing the code * using instead the type help and the resolved keybindings * hiding also on the `onDidBlurEditorWidget` firing * Revert "using instead the type help and the resolved keybindings" This reverts commit 1f450dd. * use hover accessible view, provide custom help * Revert "Revert "using instead the type help and the resolved keybindings"" This reverts commit 12f0cf6. * add HoverAccessibilityHelp, BaseHoverAccessibleViewProvider * polishing the code * polishing the code * provide content at a specific index from the hover accessibility help provider * introducing method _initializeOptions * using readonly where possible * using public everywhere * using a getter for the actions --------- Co-authored-by: meganrogge <megan.rogge@microsoft.com> * Add more info to comment range error (microsoft#213578) Part of microsoft#213243 * Bump postcss from 7.0.39 to 8.4.38 (microsoft#209857) Bumps [postcss](https://github.com/postcss/postcss) from 7.0.39 to 8.4.38. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.39...8.4.38) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: dispose template data disposables in source column renderer (microsoft#202618) * fixes regression: adding a `isCheapToTokenize` check before tokenizing the line (microsoft#213674) adding a check on how it is cheap to tokenize the lines * fix windows terminal hint not showing up (microsoft#213695) fix microsoft#213693 * Missing server node module (microsoft#213712) * Fix hover padding regression (microsoft#213700) * Fix textPreformatForeground for HC themes (microsoft#213698) * Fix js/ts cross code block intellisense (microsoft#213726) We need to register support for the backing copilot scheme too, not just the panel scheme in core * Fix vscode-api-tests in stable (microsoft#213733) * debug: bump js-debug for 1.90 (microsoft#213735) * fix: render ranges for attached selections in chat (microsoft#213741) * fix accessible view kb quickpick not showing (microsoft#213745) * fix: set aria label for chat context attachments (microsoft#213747) * web issue reporter styles (microsoft#213751) remove mac from tag * defaults web issue report false and disable in Firefox (microsoft#213752) * turn off in release and in ff * update * remove global enablement message (microsoft#213128) * editors - clarify `window.restoreWindows` setting further (microsoft#213771) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) (microsoft#213776) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) * simplify * aux window - support Firefox (microsoft#213769) * aux window - support Firefox * add more * only use workaround for FF * enable issue repoter again * . * fix microsoft#212208 (microsoft#213779) * Make rest of terminal initial hint italic Part of microsoft#213647 * Align colors of terminal hint with editor * Use pointer cursor for whole terminal initial hint Fixes microsoft/vscode-copilot#5963 * unwrap `LanguageModelError` when invoking chat participant (microsoft#213784) re microsoft#213710 * fix https://github.com/microsoft/vscode-copilot/issues/5814 (microsoft#213787) * fixes https://github.com/microsoft/vscode-copilot/issues/5908 (microsoft#213788) * fixes microsoft#213644 (microsoft#213789) * fix microsoft#213614 (microsoft#213791) * SCM - all calls from extHostSCM to mainThreadSCM should use a sequencer to ensure that the source control object is created (microsoft#213792) * Fix multi selected tab close behavior (microsoft#213794) fix microsoft#213620 * fix microsoft#196351 (microsoft#213796) * Cannot read properties of undefined (reading 'layout') (microsoft#213797) Fixes microsoft#212235 * fix microsoft#211965 (microsoft#213801) * fix: remove temp dir if extension is installed by another source (microsoft#213379) * closing out inline chat while speech is going does not stop audio (fix microsoft#213709) (microsoft#213802) * No text to speech when a change is applied (fix microsoft#213667) (microsoft#213804) * Regression: Unsaved comment reply lost when changing editors (microsoft#213805) Fixes microsoft#213144 * Voice dictation shortcut (fix microsoft#206800) (microsoft#213806) * Enable initialHint when not stable for now Part of microsoft#213647 * fix leaking listener (microsoft#213816) re microsoft#213141 * fix: setting labels appearing in widgets (microsoft#213826) * Connor4312/issue211378 (microsoft#213829) cli: fix inverted condition not showing warning correctly Fixes microsoft#211378 * doc updates & fixes for chat/lm API (microsoft#213777) * workaround @link not working * fixes microsoft#213630 * Retain previous quick pick navigation behavior with Home and End (microsoft#213832) Fixes microsoft#213739 * Fix microsoft#213525. Move nb chat variable to service (microsoft#213835) * Added redirect * Deleted build * Added submodule * Added symlinking * Added progress * Added script progress * Added attempt to fixx packaging * Added fresh install * Changed back to code.sh * Changed name * fix: hide Attach Context for quick chat (microsoft#213841) * Hook up notebook format code action to format notebook command (microsoft#213847) hook format codeaction to format notebook command * Added extHostChatAgents2.ts * Added contributing * Add setup scripts for different environments (#87) * Add setup scripts for for cross enviroments * add calls to vscode build scripts * update function naming * reduce DRY code in setup scripts * remove old link & update gitignore --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> Co-authored-by: Benjamin Christopher Simmonds <44439583+benibenj@users.noreply.github.com> Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Connor Peet <connor@peet.io> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: Joyce Er <joyce.er@microsoft.com> Co-authored-by: Joyce Er <joyceerhl@gmail.com> Co-authored-by: Isidor Nikolic <inikolic@microsoft.com> Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com> Co-authored-by: Walker Boyle <wboyle13@gmail.com> Co-authored-by: Matt Bierner <matb@microsoft.com> Co-authored-by: David Dossett <ddossett@microsoft.com> Co-authored-by: Aaron Munger <aamunger@microsoft.com> Co-authored-by: Peng Lyu <penn.lv@gmail.com> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: Alexandru Dima <alexdima@microsoft.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: João Moreno <joao.moreno@microsoft.com> Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com> Co-authored-by: Alex Ross <alros@microsoft.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Simon Siefke <simon.siefke@gmail.com> Co-authored-by: Hanning Gong (Charles) <charles.gong@databricks.com> Co-authored-by: Pouya Kary ✨ <kary@gnu.org> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Michael Lively <milively@microsoft.com> Co-authored-by: meganrogge <megan.rogge@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shoham Ben Shitrit <91195275+bsShoham@users.noreply.github.com> Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Co-authored-by: Yesterday17 <mmf@mmf.moe> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> Co-authored-by: Nathan A <nang@Nathans-MacBook-Pro-8.local> Co-authored-by: Ender <endergamingfilms@gmail.com>

@workspace

* Limit image width in chat (microsoft#213021) * Make sure child instantiation service instances are disposed/tracked for disposal (microsoft#212879) (microsoft#213002) * voice - limit `Escape` key to context key scopes (might help for microsoft#213017) (microsoft#213049) * Cleanup editor group context keys (microsoft#212955) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * chore: bump electron@29.4.0 (microsoft#213050) * chore: bump electron@29.4.0 * chore: remove io_uring workaround * chore: bump distro * chore: update dialog result for canceled save dialogs Refs electron/electron@fe01ed7 * chore: add back io_uring workaround for remote oss tests * chore: update nodejs v20.9.0 build * chore: add back io_uring workaround for remote tests * chore: update CLI dependences, add env var options for login * if no selected items, return to accessibility help dialog (microsoft#213075) * provider keyboard users with hover actions (microsoft#213077) * feat: allow ➡️ to add chat context in background (microsoft#213078) * eng: fix prelaunch task on recent node versions Closes microsoft#212888 * fix: limit width of chat attachment widgets * eng: fix off-by-1 error in selfhost test error messages (microsoft#213081) Fixes microsoft#212808 * Fix chat welcome message tooltip (microsoft#213084) * fix a few accessible view bugs (microsoft#213097) * Respect isSlow for chat attachments (microsoft#213105) * strip markdown from chat accessible view, maintain code block nav functionality (microsoft#213096) * resolve accessibility help dialog kbs in `accessibleViewService` (microsoft#213107) * feat: support dynamic variables in chat context picker * Fix misaligned jsdoc * Fix shared input history between chat locations (microsoft#213111) Fix microsoft/vscode-copilot-release#1228 * Fix merging chat anchors in markdown content (microsoft#213114) * Fix merging multiple chat anchors inside markdown content * Simplify types * Fix tests * make sure to push an undo stop after each request (microsoft#213137) fixes https://github.com/microsoft/vscode-copilot/issues/5736 * adjust max input part height for compact chat widget, keep input height separate when compute minHeight (microsoft#213139) fixes https://github.com/microsoft/vscode-copilot/issues/5707 * chore - inline chat controller tests works without agents only (no more glue provider-agent) (microsoft#213151) * Tabs Multi Select Polish (microsoft#212930) * Tabs Multi Select Polish * 💄 * add todo * add todo * update * 💄 * 💄 * 💄 * more review * 💄 * 💄 * fix bad function call * remove todo * jsdoc * 💄 * fix typo * 💄 * 💄 * 💄 multiEditorTabs * model accepts multiple editors * Use setSelection() * fix tests * 💄 * 💄 * discussion * discussion * fix selection * typo --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * remove bridge agents and agent providers because inline chat is all participants now * remove much of IInlineChatSessionProvider * deprecate IInlineChatService and move most consumers off * undo cell diag changes * fix: tsserver no longer crashes when log path includes spaces (microsoft#212752) * Treat normal markdown links as a single token for progressive chat rendering (microsoft#213091) Fixes our progressive chat renderer breaking up any markdown links that contain `-` or a space character. Doesn't support all the fancy markdown link syntaxes, just basic links for now * Pick up latest ts for building VS Code (microsoft#213170) * feat: allow extensions to attach chat context (microsoft#213172) * feat: allow extensions to attach chat context * fix: allow attaching different ranges from same file * fix: restore accepting files from picker * Use `resolveContentAndKeybindingItems` for diff editor, accessible view, and terminal (microsoft#213179) * Use `ChatAgentService` instead of `InlineChatService` for terminal chat hint (microsoft#213183) fix microsoft#213159 * Tweak confirmations pading * Properly handle errors thrown from renderer while invoking the chat agent (microsoft#213080) * Properly handle errors thrown from renderer while invoking the chat agent If we throw out of ChatService, then the request can't be canceled and stays "generating" forever * Update snapshot * Save on EH diagnostics (microsoft#213171) * added trace logs * another trace message * fix test ctors * remove test logs (microsoft#213188) * testing: exploratory UI for followup actions This adds an API that extensions can use to contribute 'followup' actions around test messages. Here just a dummy hello world using copilot, but extensions could have any action here, such as actions to update snapshots if a test failed: ![](https://memes.peet.io/img/24-05-c1f3e073-a2da-4f16-a033-c8f7e5cd4864.png) Implemented using a simple provider API. * Notebook Chat Controller does not need use agent directly * Hack to get it working * feat: persist chat attachments in history * Fix "open chat in editor" (microsoft#213198) Fix microsoft/vscode-copilot-release#1233 * chore - remove dead/stale commands (microsoft#213207) * chore - write error message so that it doesn't get confused as file path (microsoft#213210) * Perf: visualise memory efficiency (microsoft#211837) (microsoft#213208) * Perf: visualise memory efficiency (microsoft#211837) * feat: add telemetry logging for startup heap statistics * fix compile * feat: add used heap size to startup performance telemetry * refactor: remove allocated heap size from startup performance telemetry * comments * debt - some multi-tabs select cleanup (microsoft#213161) * chore: update deps for linux x64 client (microsoft#213221) chore: update linux client dependencies * editors - fix context on `EDITOR_CLOSE` (microsoft#213223) * SCM - add command to focus input (microsoft#213225) * allow customizing accessibility signal delays (microsoft#212834) * fix: set `id` and `name` for files in chat context * Disable VS Code file watching for yarn pnp (microsoft#213238) Disable VS Code file watching on yarn pnp * Enable roaming of inflight chat requests (microsoft#213239) This enables to remove the special handling for `/explain` - fixes https://github.com/microsoft/vscode-copilot/issues/2192 - fixes microsoft#208706 because inline chat now closes on "view in chat" - fixes https://github.com/microsoft/vscode-copilot/issues/5288 * Add VS device id (microsoft#213231) * NotebookChatController still manages ChatModel * Don't register chat participants in stable (microsoft#213244) * Don't register chat participants in stable And fork some Additions APIs into chatParticipantPrivate * Remove stale proposals * Move more API out of Additions * Start session when notebook chat widget is created * Implement Profiles Editor (microsoft#213246) * first cut * second cut * fix * add more features * support skipping copying resources while creating * enable behind internal setting * testing: polish followups a little, selfhost with copilot * Update for latest code mapper proposal (microsoft#213256) * Remove notebook chat menu * Rename vsDeviceId (microsoft#213261) * polish profiles editor (microsoft#213262) * refactor: clean up chat context types (microsoft#213264) * fix: prevent attaching the same chat context twice (microsoft#213266) * Bump distro (microsoft#213268) * more polish (microsoft#213267) * more polish * refactor actions * fix hover * Prevent using disposed of timers (microsoft#213271) * Prevent using disposed of timers If a timer has been disposed of, warn and don't schedule the callback. This is needed as otherwise the timer very likely ends up being leaked * Throw errors instead * Fix microsoft#213206. Migrate off IInlineChatService (microsoft#213263) * Fix microsoft#213206. Migrate off IInlineChatService * fix tests * Fix leaking uponSanitizeElement hook (microsoft#213277) * Tweak agent hover (microsoft#213278) "View in Marketplace" seems to be confusing people * Fix fillInIncompleteTokens for ordered lists (microsoft#213280) * fix: apply query filter to `additionPicks` (microsoft#213281) * Fix StableEditorBottomScrollState (microsoft#212970) * False positive "saving too long" dialog hindering saving a file (fix microsoft/vscode-internalbacklog#4943) (microsoft#213290) * Remove tree view show hover (microsoft#213212) * remove `IInlineChatService` and types around it (microsoft#213298) * increase listener refusal threshold significantly (microsoft#213292) * increase listener refusal threshold significantly * fix tests * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts (microsoft#213301) * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts * fix compiler * Polish the code that sets env in packageJSONContribution.ts (microsoft#213306) * fix this reference in instantiation service (microsoft#213311) * Fix unsafe type assertions on object literals (microsoft#213318) * Benibenj/registerContextKeyHandler (microsoft#213135) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup * first draft contexkt key registration * Make it a provider * Use group instead of active editor * getGroupContextKeyValue * doc * Fix merge error * 💄 --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * allow returning undefined if file was not saved (microsoft#213123) * allow returning undefined if file was not saved * bring back cancellation check * helper utility to convey optional result if cancelled * edit * inline function * test cancelled custom save * inline more --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Fix codicons padding in chat attachments * git: allow querying whether files are gitignore (microsoft#212982) * git: allow querying whether files are gitignore This exposes `checkIgnore`, which I want to use in copilot to determine which files I should go into when checking references. * rename method * Making API `editorHoverVerbosityLevel` use `verbosityLevel` instead of `action` (microsoft#213317) * allowing to cancel a previous request and jump directly to a request for a delta at a higher level * adding code in order to dispose the token sources when the full object is disposed * Fix issue with Cmd+W closing the window with opened tabs (microsoft#213335) fixes microsoft#213324 * Render html as plaintext when html not supported (microsoft#213265) * Support rendering unsupported html tags as plaintext for chat * Render html as plaintext when html not supported * Add comment and test for trusted domains * code action and lightbulb telemetry updates (microsoft#212929) * added additional telemetry and remove unused telemetry event * removed unused imports * Bump distro (microsoft#213340) * Part of microsoft#211878 (microsoft#212902) * SCM - add commands to focus next/previous input (microsoft#213337) * SCM - refactor commands to focus input * Ensure that the input node is expanded in the tree * getParent() should handle expanding the repository node * Use ArrayNavigator instead * Add support for looping in the array navigator * 💄 * use rot instead of array navigator * 💄 * more 💄 --------- Co-authored-by: João Moreno <joao.moreno@microsoft.com> * SCM - getParent() should handle resource groups (microsoft#213350) * refactor: replace direct process.pid usage with getProcessId method (microsoft#213352) * refactor: replace direct process.pid usage with getProcessId method * remove console.log * feat: enable attaching symbols to chat via `@` (microsoft#213347) * feat: enable attaching symbols to chat via `@` * Oop * SCM - add commands to focus previous/next resource group (microsoft#213377) * Initial implementation * 💄 * Fixed issue with focusing outside the tree * Joh/homely-damselfly (microsoft#213376) * chore - `ReplyResponse` cleanup * associate hunk data with response id * Associate hunk data with response state so that accepting hunks updates the text edit group * first cut of moving N-edits conversion from inline chat to panel * don't always consume mouse wheel (microsoft#213383) for chat widget (list) and for chat input editor (actually all simple editor cases) * clean up dead context keys and other dead code (microsoft#213387) * inline chat for notebook cell uses the `Notebook` chat location (microsoft#213385) * inline chat for notebook cell uses the `Notebook` chat location * fix tests * show filename for compare code blocks (microsoft#213389) * check uri when combining edits from different groups (microsoft#213390) * Fix issue microsoft#212877: Use Action context for Multi Diff Editor Actions (microsoft#213293) fix microsoft#212877 * Remove configure inline chat command from menu because it isn't popular at all and takes space (microsoft#213396) also fixes https://github.com/microsoft/vscode-copilot/issues/5662 * Scope custom editor and webview context keys to editor groups and global context (microsoft#213398) Properly scope custom editor and webview context keys * Fix broken codeblocks (microsoft#213399) * Fix broken codeblocks Fix microsoft#213382 * Fix tests * fix microsoft#194105 (microsoft#213403) * Add tests for editor group model (microsoft#213405) * Add test for editor group model * user helper function * web reporter refactor and issueFormService (microsoft#212951) * web version working * change to mainWindow * PROPER MOVEMENT * working for web as well * move issueFormService to workbench/contrib/issue * cleaning up{ * more cleanup, added setting * styling * use mainwindow to open and closee * css fixes * fix css again * fix CSS and wonky applyCSS rules * change gulpfile * add and update system info * address some of the comments * move files! small changes * move JS and non window specific back to electron sandbox * fix on issueReporter.js * fix build file * fix gulp file too.... * move everything into contrib * fix workbench import * move everything else into contrib, fix import * change name to web * applying more feedback fixes :D * fix command and remove unused import: * add back issueTroubleshoot * fix gulpile outputs * fix out exclusion: * Disable web TS type acquisition (microsoft#213412) We're waiting on some perf improvement for upstream types installer before turning this on everywhere * Hook up prototype paste with imports for JS/TS (microsoft#204665) * Hook up prototype paste with imports for JS/TS For microsoft/TypeScript#57262 but with proposed changes to ts protocol * Support new api * Update * issue reporter re-open save state (microsoft#213418) if anything is typed and we call open reporter again, saves issue title and data * provide default settings (microsoft#213419) fix microsoft#213411 * add item label (microsoft#213422) * add item label * update active window label * Add "when" clause to chat participants (microsoft#213425) * Add "when" clause to chat participants Fix microsoft#212447 * Change _agents to a Map and write some tests * Fix import * Change proposal for chat participant "when" clause (microsoft#213427) * Change proposal for chat participant "when" clause * This * feat: add top level `Symbol...` to Attach Context picker (microsoft#213435) * feat: enable attaching symbols to chat via `#` * feat: add `Symbol...` to Attach Context picker * feat: easier keyboard flow for removing chat attachments (microsoft#213436) * ts - enable use code watcher by default (microsoft#213450) * Fix menu computation when compact on right side (microsoft#213459) fix menu computation when compact on right side * Add focus indication for compact menu (microsoft#213463) indicate when compact menu is focused * Debt - dispose child instantiation service (microsoft#213471) * Fix "new chat" before focusing chat panel (microsoft#213478) Fix microsoft#213353 * Sort @workspace /explain above @Terminal /explain (microsoft#213482) Fix microsoft/vscode-copilot-release#1245 This is a bit of a hack but has some advantanges over adding an 'order' field to the chat participant or something like that. We can keep the order the same in other cases except for when the user is typing to filter the / list, then @Terminal slash commands will be pushed down. * Don't show chat agent hover on empty space in header (microsoft#213486) Fix microsoft/vscode-copilot#5271 * chore: update remote node.js (microsoft#213439) * chore: update remote node.js to v20.11.1 * chore: remove io_uring workaround * chore: update checksums * temp: update distro * ci: rebuild cache * chore: bump distro * Working sets - add preserveFocus (microsoft#213397) * Working sets - preserve focus when applying the working set was initiated by an action that was taken in the panel part (ex: switching branches from the terminal) * Pull request feedback * renames and cleanup * renames and cleanup * renames and cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Add "Open in Editor" button for chat history (microsoft#213518) Fix microsoft#213517 * fix microsoft#213526 (microsoft#213527) * fix microsoft#181407 (microsoft#213530) * Remove brackets from comments, strings and regexes before evaluating the indentation (microsoft#210641) * wip * polishing the code * adding code * adding the language * reshuffling the code to avoid cyclic dependency * polihsing code * uncommenting tests * also adopting the indentation rules within the reindentation operation * using instead the sliced line tokens instead of the scoped line tokens * polishing the code * using start indices instead * using value everywhere * using the token data to type the tokens * setting to number instead of standard token type * using token data from autoindenttest.ts * using same code in both test files * placing instantiation service into the registerLanguage method * copying object into the node js autoindent.ts * report new windo profile setting (microsoft#213531) * Add license for deviceid (microsoft#213536) * watcher - add the utility process worker to disposables (microsoft#213538) * Color theme preview not working with "window.systemColorTheme": "auto" (microsoft#213539) * watcher - more `dispose` and remove E15 workaround (microsoft#213540) * Fix comments memory leak (microsoft#213542) Fixes microsoft#213535 * Fix copyright statement (microsoft#213543) * Don't show the gutter menu in the chat diff editor. (microsoft#213546) * Fixes diff editor height issue. (microsoft#213547) Before: Always 100% of parent container. After: Uses passed in dimensions. * Fixes microsoft#209627 (microsoft#213554) * SCM - reveal resource in the source control tree (microsoft#213556) * Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#213557) Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#200091) * Fixes microsoft#209417 (microsoft#213549) * use refs/tags/release for 1espt (microsoft#213558) * debt - fix a few leaking listeners (microsoft#213560) * Ignore indentation rules when interacting with a string (microsoft#210761) * ignore indenation when interacting with a string * changes from discussion * remove the export keyword * adding changes to the PR * removing the console log * adding one more comment * extracting the method which forces the tokenization * Add license URIs for toml_edit and toml_datetime (microsoft#213562) Add licene uri fr toml_edit and toml_datetime * fix microsoft#213563 (microsoft#213564) * report new window profile switch (microsoft#213566) * Fixes microsoft#213573 (microsoft#213574) * fix microsoft#213576 (microsoft#213577) * Add editor.findMatchForeground (microsoft#213497) * feature: make find decoration foreground color configurable * Update license and third party notices (microsoft#213580) * editors - add test for transient group model changes (microsoft#213581) * Fixes microsoft#212771 (microsoft#213584) * Fix an issue where defaultLinesDiffComputer does not pass in the timeout variable (microsoft#213035) Update defaultLinesDiffComputer.ts * fix microsoft#212674 (microsoft#213583) * Fixes diff editor height in monaco editor playground example. (microsoft#213585) * Feat: Bolder Typeface + Configurable Letter Spacing for Minimap's Section Header Labels ✨ (microsoft#209990) * Rendering Section Header Labels with space in between the characters for better readability. * Making Section Headers Bold * Added settings for the Section Header Letter Spacing of the Minimap * a more performant and non-breaking way to render characters * fixed the git problems * add test default value * Allow fine-tuning the letter spacing, minor tweaks --------- Co-authored-by: Alexandru Dima <alexdima@microsoft.com> * Support diff merge editor for Notebooks (microsoft#213602) * Add Search in Cell Selection to Notebook Find Widget (microsoft#213409) * all search scope functionality except cell decorations * fix filter icon showing fake useage * decorations + css tweaking + PR feedback * Adding accessibility help for verbose hover (microsoft#212783) * adding code in order to provide accessibility help for the hover * adding the description of the possible commands that can be used * reusing the method * joining the content and changing the text in the help view * polishing the code * removing the question mark * changing the import * removing the setting ID from imports * adding code in order to update when the hover updates * adding methods to service * adding code in order to dispose the accessible hover view * fixing bug * polishing the code * checking that action not supported for the early return * using disposable store instead * using the appropriate string * polishing the code * using instead the type help and the resolved keybindings * hiding also on the `onDidBlurEditorWidget` firing * Revert "using instead the type help and the resolved keybindings" This reverts commit 1f450dd. * use hover accessible view, provide custom help * Revert "Revert "using instead the type help and the resolved keybindings"" This reverts commit 12f0cf6. * add HoverAccessibilityHelp, BaseHoverAccessibleViewProvider * polishing the code * polishing the code * provide content at a specific index from the hover accessibility help provider * introducing method _initializeOptions * using readonly where possible * using public everywhere * using a getter for the actions --------- Co-authored-by: meganrogge <megan.rogge@microsoft.com> * Add more info to comment range error (microsoft#213578) Part of microsoft#213243 * Bump postcss from 7.0.39 to 8.4.38 (microsoft#209857) Bumps [postcss](https://github.com/postcss/postcss) from 7.0.39 to 8.4.38. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.39...8.4.38) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: dispose template data disposables in source column renderer (microsoft#202618) * fixes regression: adding a `isCheapToTokenize` check before tokenizing the line (microsoft#213674) adding a check on how it is cheap to tokenize the lines * fix windows terminal hint not showing up (microsoft#213695) fix microsoft#213693 * Missing server node module (microsoft#213712) * Fix hover padding regression (microsoft#213700) * Fix textPreformatForeground for HC themes (microsoft#213698) * Fix js/ts cross code block intellisense (microsoft#213726) We need to register support for the backing copilot scheme too, not just the panel scheme in core * Fix vscode-api-tests in stable (microsoft#213733) * debug: bump js-debug for 1.90 (microsoft#213735) * fix: render ranges for attached selections in chat (microsoft#213741) * fix accessible view kb quickpick not showing (microsoft#213745) * fix: set aria label for chat context attachments (microsoft#213747) * web issue reporter styles (microsoft#213751) remove mac from tag * defaults web issue report false and disable in Firefox (microsoft#213752) * turn off in release and in ff * update * remove global enablement message (microsoft#213128) * editors - clarify `window.restoreWindows` setting further (microsoft#213771) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) (microsoft#213776) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) * simplify * aux window - support Firefox (microsoft#213769) * aux window - support Firefox * add more * only use workaround for FF * enable issue repoter again * . * fix microsoft#212208 (microsoft#213779) * Make rest of terminal initial hint italic Part of microsoft#213647 * Align colors of terminal hint with editor * Use pointer cursor for whole terminal initial hint Fixes microsoft/vscode-copilot#5963 * unwrap `LanguageModelError` when invoking chat participant (microsoft#213784) re microsoft#213710 * fix https://github.com/microsoft/vscode-copilot/issues/5814 (microsoft#213787) * fixes https://github.com/microsoft/vscode-copilot/issues/5908 (microsoft#213788) * fixes microsoft#213644 (microsoft#213789) * fix microsoft#213614 (microsoft#213791) * SCM - all calls from extHostSCM to mainThreadSCM should use a sequencer to ensure that the source control object is created (microsoft#213792) * Fix multi selected tab close behavior (microsoft#213794) fix microsoft#213620 * fix microsoft#196351 (microsoft#213796) * Cannot read properties of undefined (reading 'layout') (microsoft#213797) Fixes microsoft#212235 * fix microsoft#211965 (microsoft#213801) * fix: remove temp dir if extension is installed by another source (microsoft#213379) * closing out inline chat while speech is going does not stop audio (fix microsoft#213709) (microsoft#213802) * No text to speech when a change is applied (fix microsoft#213667) (microsoft#213804) * Regression: Unsaved comment reply lost when changing editors (microsoft#213805) Fixes microsoft#213144 * Voice dictation shortcut (fix microsoft#206800) (microsoft#213806) * Enable initialHint when not stable for now Part of microsoft#213647 * fix leaking listener (microsoft#213816) re microsoft#213141 * fix: setting labels appearing in widgets (microsoft#213826) * Connor4312/issue211378 (microsoft#213829) cli: fix inverted condition not showing warning correctly Fixes microsoft#211378 * doc updates & fixes for chat/lm API (microsoft#213777) * workaround @link not working * fixes microsoft#213630 * Retain previous quick pick navigation behavior with Home and End (microsoft#213832) Fixes microsoft#213739 * Fix microsoft#213525. Move nb chat variable to service (microsoft#213835) * Added redirect * Deleted build * Added submodule * Added symlinking * Added progress * Added script progress * Added attempt to fixx packaging * Added fresh install * Changed back to code.sh * Changed name * fix: hide Attach Context for quick chat (microsoft#213841) * Hook up notebook format code action to format notebook command (microsoft#213847) hook format codeaction to format notebook command * Added extHostChatAgents2.ts * Added contributing * Add setup scripts for different environments (#87) * Add setup scripts for for cross enviroments * add calls to vscode build scripts * update function naming * reduce DRY code in setup scripts * remove old link & update gitignore --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> Co-authored-by: Benjamin Christopher Simmonds <44439583+benibenj@users.noreply.github.com> Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Connor Peet <connor@peet.io> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: Joyce Er <joyce.er@microsoft.com> Co-authored-by: Joyce Er <joyceerhl@gmail.com> Co-authored-by: Isidor Nikolic <inikolic@microsoft.com> Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com> Co-authored-by: Walker Boyle <wboyle13@gmail.com> Co-authored-by: Matt Bierner <matb@microsoft.com> Co-authored-by: David Dossett <ddossett@microsoft.com> Co-authored-by: Aaron Munger <aamunger@microsoft.com> Co-authored-by: Peng Lyu <penn.lv@gmail.com> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: Alexandru Dima <alexdima@microsoft.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: João Moreno <joao.moreno@microsoft.com> Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com> Co-authored-by: Alex Ross <alros@microsoft.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Simon Siefke <simon.siefke@gmail.com> Co-authored-by: Hanning Gong (Charles) <charles.gong@databricks.com> Co-authored-by: Pouya Kary ✨ <kary@gnu.org> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Michael Lively <milively@microsoft.com> Co-authored-by: meganrogge <megan.rogge@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shoham Ben Shitrit <91195275+bsShoham@users.noreply.github.com> Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Co-authored-by: Yesterday17 <mmf@mmf.moe> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> Co-authored-by: Nathan A <nang@Nathans-MacBook-Pro-8.local> Co-authored-by: Ender <endergamingfilms@gmail.com>

@workspace

* Limit image width in chat (microsoft#213021) * Make sure child instantiation service instances are disposed/tracked for disposal (microsoft#212879) (microsoft#213002) * voice - limit `Escape` key to context key scopes (might help for microsoft#213017) (microsoft#213049) * Cleanup editor group context keys (microsoft#212955) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * chore: bump electron@29.4.0 (microsoft#213050) * chore: bump electron@29.4.0 * chore: remove io_uring workaround * chore: bump distro * chore: update dialog result for canceled save dialogs Refs electron/electron@fe01ed7 * chore: add back io_uring workaround for remote oss tests * chore: update nodejs v20.9.0 build * chore: add back io_uring workaround for remote tests * chore: update CLI dependences, add env var options for login * if no selected items, return to accessibility help dialog (microsoft#213075) * provider keyboard users with hover actions (microsoft#213077) * feat: allow ➡️ to add chat context in background (microsoft#213078) * eng: fix prelaunch task on recent node versions Closes microsoft#212888 * fix: limit width of chat attachment widgets * eng: fix off-by-1 error in selfhost test error messages (microsoft#213081) Fixes microsoft#212808 * Fix chat welcome message tooltip (microsoft#213084) * fix a few accessible view bugs (microsoft#213097) * Respect isSlow for chat attachments (microsoft#213105) * strip markdown from chat accessible view, maintain code block nav functionality (microsoft#213096) * resolve accessibility help dialog kbs in `accessibleViewService` (microsoft#213107) * feat: support dynamic variables in chat context picker * Fix misaligned jsdoc * Fix shared input history between chat locations (microsoft#213111) Fix microsoft/vscode-copilot-release#1228 * Fix merging chat anchors in markdown content (microsoft#213114) * Fix merging multiple chat anchors inside markdown content * Simplify types * Fix tests * make sure to push an undo stop after each request (microsoft#213137) fixes https://github.com/microsoft/vscode-copilot/issues/5736 * adjust max input part height for compact chat widget, keep input height separate when compute minHeight (microsoft#213139) fixes https://github.com/microsoft/vscode-copilot/issues/5707 * chore - inline chat controller tests works without agents only (no more glue provider-agent) (microsoft#213151) * Tabs Multi Select Polish (microsoft#212930) * Tabs Multi Select Polish * 💄 * add todo * add todo * update * 💄 * 💄 * 💄 * more review * 💄 * 💄 * fix bad function call * remove todo * jsdoc * 💄 * fix typo * 💄 * 💄 * 💄 multiEditorTabs * model accepts multiple editors * Use setSelection() * fix tests * 💄 * 💄 * discussion * discussion * fix selection * typo --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * remove bridge agents and agent providers because inline chat is all participants now * remove much of IInlineChatSessionProvider * deprecate IInlineChatService and move most consumers off * undo cell diag changes * fix: tsserver no longer crashes when log path includes spaces (microsoft#212752) * Treat normal markdown links as a single token for progressive chat rendering (microsoft#213091) Fixes our progressive chat renderer breaking up any markdown links that contain `-` or a space character. Doesn't support all the fancy markdown link syntaxes, just basic links for now * Pick up latest ts for building VS Code (microsoft#213170) * feat: allow extensions to attach chat context (microsoft#213172) * feat: allow extensions to attach chat context * fix: allow attaching different ranges from same file * fix: restore accepting files from picker * Use `resolveContentAndKeybindingItems` for diff editor, accessible view, and terminal (microsoft#213179) * Use `ChatAgentService` instead of `InlineChatService` for terminal chat hint (microsoft#213183) fix microsoft#213159 * Tweak confirmations pading * Properly handle errors thrown from renderer while invoking the chat agent (microsoft#213080) * Properly handle errors thrown from renderer while invoking the chat agent If we throw out of ChatService, then the request can't be canceled and stays "generating" forever * Update snapshot * Save on EH diagnostics (microsoft#213171) * added trace logs * another trace message * fix test ctors * remove test logs (microsoft#213188) * testing: exploratory UI for followup actions This adds an API that extensions can use to contribute 'followup' actions around test messages. Here just a dummy hello world using copilot, but extensions could have any action here, such as actions to update snapshots if a test failed: ![](https://memes.peet.io/img/24-05-c1f3e073-a2da-4f16-a033-c8f7e5cd4864.png) Implemented using a simple provider API. * Notebook Chat Controller does not need use agent directly * Hack to get it working * feat: persist chat attachments in history * Fix "open chat in editor" (microsoft#213198) Fix microsoft/vscode-copilot-release#1233 * chore - remove dead/stale commands (microsoft#213207) * chore - write error message so that it doesn't get confused as file path (microsoft#213210) * Perf: visualise memory efficiency (microsoft#211837) (microsoft#213208) * Perf: visualise memory efficiency (microsoft#211837) * feat: add telemetry logging for startup heap statistics * fix compile * feat: add used heap size to startup performance telemetry * refactor: remove allocated heap size from startup performance telemetry * comments * debt - some multi-tabs select cleanup (microsoft#213161) * chore: update deps for linux x64 client (microsoft#213221) chore: update linux client dependencies * editors - fix context on `EDITOR_CLOSE` (microsoft#213223) * SCM - add command to focus input (microsoft#213225) * allow customizing accessibility signal delays (microsoft#212834) * fix: set `id` and `name` for files in chat context * Disable VS Code file watching for yarn pnp (microsoft#213238) Disable VS Code file watching on yarn pnp * Enable roaming of inflight chat requests (microsoft#213239) This enables to remove the special handling for `/explain` - fixes https://github.com/microsoft/vscode-copilot/issues/2192 - fixes microsoft#208706 because inline chat now closes on "view in chat" - fixes https://github.com/microsoft/vscode-copilot/issues/5288 * Add VS device id (microsoft#213231) * NotebookChatController still manages ChatModel * Don't register chat participants in stable (microsoft#213244) * Don't register chat participants in stable And fork some Additions APIs into chatParticipantPrivate * Remove stale proposals * Move more API out of Additions * Start session when notebook chat widget is created * Implement Profiles Editor (microsoft#213246) * first cut * second cut * fix * add more features * support skipping copying resources while creating * enable behind internal setting * testing: polish followups a little, selfhost with copilot * Update for latest code mapper proposal (microsoft#213256) * Remove notebook chat menu * Rename vsDeviceId (microsoft#213261) * polish profiles editor (microsoft#213262) * refactor: clean up chat context types (microsoft#213264) * fix: prevent attaching the same chat context twice (microsoft#213266) * Bump distro (microsoft#213268) * more polish (microsoft#213267) * more polish * refactor actions * fix hover * Prevent using disposed of timers (microsoft#213271) * Prevent using disposed of timers If a timer has been disposed of, warn and don't schedule the callback. This is needed as otherwise the timer very likely ends up being leaked * Throw errors instead * Fix microsoft#213206. Migrate off IInlineChatService (microsoft#213263) * Fix microsoft#213206. Migrate off IInlineChatService * fix tests * Fix leaking uponSanitizeElement hook (microsoft#213277) * Tweak agent hover (microsoft#213278) "View in Marketplace" seems to be confusing people * Fix fillInIncompleteTokens for ordered lists (microsoft#213280) * fix: apply query filter to `additionPicks` (microsoft#213281) * Fix StableEditorBottomScrollState (microsoft#212970) * False positive "saving too long" dialog hindering saving a file (fix microsoft/vscode-internalbacklog#4943) (microsoft#213290) * Remove tree view show hover (microsoft#213212) * remove `IInlineChatService` and types around it (microsoft#213298) * increase listener refusal threshold significantly (microsoft#213292) * increase listener refusal threshold significantly * fix tests * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts (microsoft#213301) * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts * fix compiler * Polish the code that sets env in packageJSONContribution.ts (microsoft#213306) * fix this reference in instantiation service (microsoft#213311) * Fix unsafe type assertions on object literals (microsoft#213318) * Benibenj/registerContextKeyHandler (microsoft#213135) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup * first draft contexkt key registration * Make it a provider * Use group instead of active editor * getGroupContextKeyValue * doc * Fix merge error * 💄 --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * allow returning undefined if file was not saved (microsoft#213123) * allow returning undefined if file was not saved * bring back cancellation check * helper utility to convey optional result if cancelled * edit * inline function * test cancelled custom save * inline more --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Fix codicons padding in chat attachments * git: allow querying whether files are gitignore (microsoft#212982) * git: allow querying whether files are gitignore This exposes `checkIgnore`, which I want to use in copilot to determine which files I should go into when checking references. * rename method * Making API `editorHoverVerbosityLevel` use `verbosityLevel` instead of `action` (microsoft#213317) * allowing to cancel a previous request and jump directly to a request for a delta at a higher level * adding code in order to dispose the token sources when the full object is disposed * Fix issue with Cmd+W closing the window with opened tabs (microsoft#213335) fixes microsoft#213324 * Render html as plaintext when html not supported (microsoft#213265) * Support rendering unsupported html tags as plaintext for chat * Render html as plaintext when html not supported * Add comment and test for trusted domains * code action and lightbulb telemetry updates (microsoft#212929) * added additional telemetry and remove unused telemetry event * removed unused imports * Bump distro (microsoft#213340) * Part of microsoft#211878 (microsoft#212902) * SCM - add commands to focus next/previous input (microsoft#213337) * SCM - refactor commands to focus input * Ensure that the input node is expanded in the tree * getParent() should handle expanding the repository node * Use ArrayNavigator instead * Add support for looping in the array navigator * 💄 * use rot instead of array navigator * 💄 * more 💄 --------- Co-authored-by: João Moreno <joao.moreno@microsoft.com> * SCM - getParent() should handle resource groups (microsoft#213350) * refactor: replace direct process.pid usage with getProcessId method (microsoft#213352) * refactor: replace direct process.pid usage with getProcessId method * remove console.log * feat: enable attaching symbols to chat via `@` (microsoft#213347) * feat: enable attaching symbols to chat via `@` * Oop * SCM - add commands to focus previous/next resource group (microsoft#213377) * Initial implementation * 💄 * Fixed issue with focusing outside the tree * Joh/homely-damselfly (microsoft#213376) * chore - `ReplyResponse` cleanup * associate hunk data with response id * Associate hunk data with response state so that accepting hunks updates the text edit group * first cut of moving N-edits conversion from inline chat to panel * don't always consume mouse wheel (microsoft#213383) for chat widget (list) and for chat input editor (actually all simple editor cases) * clean up dead context keys and other dead code (microsoft#213387) * inline chat for notebook cell uses the `Notebook` chat location (microsoft#213385) * inline chat for notebook cell uses the `Notebook` chat location * fix tests * show filename for compare code blocks (microsoft#213389) * check uri when combining edits from different groups (microsoft#213390) * Fix issue microsoft#212877: Use Action context for Multi Diff Editor Actions (microsoft#213293) fix microsoft#212877 * Remove configure inline chat command from menu because it isn't popular at all and takes space (microsoft#213396) also fixes https://github.com/microsoft/vscode-copilot/issues/5662 * Scope custom editor and webview context keys to editor groups and global context (microsoft#213398) Properly scope custom editor and webview context keys * Fix broken codeblocks (microsoft#213399) * Fix broken codeblocks Fix microsoft#213382 * Fix tests * fix microsoft#194105 (microsoft#213403) * Add tests for editor group model (microsoft#213405) * Add test for editor group model * user helper function * web reporter refactor and issueFormService (microsoft#212951) * web version working * change to mainWindow * PROPER MOVEMENT * working for web as well * move issueFormService to workbench/contrib/issue * cleaning up{ * more cleanup, added setting * styling * use mainwindow to open and closee * css fixes * fix css again * fix CSS and wonky applyCSS rules * change gulpfile * add and update system info * address some of the comments * move files! small changes * move JS and non window specific back to electron sandbox * fix on issueReporter.js * fix build file * fix gulp file too.... * move everything into contrib * fix workbench import * move everything else into contrib, fix import * change name to web * applying more feedback fixes :D * fix command and remove unused import: * add back issueTroubleshoot * fix gulpile outputs * fix out exclusion: * Disable web TS type acquisition (microsoft#213412) We're waiting on some perf improvement for upstream types installer before turning this on everywhere * Hook up prototype paste with imports for JS/TS (microsoft#204665) * Hook up prototype paste with imports for JS/TS For microsoft/TypeScript#57262 but with proposed changes to ts protocol * Support new api * Update * issue reporter re-open save state (microsoft#213418) if anything is typed and we call open reporter again, saves issue title and data * provide default settings (microsoft#213419) fix microsoft#213411 * add item label (microsoft#213422) * add item label * update active window label * Add "when" clause to chat participants (microsoft#213425) * Add "when" clause to chat participants Fix microsoft#212447 * Change _agents to a Map and write some tests * Fix import * Change proposal for chat participant "when" clause (microsoft#213427) * Change proposal for chat participant "when" clause * This * feat: add top level `Symbol...` to Attach Context picker (microsoft#213435) * feat: enable attaching symbols to chat via `#` * feat: add `Symbol...` to Attach Context picker * feat: easier keyboard flow for removing chat attachments (microsoft#213436) * ts - enable use code watcher by default (microsoft#213450) * Fix menu computation when compact on right side (microsoft#213459) fix menu computation when compact on right side * Add focus indication for compact menu (microsoft#213463) indicate when compact menu is focused * Debt - dispose child instantiation service (microsoft#213471) * Fix "new chat" before focusing chat panel (microsoft#213478) Fix microsoft#213353 * Sort @workspace /explain above @Terminal /explain (microsoft#213482) Fix microsoft/vscode-copilot-release#1245 This is a bit of a hack but has some advantanges over adding an 'order' field to the chat participant or something like that. We can keep the order the same in other cases except for when the user is typing to filter the / list, then @Terminal slash commands will be pushed down. * Don't show chat agent hover on empty space in header (microsoft#213486) Fix microsoft/vscode-copilot#5271 * chore: update remote node.js (microsoft#213439) * chore: update remote node.js to v20.11.1 * chore: remove io_uring workaround * chore: update checksums * temp: update distro * ci: rebuild cache * chore: bump distro * Working sets - add preserveFocus (microsoft#213397) * Working sets - preserve focus when applying the working set was initiated by an action that was taken in the panel part (ex: switching branches from the terminal) * Pull request feedback * renames and cleanup * renames and cleanup * renames and cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Add "Open in Editor" button for chat history (microsoft#213518) Fix microsoft#213517 * fix microsoft#213526 (microsoft#213527) * fix microsoft#181407 (microsoft#213530) * Remove brackets from comments, strings and regexes before evaluating the indentation (microsoft#210641) * wip * polishing the code * adding code * adding the language * reshuffling the code to avoid cyclic dependency * polihsing code * uncommenting tests * also adopting the indentation rules within the reindentation operation * using instead the sliced line tokens instead of the scoped line tokens * polishing the code * using start indices instead * using value everywhere * using the token data to type the tokens * setting to number instead of standard token type * using token data from autoindenttest.ts * using same code in both test files * placing instantiation service into the registerLanguage method * copying object into the node js autoindent.ts * report new windo profile setting (microsoft#213531) * Add license for deviceid (microsoft#213536) * watcher - add the utility process worker to disposables (microsoft#213538) * Color theme preview not working with "window.systemColorTheme": "auto" (microsoft#213539) * watcher - more `dispose` and remove E15 workaround (microsoft#213540) * Fix comments memory leak (microsoft#213542) Fixes microsoft#213535 * Fix copyright statement (microsoft#213543) * Don't show the gutter menu in the chat diff editor. (microsoft#213546) * Fixes diff editor height issue. (microsoft#213547) Before: Always 100% of parent container. After: Uses passed in dimensions. * Fixes microsoft#209627 (microsoft#213554) * SCM - reveal resource in the source control tree (microsoft#213556) * Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#213557) Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#200091) * Fixes microsoft#209417 (microsoft#213549) * use refs/tags/release for 1espt (microsoft#213558) * debt - fix a few leaking listeners (microsoft#213560) * Ignore indentation rules when interacting with a string (microsoft#210761) * ignore indenation when interacting with a string * changes from discussion * remove the export keyword * adding changes to the PR * removing the console log * adding one more comment * extracting the method which forces the tokenization * Add license URIs for toml_edit and toml_datetime (microsoft#213562) Add licene uri fr toml_edit and toml_datetime * fix microsoft#213563 (microsoft#213564) * report new window profile switch (microsoft#213566) * Fixes microsoft#213573 (microsoft#213574) * fix microsoft#213576 (microsoft#213577) * Add editor.findMatchForeground (microsoft#213497) * feature: make find decoration foreground color configurable * Update license and third party notices (microsoft#213580) * editors - add test for transient group model changes (microsoft#213581) * Fixes microsoft#212771 (microsoft#213584) * Fix an issue where defaultLinesDiffComputer does not pass in the timeout variable (microsoft#213035) Update defaultLinesDiffComputer.ts * fix microsoft#212674 (microsoft#213583) * Fixes diff editor height in monaco editor playground example. (microsoft#213585) * Feat: Bolder Typeface + Configurable Letter Spacing for Minimap's Section Header Labels ✨ (microsoft#209990) * Rendering Section Header Labels with space in between the characters for better readability. * Making Section Headers Bold * Added settings for the Section Header Letter Spacing of the Minimap * a more performant and non-breaking way to render characters * fixed the git problems * add test default value * Allow fine-tuning the letter spacing, minor tweaks --------- Co-authored-by: Alexandru Dima <alexdima@microsoft.com> * Support diff merge editor for Notebooks (microsoft#213602) * Add Search in Cell Selection to Notebook Find Widget (microsoft#213409) * all search scope functionality except cell decorations * fix filter icon showing fake useage * decorations + css tweaking + PR feedback * Adding accessibility help for verbose hover (microsoft#212783) * adding code in order to provide accessibility help for the hover * adding the description of the possible commands that can be used * reusing the method * joining the content and changing the text in the help view * polishing the code * removing the question mark * changing the import * removing the setting ID from imports * adding code in order to update when the hover updates * adding methods to service * adding code in order to dispose the accessible hover view * fixing bug * polishing the code * checking that action not supported for the early return * using disposable store instead * using the appropriate string * polishing the code * using instead the type help and the resolved keybindings * hiding also on the `onDidBlurEditorWidget` firing * Revert "using instead the type help and the resolved keybindings" This reverts commit 1f450dd. * use hover accessible view, provide custom help * Revert "Revert "using instead the type help and the resolved keybindings"" This reverts commit 12f0cf6. * add HoverAccessibilityHelp, BaseHoverAccessibleViewProvider * polishing the code * polishing the code * provide content at a specific index from the hover accessibility help provider * introducing method _initializeOptions * using readonly where possible * using public everywhere * using a getter for the actions --------- Co-authored-by: meganrogge <megan.rogge@microsoft.com> * Add more info to comment range error (microsoft#213578) Part of microsoft#213243 * Bump postcss from 7.0.39 to 8.4.38 (microsoft#209857) Bumps [postcss](https://github.com/postcss/postcss) from 7.0.39 to 8.4.38. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.39...8.4.38) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: dispose template data disposables in source column renderer (microsoft#202618) * fixes regression: adding a `isCheapToTokenize` check before tokenizing the line (microsoft#213674) adding a check on how it is cheap to tokenize the lines * fix windows terminal hint not showing up (microsoft#213695) fix microsoft#213693 * Missing server node module (microsoft#213712) * Fix hover padding regression (microsoft#213700) * Fix textPreformatForeground for HC themes (microsoft#213698) * Fix js/ts cross code block intellisense (microsoft#213726) We need to register support for the backing copilot scheme too, not just the panel scheme in core * Fix vscode-api-tests in stable (microsoft#213733) * debug: bump js-debug for 1.90 (microsoft#213735) * fix: render ranges for attached selections in chat (microsoft#213741) * fix accessible view kb quickpick not showing (microsoft#213745) * fix: set aria label for chat context attachments (microsoft#213747) * web issue reporter styles (microsoft#213751) remove mac from tag * defaults web issue report false and disable in Firefox (microsoft#213752) * turn off in release and in ff * update * remove global enablement message (microsoft#213128) * editors - clarify `window.restoreWindows` setting further (microsoft#213771) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) (microsoft#213776) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) * simplify * aux window - support Firefox (microsoft#213769) * aux window - support Firefox * add more * only use workaround for FF * enable issue repoter again * . * fix microsoft#212208 (microsoft#213779) * Make rest of terminal initial hint italic Part of microsoft#213647 * Align colors of terminal hint with editor * Use pointer cursor for whole terminal initial hint Fixes microsoft/vscode-copilot#5963 * unwrap `LanguageModelError` when invoking chat participant (microsoft#213784) re microsoft#213710 * fix https://github.com/microsoft/vscode-copilot/issues/5814 (microsoft#213787) * fixes https://github.com/microsoft/vscode-copilot/issues/5908 (microsoft#213788) * fixes microsoft#213644 (microsoft#213789) * fix microsoft#213614 (microsoft#213791) * SCM - all calls from extHostSCM to mainThreadSCM should use a sequencer to ensure that the source control object is created (microsoft#213792) * Fix multi selected tab close behavior (microsoft#213794) fix microsoft#213620 * fix microsoft#196351 (microsoft#213796) * Cannot read properties of undefined (reading 'layout') (microsoft#213797) Fixes microsoft#212235 * fix microsoft#211965 (microsoft#213801) * fix: remove temp dir if extension is installed by another source (microsoft#213379) * closing out inline chat while speech is going does not stop audio (fix microsoft#213709) (microsoft#213802) * No text to speech when a change is applied (fix microsoft#213667) (microsoft#213804) * Regression: Unsaved comment reply lost when changing editors (microsoft#213805) Fixes microsoft#213144 * Voice dictation shortcut (fix microsoft#206800) (microsoft#213806) * Enable initialHint when not stable for now Part of microsoft#213647 * fix leaking listener (microsoft#213816) re microsoft#213141 * fix: setting labels appearing in widgets (microsoft#213826) * Connor4312/issue211378 (microsoft#213829) cli: fix inverted condition not showing warning correctly Fixes microsoft#211378 * doc updates & fixes for chat/lm API (microsoft#213777) * workaround @link not working * fixes microsoft#213630 * Retain previous quick pick navigation behavior with Home and End (microsoft#213832) Fixes microsoft#213739 * Fix microsoft#213525. Move nb chat variable to service (microsoft#213835) * Added redirect * Deleted build * Added submodule * Added symlinking * Added progress * Added script progress * Added attempt to fixx packaging * Added fresh install * Changed back to code.sh * Changed name * fix: hide Attach Context for quick chat (microsoft#213841) * Hook up notebook format code action to format notebook command (microsoft#213847) hook format codeaction to format notebook command * Added extHostChatAgents2.ts * Added contributing * Add setup scripts for different environments (#87) * Add setup scripts for for cross enviroments * add calls to vscode build scripts * update function naming * reduce DRY code in setup scripts * remove old link & update gitignore --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> Co-authored-by: Benjamin Christopher Simmonds <44439583+benibenj@users.noreply.github.com> Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Connor Peet <connor@peet.io> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: Joyce Er <joyce.er@microsoft.com> Co-authored-by: Joyce Er <joyceerhl@gmail.com> Co-authored-by: Isidor Nikolic <inikolic@microsoft.com> Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com> Co-authored-by: Walker Boyle <wboyle13@gmail.com> Co-authored-by: Matt Bierner <matb@microsoft.com> Co-authored-by: David Dossett <ddossett@microsoft.com> Co-authored-by: Aaron Munger <aamunger@microsoft.com> Co-authored-by: Peng Lyu <penn.lv@gmail.com> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: Alexandru Dima <alexdima@microsoft.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: João Moreno <joao.moreno@microsoft.com> Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com> Co-authored-by: Alex Ross <alros@microsoft.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Simon Siefke <simon.siefke@gmail.com> Co-authored-by: Hanning Gong (Charles) <charles.gong@databricks.com> Co-authored-by: Pouya Kary ✨ <kary@gnu.org> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Michael Lively <milively@microsoft.com> Co-authored-by: meganrogge <megan.rogge@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shoham Ben Shitrit <91195275+bsShoham@users.noreply.github.com> Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Co-authored-by: Yesterday17 <mmf@mmf.moe> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> Co-authored-by: Nathan A <nang@Nathans-MacBook-Pro-8.local> Co-authored-by: Ender <endergamingfilms@gmail.com>

@workspace

* Limit image width in chat (microsoft#213021) * Make sure child instantiation service instances are disposed/tracked for disposal (microsoft#212879) (microsoft#213002) * voice - limit `Escape` key to context key scopes (might help for microsoft#213017) (microsoft#213049) * Cleanup editor group context keys (microsoft#212955) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * chore: bump electron@29.4.0 (microsoft#213050) * chore: bump electron@29.4.0 * chore: remove io_uring workaround * chore: bump distro * chore: update dialog result for canceled save dialogs Refs electron/electron@fe01ed7 * chore: add back io_uring workaround for remote oss tests * chore: update nodejs v20.9.0 build * chore: add back io_uring workaround for remote tests * chore: update CLI dependences, add env var options for login * if no selected items, return to accessibility help dialog (microsoft#213075) * provider keyboard users with hover actions (microsoft#213077) * feat: allow ➡️ to add chat context in background (microsoft#213078) * eng: fix prelaunch task on recent node versions Closes microsoft#212888 * fix: limit width of chat attachment widgets * eng: fix off-by-1 error in selfhost test error messages (microsoft#213081) Fixes microsoft#212808 * Fix chat welcome message tooltip (microsoft#213084) * fix a few accessible view bugs (microsoft#213097) * Respect isSlow for chat attachments (microsoft#213105) * strip markdown from chat accessible view, maintain code block nav functionality (microsoft#213096) * resolve accessibility help dialog kbs in `accessibleViewService` (microsoft#213107) * feat: support dynamic variables in chat context picker * Fix misaligned jsdoc * Fix shared input history between chat locations (microsoft#213111) Fix microsoft/vscode-copilot-release#1228 * Fix merging chat anchors in markdown content (microsoft#213114) * Fix merging multiple chat anchors inside markdown content * Simplify types * Fix tests * make sure to push an undo stop after each request (microsoft#213137) fixes https://github.com/microsoft/vscode-copilot/issues/5736 * adjust max input part height for compact chat widget, keep input height separate when compute minHeight (microsoft#213139) fixes https://github.com/microsoft/vscode-copilot/issues/5707 * chore - inline chat controller tests works without agents only (no more glue provider-agent) (microsoft#213151) * Tabs Multi Select Polish (microsoft#212930) * Tabs Multi Select Polish * 💄 * add todo * add todo * update * 💄 * 💄 * 💄 * more review * 💄 * 💄 * fix bad function call * remove todo * jsdoc * 💄 * fix typo * 💄 * 💄 * 💄 multiEditorTabs * model accepts multiple editors * Use setSelection() * fix tests * 💄 * 💄 * discussion * discussion * fix selection * typo --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * remove bridge agents and agent providers because inline chat is all participants now * remove much of IInlineChatSessionProvider * deprecate IInlineChatService and move most consumers off * undo cell diag changes * fix: tsserver no longer crashes when log path includes spaces (microsoft#212752) * Treat normal markdown links as a single token for progressive chat rendering (microsoft#213091) Fixes our progressive chat renderer breaking up any markdown links that contain `-` or a space character. Doesn't support all the fancy markdown link syntaxes, just basic links for now * Pick up latest ts for building VS Code (microsoft#213170) * feat: allow extensions to attach chat context (microsoft#213172) * feat: allow extensions to attach chat context * fix: allow attaching different ranges from same file * fix: restore accepting files from picker * Use `resolveContentAndKeybindingItems` for diff editor, accessible view, and terminal (microsoft#213179) * Use `ChatAgentService` instead of `InlineChatService` for terminal chat hint (microsoft#213183) fix microsoft#213159 * Tweak confirmations pading * Properly handle errors thrown from renderer while invoking the chat agent (microsoft#213080) * Properly handle errors thrown from renderer while invoking the chat agent If we throw out of ChatService, then the request can't be canceled and stays "generating" forever * Update snapshot * Save on EH diagnostics (microsoft#213171) * added trace logs * another trace message * fix test ctors * remove test logs (microsoft#213188) * testing: exploratory UI for followup actions This adds an API that extensions can use to contribute 'followup' actions around test messages. Here just a dummy hello world using copilot, but extensions could have any action here, such as actions to update snapshots if a test failed: ![](https://memes.peet.io/img/24-05-c1f3e073-a2da-4f16-a033-c8f7e5cd4864.png) Implemented using a simple provider API. * Notebook Chat Controller does not need use agent directly * Hack to get it working * feat: persist chat attachments in history * Fix "open chat in editor" (microsoft#213198) Fix microsoft/vscode-copilot-release#1233 * chore - remove dead/stale commands (microsoft#213207) * chore - write error message so that it doesn't get confused as file path (microsoft#213210) * Perf: visualise memory efficiency (microsoft#211837) (microsoft#213208) * Perf: visualise memory efficiency (microsoft#211837) * feat: add telemetry logging for startup heap statistics * fix compile * feat: add used heap size to startup performance telemetry * refactor: remove allocated heap size from startup performance telemetry * comments * debt - some multi-tabs select cleanup (microsoft#213161) * chore: update deps for linux x64 client (microsoft#213221) chore: update linux client dependencies * editors - fix context on `EDITOR_CLOSE` (microsoft#213223) * SCM - add command to focus input (microsoft#213225) * allow customizing accessibility signal delays (microsoft#212834) * fix: set `id` and `name` for files in chat context * Disable VS Code file watching for yarn pnp (microsoft#213238) Disable VS Code file watching on yarn pnp * Enable roaming of inflight chat requests (microsoft#213239) This enables to remove the special handling for `/explain` - fixes https://github.com/microsoft/vscode-copilot/issues/2192 - fixes microsoft#208706 because inline chat now closes on "view in chat" - fixes https://github.com/microsoft/vscode-copilot/issues/5288 * Add VS device id (microsoft#213231) * NotebookChatController still manages ChatModel * Don't register chat participants in stable (microsoft#213244) * Don't register chat participants in stable And fork some Additions APIs into chatParticipantPrivate * Remove stale proposals * Move more API out of Additions * Start session when notebook chat widget is created * Implement Profiles Editor (microsoft#213246) * first cut * second cut * fix * add more features * support skipping copying resources while creating * enable behind internal setting * testing: polish followups a little, selfhost with copilot * Update for latest code mapper proposal (microsoft#213256) * Remove notebook chat menu * Rename vsDeviceId (microsoft#213261) * polish profiles editor (microsoft#213262) * refactor: clean up chat context types (microsoft#213264) * fix: prevent attaching the same chat context twice (microsoft#213266) * Bump distro (microsoft#213268) * more polish (microsoft#213267) * more polish * refactor actions * fix hover * Prevent using disposed of timers (microsoft#213271) * Prevent using disposed of timers If a timer has been disposed of, warn and don't schedule the callback. This is needed as otherwise the timer very likely ends up being leaked * Throw errors instead * Fix microsoft#213206. Migrate off IInlineChatService (microsoft#213263) * Fix microsoft#213206. Migrate off IInlineChatService * fix tests * Fix leaking uponSanitizeElement hook (microsoft#213277) * Tweak agent hover (microsoft#213278) "View in Marketplace" seems to be confusing people * Fix fillInIncompleteTokens for ordered lists (microsoft#213280) * fix: apply query filter to `additionPicks` (microsoft#213281) * Fix StableEditorBottomScrollState (microsoft#212970) * False positive "saving too long" dialog hindering saving a file (fix microsoft/vscode-internalbacklog#4943) (microsoft#213290) * Remove tree view show hover (microsoft#213212) * remove `IInlineChatService` and types around it (microsoft#213298) * increase listener refusal threshold significantly (microsoft#213292) * increase listener refusal threshold significantly * fix tests * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts (microsoft#213301) * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts * fix compiler * Polish the code that sets env in packageJSONContribution.ts (microsoft#213306) * fix this reference in instantiation service (microsoft#213311) * Fix unsafe type assertions on object literals (microsoft#213318) * Benibenj/registerContextKeyHandler (microsoft#213135) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup * first draft contexkt key registration * Make it a provider * Use group instead of active editor * getGroupContextKeyValue * doc * Fix merge error * 💄 --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * allow returning undefined if file was not saved (microsoft#213123) * allow returning undefined if file was not saved * bring back cancellation check * helper utility to convey optional result if cancelled * edit * inline function * test cancelled custom save * inline more --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Fix codicons padding in chat attachments * git: allow querying whether files are gitignore (microsoft#212982) * git: allow querying whether files are gitignore This exposes `checkIgnore`, which I want to use in copilot to determine which files I should go into when checking references. * rename method * Making API `editorHoverVerbosityLevel` use `verbosityLevel` instead of `action` (microsoft#213317) * allowing to cancel a previous request and jump directly to a request for a delta at a higher level * adding code in order to dispose the token sources when the full object is disposed * Fix issue with Cmd+W closing the window with opened tabs (microsoft#213335) fixes microsoft#213324 * Render html as plaintext when html not supported (microsoft#213265) * Support rendering unsupported html tags as plaintext for chat * Render html as plaintext when html not supported * Add comment and test for trusted domains * code action and lightbulb telemetry updates (microsoft#212929) * added additional telemetry and remove unused telemetry event * removed unused imports * Bump distro (microsoft#213340) * Part of microsoft#211878 (microsoft#212902) * SCM - add commands to focus next/previous input (microsoft#213337) * SCM - refactor commands to focus input * Ensure that the input node is expanded in the tree * getParent() should handle expanding the repository node * Use ArrayNavigator instead * Add support for looping in the array navigator * 💄 * use rot instead of array navigator * 💄 * more 💄 --------- Co-authored-by: João Moreno <joao.moreno@microsoft.com> * SCM - getParent() should handle resource groups (microsoft#213350) * refactor: replace direct process.pid usage with getProcessId method (microsoft#213352) * refactor: replace direct process.pid usage with getProcessId method * remove console.log * feat: enable attaching symbols to chat via `@` (microsoft#213347) * feat: enable attaching symbols to chat via `@` * Oop * SCM - add commands to focus previous/next resource group (microsoft#213377) * Initial implementation * 💄 * Fixed issue with focusing outside the tree * Joh/homely-damselfly (microsoft#213376) * chore - `ReplyResponse` cleanup * associate hunk data with response id * Associate hunk data with response state so that accepting hunks updates the text edit group * first cut of moving N-edits conversion from inline chat to panel * don't always consume mouse wheel (microsoft#213383) for chat widget (list) and for chat input editor (actually all simple editor cases) * clean up dead context keys and other dead code (microsoft#213387) * inline chat for notebook cell uses the `Notebook` chat location (microsoft#213385) * inline chat for notebook cell uses the `Notebook` chat location * fix tests * show filename for compare code blocks (microsoft#213389) * check uri when combining edits from different groups (microsoft#213390) * Fix issue microsoft#212877: Use Action context for Multi Diff Editor Actions (microsoft#213293) fix microsoft#212877 * Remove configure inline chat command from menu because it isn't popular at all and takes space (microsoft#213396) also fixes https://github.com/microsoft/vscode-copilot/issues/5662 * Scope custom editor and webview context keys to editor groups and global context (microsoft#213398) Properly scope custom editor and webview context keys * Fix broken codeblocks (microsoft#213399) * Fix broken codeblocks Fix microsoft#213382 * Fix tests * fix microsoft#194105 (microsoft#213403) * Add tests for editor group model (microsoft#213405) * Add test for editor group model * user helper function * web reporter refactor and issueFormService (microsoft#212951) * web version working * change to mainWindow * PROPER MOVEMENT * working for web as well * move issueFormService to workbench/contrib/issue * cleaning up{ * more cleanup, added setting * styling * use mainwindow to open and closee * css fixes * fix css again * fix CSS and wonky applyCSS rules * change gulpfile * add and update system info * address some of the comments * move files! small changes * move JS and non window specific back to electron sandbox * fix on issueReporter.js * fix build file * fix gulp file too.... * move everything into contrib * fix workbench import * move everything else into contrib, fix import * change name to web * applying more feedback fixes :D * fix command and remove unused import: * add back issueTroubleshoot * fix gulpile outputs * fix out exclusion: * Disable web TS type acquisition (microsoft#213412) We're waiting on some perf improvement for upstream types installer before turning this on everywhere * Hook up prototype paste with imports for JS/TS (microsoft#204665) * Hook up prototype paste with imports for JS/TS For microsoft/TypeScript#57262 but with proposed changes to ts protocol * Support new api * Update * issue reporter re-open save state (microsoft#213418) if anything is typed and we call open reporter again, saves issue title and data * provide default settings (microsoft#213419) fix microsoft#213411 * add item label (microsoft#213422) * add item label * update active window label * Add "when" clause to chat participants (microsoft#213425) * Add "when" clause to chat participants Fix microsoft#212447 * Change _agents to a Map and write some tests * Fix import * Change proposal for chat participant "when" clause (microsoft#213427) * Change proposal for chat participant "when" clause * This * feat: add top level `Symbol...` to Attach Context picker (microsoft#213435) * feat: enable attaching symbols to chat via `#` * feat: add `Symbol...` to Attach Context picker * feat: easier keyboard flow for removing chat attachments (microsoft#213436) * ts - enable use code watcher by default (microsoft#213450) * Fix menu computation when compact on right side (microsoft#213459) fix menu computation when compact on right side * Add focus indication for compact menu (microsoft#213463) indicate when compact menu is focused * Debt - dispose child instantiation service (microsoft#213471) * Fix "new chat" before focusing chat panel (microsoft#213478) Fix microsoft#213353 * Sort @workspace /explain above @Terminal /explain (microsoft#213482) Fix microsoft/vscode-copilot-release#1245 This is a bit of a hack but has some advantanges over adding an 'order' field to the chat participant or something like that. We can keep the order the same in other cases except for when the user is typing to filter the / list, then @Terminal slash commands will be pushed down. * Don't show chat agent hover on empty space in header (microsoft#213486) Fix microsoft/vscode-copilot#5271 * chore: update remote node.js (microsoft#213439) * chore: update remote node.js to v20.11.1 * chore: remove io_uring workaround * chore: update checksums * temp: update distro * ci: rebuild cache * chore: bump distro * Working sets - add preserveFocus (microsoft#213397) * Working sets - preserve focus when applying the working set was initiated by an action that was taken in the panel part (ex: switching branches from the terminal) * Pull request feedback * renames and cleanup * renames and cleanup * renames and cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Add "Open in Editor" button for chat history (microsoft#213518) Fix microsoft#213517 * fix microsoft#213526 (microsoft#213527) * fix microsoft#181407 (microsoft#213530) * Remove brackets from comments, strings and regexes before evaluating the indentation (microsoft#210641) * wip * polishing the code * adding code * adding the language * reshuffling the code to avoid cyclic dependency * polihsing code * uncommenting tests * also adopting the indentation rules within the reindentation operation * using instead the sliced line tokens instead of the scoped line tokens * polishing the code * using start indices instead * using value everywhere * using the token data to type the tokens * setting to number instead of standard token type * using token data from autoindenttest.ts * using same code in both test files * placing instantiation service into the registerLanguage method * copying object into the node js autoindent.ts * report new windo profile setting (microsoft#213531) * Add license for deviceid (microsoft#213536) * watcher - add the utility process worker to disposables (microsoft#213538) * Color theme preview not working with "window.systemColorTheme": "auto" (microsoft#213539) * watcher - more `dispose` and remove E15 workaround (microsoft#213540) * Fix comments memory leak (microsoft#213542) Fixes microsoft#213535 * Fix copyright statement (microsoft#213543) * Don't show the gutter menu in the chat diff editor. (microsoft#213546) * Fixes diff editor height issue. (microsoft#213547) Before: Always 100% of parent container. After: Uses passed in dimensions. * Fixes microsoft#209627 (microsoft#213554) * SCM - reveal resource in the source control tree (microsoft#213556) * Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#213557) Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#200091) * Fixes microsoft#209417 (microsoft#213549) * use refs/tags/release for 1espt (microsoft#213558) * debt - fix a few leaking listeners (microsoft#213560) * Ignore indentation rules when interacting with a string (microsoft#210761) * ignore indenation when interacting with a string * changes from discussion * remove the export keyword * adding changes to the PR * removing the console log * adding one more comment * extracting the method which forces the tokenization * Add license URIs for toml_edit and toml_datetime (microsoft#213562) Add licene uri fr toml_edit and toml_datetime * fix microsoft#213563 (microsoft#213564) * report new window profile switch (microsoft#213566) * Fixes microsoft#213573 (microsoft#213574) * fix microsoft#213576 (microsoft#213577) * Add editor.findMatchForeground (microsoft#213497) * feature: make find decoration foreground color configurable * Update license and third party notices (microsoft#213580) * editors - add test for transient group model changes (microsoft#213581) * Fixes microsoft#212771 (microsoft#213584) * Fix an issue where defaultLinesDiffComputer does not pass in the timeout variable (microsoft#213035) Update defaultLinesDiffComputer.ts * fix microsoft#212674 (microsoft#213583) * Fixes diff editor height in monaco editor playground example. (microsoft#213585) * Feat: Bolder Typeface + Configurable Letter Spacing for Minimap's Section Header Labels ✨ (microsoft#209990) * Rendering Section Header Labels with space in between the characters for better readability. * Making Section Headers Bold * Added settings for the Section Header Letter Spacing of the Minimap * a more performant and non-breaking way to render characters * fixed the git problems * add test default value * Allow fine-tuning the letter spacing, minor tweaks --------- Co-authored-by: Alexandru Dima <alexdima@microsoft.com> * Support diff merge editor for Notebooks (microsoft#213602) * Add Search in Cell Selection to Notebook Find Widget (microsoft#213409) * all search scope functionality except cell decorations * fix filter icon showing fake useage * decorations + css tweaking + PR feedback * Adding accessibility help for verbose hover (microsoft#212783) * adding code in order to provide accessibility help for the hover * adding the description of the possible commands that can be used * reusing the method * joining the content and changing the text in the help view * polishing the code * removing the question mark * changing the import * removing the setting ID from imports * adding code in order to update when the hover updates * adding methods to service * adding code in order to dispose the accessible hover view * fixing bug * polishing the code * checking that action not supported for the early return * using disposable store instead * using the appropriate string * polishing the code * using instead the type help and the resolved keybindings * hiding also on the `onDidBlurEditorWidget` firing * Revert "using instead the type help and the resolved keybindings" This reverts commit 1f450dd. * use hover accessible view, provide custom help * Revert "Revert "using instead the type help and the resolved keybindings"" This reverts commit 12f0cf6. * add HoverAccessibilityHelp, BaseHoverAccessibleViewProvider * polishing the code * polishing the code * provide content at a specific index from the hover accessibility help provider * introducing method _initializeOptions * using readonly where possible * using public everywhere * using a getter for the actions --------- Co-authored-by: meganrogge <megan.rogge@microsoft.com> * Add more info to comment range error (microsoft#213578) Part of microsoft#213243 * Bump postcss from 7.0.39 to 8.4.38 (microsoft#209857) Bumps [postcss](https://github.com/postcss/postcss) from 7.0.39 to 8.4.38. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.39...8.4.38) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: dispose template data disposables in source column renderer (microsoft#202618) * fixes regression: adding a `isCheapToTokenize` check before tokenizing the line (microsoft#213674) adding a check on how it is cheap to tokenize the lines * fix windows terminal hint not showing up (microsoft#213695) fix microsoft#213693 * Missing server node module (microsoft#213712) * Fix hover padding regression (microsoft#213700) * Fix textPreformatForeground for HC themes (microsoft#213698) * Fix js/ts cross code block intellisense (microsoft#213726) We need to register support for the backing copilot scheme too, not just the panel scheme in core * Fix vscode-api-tests in stable (microsoft#213733) * debug: bump js-debug for 1.90 (microsoft#213735) * fix: render ranges for attached selections in chat (microsoft#213741) * fix accessible view kb quickpick not showing (microsoft#213745) * fix: set aria label for chat context attachments (microsoft#213747) * web issue reporter styles (microsoft#213751) remove mac from tag * defaults web issue report false and disable in Firefox (microsoft#213752) * turn off in release and in ff * update * remove global enablement message (microsoft#213128) * editors - clarify `window.restoreWindows` setting further (microsoft#213771) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) (microsoft#213776) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) * simplify * aux window - support Firefox (microsoft#213769) * aux window - support Firefox * add more * only use workaround for FF * enable issue repoter again * . * fix microsoft#212208 (microsoft#213779) * Make rest of terminal initial hint italic Part of microsoft#213647 * Align colors of terminal hint with editor * Use pointer cursor for whole terminal initial hint Fixes microsoft/vscode-copilot#5963 * unwrap `LanguageModelError` when invoking chat participant (microsoft#213784) re microsoft#213710 * fix https://github.com/microsoft/vscode-copilot/issues/5814 (microsoft#213787) * fixes https://github.com/microsoft/vscode-copilot/issues/5908 (microsoft#213788) * fixes microsoft#213644 (microsoft#213789) * fix microsoft#213614 (microsoft#213791) * SCM - all calls from extHostSCM to mainThreadSCM should use a sequencer to ensure that the source control object is created (microsoft#213792) * Fix multi selected tab close behavior (microsoft#213794) fix microsoft#213620 * fix microsoft#196351 (microsoft#213796) * Cannot read properties of undefined (reading 'layout') (microsoft#213797) Fixes microsoft#212235 * fix microsoft#211965 (microsoft#213801) * fix: remove temp dir if extension is installed by another source (microsoft#213379) * closing out inline chat while speech is going does not stop audio (fix microsoft#213709) (microsoft#213802) * No text to speech when a change is applied (fix microsoft#213667) (microsoft#213804) * Regression: Unsaved comment reply lost when changing editors (microsoft#213805) Fixes microsoft#213144 * Voice dictation shortcut (fix microsoft#206800) (microsoft#213806) * Enable initialHint when not stable for now Part of microsoft#213647 * fix leaking listener (microsoft#213816) re microsoft#213141 * fix: setting labels appearing in widgets (microsoft#213826) * Connor4312/issue211378 (microsoft#213829) cli: fix inverted condition not showing warning correctly Fixes microsoft#211378 * doc updates & fixes for chat/lm API (microsoft#213777) * workaround @link not working * fixes microsoft#213630 * Retain previous quick pick navigation behavior with Home and End (microsoft#213832) Fixes microsoft#213739 * Fix microsoft#213525. Move nb chat variable to service (microsoft#213835) * Added redirect * Deleted build * Added submodule * Added symlinking * Added progress * Added script progress * Added attempt to fixx packaging * Added fresh install * Changed back to code.sh * Changed name * fix: hide Attach Context for quick chat (microsoft#213841) * Hook up notebook format code action to format notebook command (microsoft#213847) hook format codeaction to format notebook command * Added extHostChatAgents2.ts * Added contributing * Add setup scripts for different environments (#87) * Add setup scripts for for cross enviroments * add calls to vscode build scripts * update function naming * reduce DRY code in setup scripts * remove old link & update gitignore --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> Co-authored-by: Benjamin Christopher Simmonds <44439583+benibenj@users.noreply.github.com> Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Connor Peet <connor@peet.io> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: Joyce Er <joyce.er@microsoft.com> Co-authored-by: Joyce Er <joyceerhl@gmail.com> Co-authored-by: Isidor Nikolic <inikolic@microsoft.com> Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com> Co-authored-by: Walker Boyle <wboyle13@gmail.com> Co-authored-by: Matt Bierner <matb@microsoft.com> Co-authored-by: David Dossett <ddossett@microsoft.com> Co-authored-by: Aaron Munger <aamunger@microsoft.com> Co-authored-by: Peng Lyu <penn.lv@gmail.com> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: Alexandru Dima <alexdima@microsoft.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: João Moreno <joao.moreno@microsoft.com> Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com> Co-authored-by: Alex Ross <alros@microsoft.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Simon Siefke <simon.siefke@gmail.com> Co-authored-by: Hanning Gong (Charles) <charles.gong@databricks.com> Co-authored-by: Pouya Kary ✨ <kary@gnu.org> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Michael Lively <milively@microsoft.com> Co-authored-by: meganrogge <megan.rogge@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shoham Ben Shitrit <91195275+bsShoham@users.noreply.github.com> Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Co-authored-by: Yesterday17 <mmf@mmf.moe> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> Co-authored-by: Nathan A <nang@Nathans-MacBook-Pro-8.local> Co-authored-by: Ender <endergamingfilms@gmail.com>

@workspace

* Limit image width in chat (microsoft#213021) * Make sure child instantiation service instances are disposed/tracked for disposal (microsoft#212879) (microsoft#213002) * voice - limit `Escape` key to context key scopes (might help for microsoft#213017) (microsoft#213049) * Cleanup editor group context keys (microsoft#212955) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * chore: bump electron@29.4.0 (microsoft#213050) * chore: bump electron@29.4.0 * chore: remove io_uring workaround * chore: bump distro * chore: update dialog result for canceled save dialogs Refs electron/electron@fe01ed7 * chore: add back io_uring workaround for remote oss tests * chore: update nodejs v20.9.0 build * chore: add back io_uring workaround for remote tests * chore: update CLI dependences, add env var options for login * if no selected items, return to accessibility help dialog (microsoft#213075) * provider keyboard users with hover actions (microsoft#213077) * feat: allow ➡️ to add chat context in background (microsoft#213078) * eng: fix prelaunch task on recent node versions Closes microsoft#212888 * fix: limit width of chat attachment widgets * eng: fix off-by-1 error in selfhost test error messages (microsoft#213081) Fixes microsoft#212808 * Fix chat welcome message tooltip (microsoft#213084) * fix a few accessible view bugs (microsoft#213097) * Respect isSlow for chat attachments (microsoft#213105) * strip markdown from chat accessible view, maintain code block nav functionality (microsoft#213096) * resolve accessibility help dialog kbs in `accessibleViewService` (microsoft#213107) * feat: support dynamic variables in chat context picker * Fix misaligned jsdoc * Fix shared input history between chat locations (microsoft#213111) Fix microsoft/vscode-copilot-release#1228 * Fix merging chat anchors in markdown content (microsoft#213114) * Fix merging multiple chat anchors inside markdown content * Simplify types * Fix tests * make sure to push an undo stop after each request (microsoft#213137) fixes https://github.com/microsoft/vscode-copilot/issues/5736 * adjust max input part height for compact chat widget, keep input height separate when compute minHeight (microsoft#213139) fixes https://github.com/microsoft/vscode-copilot/issues/5707 * chore - inline chat controller tests works without agents only (no more glue provider-agent) (microsoft#213151) * Tabs Multi Select Polish (microsoft#212930) * Tabs Multi Select Polish * 💄 * add todo * add todo * update * 💄 * 💄 * 💄 * more review * 💄 * 💄 * fix bad function call * remove todo * jsdoc * 💄 * fix typo * 💄 * 💄 * 💄 multiEditorTabs * model accepts multiple editors * Use setSelection() * fix tests * 💄 * 💄 * discussion * discussion * fix selection * typo --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * remove bridge agents and agent providers because inline chat is all participants now * remove much of IInlineChatSessionProvider * deprecate IInlineChatService and move most consumers off * undo cell diag changes * fix: tsserver no longer crashes when log path includes spaces (microsoft#212752) * Treat normal markdown links as a single token for progressive chat rendering (microsoft#213091) Fixes our progressive chat renderer breaking up any markdown links that contain `-` or a space character. Doesn't support all the fancy markdown link syntaxes, just basic links for now * Pick up latest ts for building VS Code (microsoft#213170) * feat: allow extensions to attach chat context (microsoft#213172) * feat: allow extensions to attach chat context * fix: allow attaching different ranges from same file * fix: restore accepting files from picker * Use `resolveContentAndKeybindingItems` for diff editor, accessible view, and terminal (microsoft#213179) * Use `ChatAgentService` instead of `InlineChatService` for terminal chat hint (microsoft#213183) fix microsoft#213159 * Tweak confirmations pading * Properly handle errors thrown from renderer while invoking the chat agent (microsoft#213080) * Properly handle errors thrown from renderer while invoking the chat agent If we throw out of ChatService, then the request can't be canceled and stays "generating" forever * Update snapshot * Save on EH diagnostics (microsoft#213171) * added trace logs * another trace message * fix test ctors * remove test logs (microsoft#213188) * testing: exploratory UI for followup actions This adds an API that extensions can use to contribute 'followup' actions around test messages. Here just a dummy hello world using copilot, but extensions could have any action here, such as actions to update snapshots if a test failed: ![](https://memes.peet.io/img/24-05-c1f3e073-a2da-4f16-a033-c8f7e5cd4864.png) Implemented using a simple provider API. * Notebook Chat Controller does not need use agent directly * Hack to get it working * feat: persist chat attachments in history * Fix "open chat in editor" (microsoft#213198) Fix microsoft/vscode-copilot-release#1233 * chore - remove dead/stale commands (microsoft#213207) * chore - write error message so that it doesn't get confused as file path (microsoft#213210) * Perf: visualise memory efficiency (microsoft#211837) (microsoft#213208) * Perf: visualise memory efficiency (microsoft#211837) * feat: add telemetry logging for startup heap statistics * fix compile * feat: add used heap size to startup performance telemetry * refactor: remove allocated heap size from startup performance telemetry * comments * debt - some multi-tabs select cleanup (microsoft#213161) * chore: update deps for linux x64 client (microsoft#213221) chore: update linux client dependencies * editors - fix context on `EDITOR_CLOSE` (microsoft#213223) * SCM - add command to focus input (microsoft#213225) * allow customizing accessibility signal delays (microsoft#212834) * fix: set `id` and `name` for files in chat context * Disable VS Code file watching for yarn pnp (microsoft#213238) Disable VS Code file watching on yarn pnp * Enable roaming of inflight chat requests (microsoft#213239) This enables to remove the special handling for `/explain` - fixes https://github.com/microsoft/vscode-copilot/issues/2192 - fixes microsoft#208706 because inline chat now closes on "view in chat" - fixes https://github.com/microsoft/vscode-copilot/issues/5288 * Add VS device id (microsoft#213231) * NotebookChatController still manages ChatModel * Don't register chat participants in stable (microsoft#213244) * Don't register chat participants in stable And fork some Additions APIs into chatParticipantPrivate * Remove stale proposals * Move more API out of Additions * Start session when notebook chat widget is created * Implement Profiles Editor (microsoft#213246) * first cut * second cut * fix * add more features * support skipping copying resources while creating * enable behind internal setting * testing: polish followups a little, selfhost with copilot * Update for latest code mapper proposal (microsoft#213256) * Remove notebook chat menu * Rename vsDeviceId (microsoft#213261) * polish profiles editor (microsoft#213262) * refactor: clean up chat context types (microsoft#213264) * fix: prevent attaching the same chat context twice (microsoft#213266) * Bump distro (microsoft#213268) * more polish (microsoft#213267) * more polish * refactor actions * fix hover * Prevent using disposed of timers (microsoft#213271) * Prevent using disposed of timers If a timer has been disposed of, warn and don't schedule the callback. This is needed as otherwise the timer very likely ends up being leaked * Throw errors instead * Fix microsoft#213206. Migrate off IInlineChatService (microsoft#213263) * Fix microsoft#213206. Migrate off IInlineChatService * fix tests * Fix leaking uponSanitizeElement hook (microsoft#213277) * Tweak agent hover (microsoft#213278) "View in Marketplace" seems to be confusing people * Fix fillInIncompleteTokens for ordered lists (microsoft#213280) * fix: apply query filter to `additionPicks` (microsoft#213281) * Fix StableEditorBottomScrollState (microsoft#212970) * False positive "saving too long" dialog hindering saving a file (fix microsoft/vscode-internalbacklog#4943) (microsoft#213290) * Remove tree view show hover (microsoft#213212) * remove `IInlineChatService` and types around it (microsoft#213298) * increase listener refusal threshold significantly (microsoft#213292) * increase listener refusal threshold significantly * fix tests * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts (microsoft#213301) * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts * fix compiler * Polish the code that sets env in packageJSONContribution.ts (microsoft#213306) * fix this reference in instantiation service (microsoft#213311) * Fix unsafe type assertions on object literals (microsoft#213318) * Benibenj/registerContextKeyHandler (microsoft#213135) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup * first draft contexkt key registration * Make it a provider * Use group instead of active editor * getGroupContextKeyValue * doc * Fix merge error * 💄 --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * allow returning undefined if file was not saved (microsoft#213123) * allow returning undefined if file was not saved * bring back cancellation check * helper utility to convey optional result if cancelled * edit * inline function * test cancelled custom save * inline more --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Fix codicons padding in chat attachments * git: allow querying whether files are gitignore (microsoft#212982) * git: allow querying whether files are gitignore This exposes `checkIgnore`, which I want to use in copilot to determine which files I should go into when checking references. * rename method * Making API `editorHoverVerbosityLevel` use `verbosityLevel` instead of `action` (microsoft#213317) * allowing to cancel a previous request and jump directly to a request for a delta at a higher level * adding code in order to dispose the token sources when the full object is disposed * Fix issue with Cmd+W closing the window with opened tabs (microsoft#213335) fixes microsoft#213324 * Render html as plaintext when html not supported (microsoft#213265) * Support rendering unsupported html tags as plaintext for chat * Render html as plaintext when html not supported * Add comment and test for trusted domains * code action and lightbulb telemetry updates (microsoft#212929) * added additional telemetry and remove unused telemetry event * removed unused imports * Bump distro (microsoft#213340) * Part of microsoft#211878 (microsoft#212902) * SCM - add commands to focus next/previous input (microsoft#213337) * SCM - refactor commands to focus input * Ensure that the input node is expanded in the tree * getParent() should handle expanding the repository node * Use ArrayNavigator instead * Add support for looping in the array navigator * 💄 * use rot instead of array navigator * 💄 * more 💄 --------- Co-authored-by: João Moreno <joao.moreno@microsoft.com> * SCM - getParent() should handle resource groups (microsoft#213350) * refactor: replace direct process.pid usage with getProcessId method (microsoft#213352) * refactor: replace direct process.pid usage with getProcessId method * remove console.log * feat: enable attaching symbols to chat via `@` (microsoft#213347) * feat: enable attaching symbols to chat via `@` * Oop * SCM - add commands to focus previous/next resource group (microsoft#213377) * Initial implementation * 💄 * Fixed issue with focusing outside the tree * Joh/homely-damselfly (microsoft#213376) * chore - `ReplyResponse` cleanup * associate hunk data with response id * Associate hunk data with response state so that accepting hunks updates the text edit group * first cut of moving N-edits conversion from inline chat to panel * don't always consume mouse wheel (microsoft#213383) for chat widget (list) and for chat input editor (actually all simple editor cases) * clean up dead context keys and other dead code (microsoft#213387) * inline chat for notebook cell uses the `Notebook` chat location (microsoft#213385) * inline chat for notebook cell uses the `Notebook` chat location * fix tests * show filename for compare code blocks (microsoft#213389) * check uri when combining edits from different groups (microsoft#213390) * Fix issue microsoft#212877: Use Action context for Multi Diff Editor Actions (microsoft#213293) fix microsoft#212877 * Remove configure inline chat command from menu because it isn't popular at all and takes space (microsoft#213396) also fixes https://github.com/microsoft/vscode-copilot/issues/5662 * Scope custom editor and webview context keys to editor groups and global context (microsoft#213398) Properly scope custom editor and webview context keys * Fix broken codeblocks (microsoft#213399) * Fix broken codeblocks Fix microsoft#213382 * Fix tests * fix microsoft#194105 (microsoft#213403) * Add tests for editor group model (microsoft#213405) * Add test for editor group model * user helper function * web reporter refactor and issueFormService (microsoft#212951) * web version working * change to mainWindow * PROPER MOVEMENT * working for web as well * move issueFormService to workbench/contrib/issue * cleaning up{ * more cleanup, added setting * styling * use mainwindow to open and closee * css fixes * fix css again * fix CSS and wonky applyCSS rules * change gulpfile * add and update system info * address some of the comments * move files! small changes * move JS and non window specific back to electron sandbox * fix on issueReporter.js * fix build file * fix gulp file too.... * move everything into contrib * fix workbench import * move everything else into contrib, fix import * change name to web * applying more feedback fixes :D * fix command and remove unused import: * add back issueTroubleshoot * fix gulpile outputs * fix out exclusion: * Disable web TS type acquisition (microsoft#213412) We're waiting on some perf improvement for upstream types installer before turning this on everywhere * Hook up prototype paste with imports for JS/TS (microsoft#204665) * Hook up prototype paste with imports for JS/TS For microsoft/TypeScript#57262 but with proposed changes to ts protocol * Support new api * Update * issue reporter re-open save state (microsoft#213418) if anything is typed and we call open reporter again, saves issue title and data * provide default settings (microsoft#213419) fix microsoft#213411 * add item label (microsoft#213422) * add item label * update active window label * Add "when" clause to chat participants (microsoft#213425) * Add "when" clause to chat participants Fix microsoft#212447 * Change _agents to a Map and write some tests * Fix import * Change proposal for chat participant "when" clause (microsoft#213427) * Change proposal for chat participant "when" clause * This * feat: add top level `Symbol...` to Attach Context picker (microsoft#213435) * feat: enable attaching symbols to chat via `#` * feat: add `Symbol...` to Attach Context picker * feat: easier keyboard flow for removing chat attachments (microsoft#213436) * ts - enable use code watcher by default (microsoft#213450) * Fix menu computation when compact on right side (microsoft#213459) fix menu computation when compact on right side * Add focus indication for compact menu (microsoft#213463) indicate when compact menu is focused * Debt - dispose child instantiation service (microsoft#213471) * Fix "new chat" before focusing chat panel (microsoft#213478) Fix microsoft#213353 * Sort @workspace /explain above @Terminal /explain (microsoft#213482) Fix microsoft/vscode-copilot-release#1245 This is a bit of a hack but has some advantanges over adding an 'order' field to the chat participant or something like that. We can keep the order the same in other cases except for when the user is typing to filter the / list, then @Terminal slash commands will be pushed down. * Don't show chat agent hover on empty space in header (microsoft#213486) Fix microsoft/vscode-copilot#5271 * chore: update remote node.js (microsoft#213439) * chore: update remote node.js to v20.11.1 * chore: remove io_uring workaround * chore: update checksums * temp: update distro * ci: rebuild cache * chore: bump distro * Working sets - add preserveFocus (microsoft#213397) * Working sets - preserve focus when applying the working set was initiated by an action that was taken in the panel part (ex: switching branches from the terminal) * Pull request feedback * renames and cleanup * renames and cleanup * renames and cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Add "Open in Editor" button for chat history (microsoft#213518) Fix microsoft#213517 * fix microsoft#213526 (microsoft#213527) * fix microsoft#181407 (microsoft#213530) * Remove brackets from comments, strings and regexes before evaluating the indentation (microsoft#210641) * wip * polishing the code * adding code * adding the language * reshuffling the code to avoid cyclic dependency * polihsing code * uncommenting tests * also adopting the indentation rules within the reindentation operation * using instead the sliced line tokens instead of the scoped line tokens * polishing the code * using start indices instead * using value everywhere * using the token data to type the tokens * setting to number instead of standard token type * using token data from autoindenttest.ts * using same code in both test files * placing instantiation service into the registerLanguage method * copying object into the node js autoindent.ts * report new windo profile setting (microsoft#213531) * Add license for deviceid (microsoft#213536) * watcher - add the utility process worker to disposables (microsoft#213538) * Color theme preview not working with "window.systemColorTheme": "auto" (microsoft#213539) * watcher - more `dispose` and remove E15 workaround (microsoft#213540) * Fix comments memory leak (microsoft#213542) Fixes microsoft#213535 * Fix copyright statement (microsoft#213543) * Don't show the gutter menu in the chat diff editor. (microsoft#213546) * Fixes diff editor height issue. (microsoft#213547) Before: Always 100% of parent container. After: Uses passed in dimensions. * Fixes microsoft#209627 (microsoft#213554) * SCM - reveal resource in the source control tree (microsoft#213556) * Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#213557) Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#200091) * Fixes microsoft#209417 (microsoft#213549) * use refs/tags/release for 1espt (microsoft#213558) * debt - fix a few leaking listeners (microsoft#213560) * Ignore indentation rules when interacting with a string (microsoft#210761) * ignore indenation when interacting with a string * changes from discussion * remove the export keyword * adding changes to the PR * removing the console log * adding one more comment * extracting the method which forces the tokenization * Add license URIs for toml_edit and toml_datetime (microsoft#213562) Add licene uri fr toml_edit and toml_datetime * fix microsoft#213563 (microsoft#213564) * report new window profile switch (microsoft#213566) * Fixes microsoft#213573 (microsoft#213574) * fix microsoft#213576 (microsoft#213577) * Add editor.findMatchForeground (microsoft#213497) * feature: make find decoration foreground color configurable * Update license and third party notices (microsoft#213580) * editors - add test for transient group model changes (microsoft#213581) * Fixes microsoft#212771 (microsoft#213584) * Fix an issue where defaultLinesDiffComputer does not pass in the timeout variable (microsoft#213035) Update defaultLinesDiffComputer.ts * fix microsoft#212674 (microsoft#213583) * Fixes diff editor height in monaco editor playground example. (microsoft#213585) * Feat: Bolder Typeface + Configurable Letter Spacing for Minimap's Section Header Labels ✨ (microsoft#209990) * Rendering Section Header Labels with space in between the characters for better readability. * Making Section Headers Bold * Added settings for the Section Header Letter Spacing of the Minimap * a more performant and non-breaking way to render characters * fixed the git problems * add test default value * Allow fine-tuning the letter spacing, minor tweaks --------- Co-authored-by: Alexandru Dima <alexdima@microsoft.com> * Support diff merge editor for Notebooks (microsoft#213602) * Add Search in Cell Selection to Notebook Find Widget (microsoft#213409) * all search scope functionality except cell decorations * fix filter icon showing fake useage * decorations + css tweaking + PR feedback * Adding accessibility help for verbose hover (microsoft#212783) * adding code in order to provide accessibility help for the hover * adding the description of the possible commands that can be used * reusing the method * joining the content and changing the text in the help view * polishing the code * removing the question mark * changing the import * removing the setting ID from imports * adding code in order to update when the hover updates * adding methods to service * adding code in order to dispose the accessible hover view * fixing bug * polishing the code * checking that action not supported for the early return * using disposable store instead * using the appropriate string * polishing the code * using instead the type help and the resolved keybindings * hiding also on the `onDidBlurEditorWidget` firing * Revert "using instead the type help and the resolved keybindings" This reverts commit 1f450dd. * use hover accessible view, provide custom help * Revert "Revert "using instead the type help and the resolved keybindings"" This reverts commit 12f0cf6. * add HoverAccessibilityHelp, BaseHoverAccessibleViewProvider * polishing the code * polishing the code * provide content at a specific index from the hover accessibility help provider * introducing method _initializeOptions * using readonly where possible * using public everywhere * using a getter for the actions --------- Co-authored-by: meganrogge <megan.rogge@microsoft.com> * Add more info to comment range error (microsoft#213578) Part of microsoft#213243 * Bump postcss from 7.0.39 to 8.4.38 (microsoft#209857) Bumps [postcss](https://github.com/postcss/postcss) from 7.0.39 to 8.4.38. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.39...8.4.38) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: dispose template data disposables in source column renderer (microsoft#202618) * fixes regression: adding a `isCheapToTokenize` check before tokenizing the line (microsoft#213674) adding a check on how it is cheap to tokenize the lines * fix windows terminal hint not showing up (microsoft#213695) fix microsoft#213693 * Missing server node module (microsoft#213712) * Fix hover padding regression (microsoft#213700) * Fix textPreformatForeground for HC themes (microsoft#213698) * Fix js/ts cross code block intellisense (microsoft#213726) We need to register support for the backing copilot scheme too, not just the panel scheme in core * Fix vscode-api-tests in stable (microsoft#213733) * debug: bump js-debug for 1.90 (microsoft#213735) * fix: render ranges for attached selections in chat (microsoft#213741) * fix accessible view kb quickpick not showing (microsoft#213745) * fix: set aria label for chat context attachments (microsoft#213747) * web issue reporter styles (microsoft#213751) remove mac from tag * defaults web issue report false and disable in Firefox (microsoft#213752) * turn off in release and in ff * update * remove global enablement message (microsoft#213128) * editors - clarify `window.restoreWindows` setting further (microsoft#213771) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) (microsoft#213776) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) * simplify * aux window - support Firefox (microsoft#213769) * aux window - support Firefox * add more * only use workaround for FF * enable issue repoter again * . * fix microsoft#212208 (microsoft#213779) * Make rest of terminal initial hint italic Part of microsoft#213647 * Align colors of terminal hint with editor * Use pointer cursor for whole terminal initial hint Fixes microsoft/vscode-copilot#5963 * unwrap `LanguageModelError` when invoking chat participant (microsoft#213784) re microsoft#213710 * fix https://github.com/microsoft/vscode-copilot/issues/5814 (microsoft#213787) * fixes https://github.com/microsoft/vscode-copilot/issues/5908 (microsoft#213788) * fixes microsoft#213644 (microsoft#213789) * fix microsoft#213614 (microsoft#213791) * SCM - all calls from extHostSCM to mainThreadSCM should use a sequencer to ensure that the source control object is created (microsoft#213792) * Fix multi selected tab close behavior (microsoft#213794) fix microsoft#213620 * fix microsoft#196351 (microsoft#213796) * Cannot read properties of undefined (reading 'layout') (microsoft#213797) Fixes microsoft#212235 * fix microsoft#211965 (microsoft#213801) * fix: remove temp dir if extension is installed by another source (microsoft#213379) * closing out inline chat while speech is going does not stop audio (fix microsoft#213709) (microsoft#213802) * No text to speech when a change is applied (fix microsoft#213667) (microsoft#213804) * Regression: Unsaved comment reply lost when changing editors (microsoft#213805) Fixes microsoft#213144 * Voice dictation shortcut (fix microsoft#206800) (microsoft#213806) * Enable initialHint when not stable for now Part of microsoft#213647 * fix leaking listener (microsoft#213816) re microsoft#213141 * fix: setting labels appearing in widgets (microsoft#213826) * Connor4312/issue211378 (microsoft#213829) cli: fix inverted condition not showing warning correctly Fixes microsoft#211378 * doc updates & fixes for chat/lm API (microsoft#213777) * workaround @link not working * fixes microsoft#213630 * Retain previous quick pick navigation behavior with Home and End (microsoft#213832) Fixes microsoft#213739 * Fix microsoft#213525. Move nb chat variable to service (microsoft#213835) * Added redirect * Deleted build * Added submodule * Added symlinking * Added progress * Added script progress * Added attempt to fixx packaging * Added fresh install * Changed back to code.sh * Changed name * fix: hide Attach Context for quick chat (microsoft#213841) * Hook up notebook format code action to format notebook command (microsoft#213847) hook format codeaction to format notebook command * Added extHostChatAgents2.ts * Added contributing * Add setup scripts for different environments (#87) * Add setup scripts for for cross enviroments * add calls to vscode build scripts * update function naming * reduce DRY code in setup scripts * remove old link & update gitignore --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> Co-authored-by: Benjamin Christopher Simmonds <44439583+benibenj@users.noreply.github.com> Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Connor Peet <connor@peet.io> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: Joyce Er <joyce.er@microsoft.com> Co-authored-by: Joyce Er <joyceerhl@gmail.com> Co-authored-by: Isidor Nikolic <inikolic@microsoft.com> Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com> Co-authored-by: Walker Boyle <wboyle13@gmail.com> Co-authored-by: Matt Bierner <matb@microsoft.com> Co-authored-by: David Dossett <ddossett@microsoft.com> Co-authored-by: Aaron Munger <aamunger@microsoft.com> Co-authored-by: Peng Lyu <penn.lv@gmail.com> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: Alexandru Dima <alexdima@microsoft.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: João Moreno <joao.moreno@microsoft.com> Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com> Co-authored-by: Alex Ross <alros@microsoft.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Simon Siefke <simon.siefke@gmail.com> Co-authored-by: Hanning Gong (Charles) <charles.gong@databricks.com> Co-authored-by: Pouya Kary ✨ <kary@gnu.org> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Michael Lively <milively@microsoft.com> Co-authored-by: meganrogge <megan.rogge@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shoham Ben Shitrit <91195275+bsShoham@users.noreply.github.com> Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Co-authored-by: Yesterday17 <mmf@mmf.moe> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> Co-authored-by: Nathan A <nang@Nathans-MacBook-Pro-8.local> Co-authored-by: Ender <endergamingfilms@gmail.com>

@workspace

* Limit image width in chat (microsoft#213021) * Make sure child instantiation service instances are disposed/tracked for disposal (microsoft#212879) (microsoft#213002) * voice - limit `Escape` key to context key scopes (might help for microsoft#213017) (microsoft#213049) * Cleanup editor group context keys (microsoft#212955) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * chore: bump electron@29.4.0 (microsoft#213050) * chore: bump electron@29.4.0 * chore: remove io_uring workaround * chore: bump distro * chore: update dialog result for canceled save dialogs Refs electron/electron@fe01ed7 * chore: add back io_uring workaround for remote oss tests * chore: update nodejs v20.9.0 build * chore: add back io_uring workaround for remote tests * chore: update CLI dependences, add env var options for login * if no selected items, return to accessibility help dialog (microsoft#213075) * provider keyboard users with hover actions (microsoft#213077) * feat: allow ➡️ to add chat context in background (microsoft#213078) * eng: fix prelaunch task on recent node versions Closes microsoft#212888 * fix: limit width of chat attachment widgets * eng: fix off-by-1 error in selfhost test error messages (microsoft#213081) Fixes microsoft#212808 * Fix chat welcome message tooltip (microsoft#213084) * fix a few accessible view bugs (microsoft#213097) * Respect isSlow for chat attachments (microsoft#213105) * strip markdown from chat accessible view, maintain code block nav functionality (microsoft#213096) * resolve accessibility help dialog kbs in `accessibleViewService` (microsoft#213107) * feat: support dynamic variables in chat context picker * Fix misaligned jsdoc * Fix shared input history between chat locations (microsoft#213111) Fix microsoft/vscode-copilot-release#1228 * Fix merging chat anchors in markdown content (microsoft#213114) * Fix merging multiple chat anchors inside markdown content * Simplify types * Fix tests * make sure to push an undo stop after each request (microsoft#213137) fixes https://github.com/microsoft/vscode-copilot/issues/5736 * adjust max input part height for compact chat widget, keep input height separate when compute minHeight (microsoft#213139) fixes https://github.com/microsoft/vscode-copilot/issues/5707 * chore - inline chat controller tests works without agents only (no more glue provider-agent) (microsoft#213151) * Tabs Multi Select Polish (microsoft#212930) * Tabs Multi Select Polish * 💄 * add todo * add todo * update * 💄 * 💄 * 💄 * more review * 💄 * 💄 * fix bad function call * remove todo * jsdoc * 💄 * fix typo * 💄 * 💄 * 💄 multiEditorTabs * model accepts multiple editors * Use setSelection() * fix tests * 💄 * 💄 * discussion * discussion * fix selection * typo --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * remove bridge agents and agent providers because inline chat is all participants now * remove much of IInlineChatSessionProvider * deprecate IInlineChatService and move most consumers off * undo cell diag changes * fix: tsserver no longer crashes when log path includes spaces (microsoft#212752) * Treat normal markdown links as a single token for progressive chat rendering (microsoft#213091) Fixes our progressive chat renderer breaking up any markdown links that contain `-` or a space character. Doesn't support all the fancy markdown link syntaxes, just basic links for now * Pick up latest ts for building VS Code (microsoft#213170) * feat: allow extensions to attach chat context (microsoft#213172) * feat: allow extensions to attach chat context * fix: allow attaching different ranges from same file * fix: restore accepting files from picker * Use `resolveContentAndKeybindingItems` for diff editor, accessible view, and terminal (microsoft#213179) * Use `ChatAgentService` instead of `InlineChatService` for terminal chat hint (microsoft#213183) fix microsoft#213159 * Tweak confirmations pading * Properly handle errors thrown from renderer while invoking the chat agent (microsoft#213080) * Properly handle errors thrown from renderer while invoking the chat agent If we throw out of ChatService, then the request can't be canceled and stays "generating" forever * Update snapshot * Save on EH diagnostics (microsoft#213171) * added trace logs * another trace message * fix test ctors * remove test logs (microsoft#213188) * testing: exploratory UI for followup actions This adds an API that extensions can use to contribute 'followup' actions around test messages. Here just a dummy hello world using copilot, but extensions could have any action here, such as actions to update snapshots if a test failed: ![](https://memes.peet.io/img/24-05-c1f3e073-a2da-4f16-a033-c8f7e5cd4864.png) Implemented using a simple provider API. * Notebook Chat Controller does not need use agent directly * Hack to get it working * feat: persist chat attachments in history * Fix "open chat in editor" (microsoft#213198) Fix microsoft/vscode-copilot-release#1233 * chore - remove dead/stale commands (microsoft#213207) * chore - write error message so that it doesn't get confused as file path (microsoft#213210) * Perf: visualise memory efficiency (microsoft#211837) (microsoft#213208) * Perf: visualise memory efficiency (microsoft#211837) * feat: add telemetry logging for startup heap statistics * fix compile * feat: add used heap size to startup performance telemetry * refactor: remove allocated heap size from startup performance telemetry * comments * debt - some multi-tabs select cleanup (microsoft#213161) * chore: update deps for linux x64 client (microsoft#213221) chore: update linux client dependencies * editors - fix context on `EDITOR_CLOSE` (microsoft#213223) * SCM - add command to focus input (microsoft#213225) * allow customizing accessibility signal delays (microsoft#212834) * fix: set `id` and `name` for files in chat context * Disable VS Code file watching for yarn pnp (microsoft#213238) Disable VS Code file watching on yarn pnp * Enable roaming of inflight chat requests (microsoft#213239) This enables to remove the special handling for `/explain` - fixes https://github.com/microsoft/vscode-copilot/issues/2192 - fixes microsoft#208706 because inline chat now closes on "view in chat" - fixes https://github.com/microsoft/vscode-copilot/issues/5288 * Add VS device id (microsoft#213231) * NotebookChatController still manages ChatModel * Don't register chat participants in stable (microsoft#213244) * Don't register chat participants in stable And fork some Additions APIs into chatParticipantPrivate * Remove stale proposals * Move more API out of Additions * Start session when notebook chat widget is created * Implement Profiles Editor (microsoft#213246) * first cut * second cut * fix * add more features * support skipping copying resources while creating * enable behind internal setting * testing: polish followups a little, selfhost with copilot * Update for latest code mapper proposal (microsoft#213256) * Remove notebook chat menu * Rename vsDeviceId (microsoft#213261) * polish profiles editor (microsoft#213262) * refactor: clean up chat context types (microsoft#213264) * fix: prevent attaching the same chat context twice (microsoft#213266) * Bump distro (microsoft#213268) * more polish (microsoft#213267) * more polish * refactor actions * fix hover * Prevent using disposed of timers (microsoft#213271) * Prevent using disposed of timers If a timer has been disposed of, warn and don't schedule the callback. This is needed as otherwise the timer very likely ends up being leaked * Throw errors instead * Fix microsoft#213206. Migrate off IInlineChatService (microsoft#213263) * Fix microsoft#213206. Migrate off IInlineChatService * fix tests * Fix leaking uponSanitizeElement hook (microsoft#213277) * Tweak agent hover (microsoft#213278) "View in Marketplace" seems to be confusing people * Fix fillInIncompleteTokens for ordered lists (microsoft#213280) * fix: apply query filter to `additionPicks` (microsoft#213281) * Fix StableEditorBottomScrollState (microsoft#212970) * False positive "saving too long" dialog hindering saving a file (fix microsoft/vscode-internalbacklog#4943) (microsoft#213290) * Remove tree view show hover (microsoft#213212) * remove `IInlineChatService` and types around it (microsoft#213298) * increase listener refusal threshold significantly (microsoft#213292) * increase listener refusal threshold significantly * fix tests * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts (microsoft#213301) * chore: Remove deprecated tokens property from vscode.proposed.chatProvider.d.ts * fix compiler * Polish the code that sets env in packageJSONContribution.ts (microsoft#213306) * fix this reference in instantiation service (microsoft#213311) * Fix unsafe type assertions on object literals (microsoft#213318) * Benibenj/registerContextKeyHandler (microsoft#213135) * cleanup editor group context keys * Update src/vs/workbench/browser/parts/editor/editorPart.ts Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * context key on parts * Update global context keys * remove scoped keys on group removal * cleanup * first draft contexkt key registration * Make it a provider * Use group instead of active editor * getGroupContextKeyValue * doc * Fix merge error * 💄 --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * allow returning undefined if file was not saved (microsoft#213123) * allow returning undefined if file was not saved * bring back cancellation check * helper utility to convey optional result if cancelled * edit * inline function * test cancelled custom save * inline more --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Fix codicons padding in chat attachments * git: allow querying whether files are gitignore (microsoft#212982) * git: allow querying whether files are gitignore This exposes `checkIgnore`, which I want to use in copilot to determine which files I should go into when checking references. * rename method * Making API `editorHoverVerbosityLevel` use `verbosityLevel` instead of `action` (microsoft#213317) * allowing to cancel a previous request and jump directly to a request for a delta at a higher level * adding code in order to dispose the token sources when the full object is disposed * Fix issue with Cmd+W closing the window with opened tabs (microsoft#213335) fixes microsoft#213324 * Render html as plaintext when html not supported (microsoft#213265) * Support rendering unsupported html tags as plaintext for chat * Render html as plaintext when html not supported * Add comment and test for trusted domains * code action and lightbulb telemetry updates (microsoft#212929) * added additional telemetry and remove unused telemetry event * removed unused imports * Bump distro (microsoft#213340) * Part of microsoft#211878 (microsoft#212902) * SCM - add commands to focus next/previous input (microsoft#213337) * SCM - refactor commands to focus input * Ensure that the input node is expanded in the tree * getParent() should handle expanding the repository node * Use ArrayNavigator instead * Add support for looping in the array navigator * 💄 * use rot instead of array navigator * 💄 * more 💄 --------- Co-authored-by: João Moreno <joao.moreno@microsoft.com> * SCM - getParent() should handle resource groups (microsoft#213350) * refactor: replace direct process.pid usage with getProcessId method (microsoft#213352) * refactor: replace direct process.pid usage with getProcessId method * remove console.log * feat: enable attaching symbols to chat via `@` (microsoft#213347) * feat: enable attaching symbols to chat via `@` * Oop * SCM - add commands to focus previous/next resource group (microsoft#213377) * Initial implementation * 💄 * Fixed issue with focusing outside the tree * Joh/homely-damselfly (microsoft#213376) * chore - `ReplyResponse` cleanup * associate hunk data with response id * Associate hunk data with response state so that accepting hunks updates the text edit group * first cut of moving N-edits conversion from inline chat to panel * don't always consume mouse wheel (microsoft#213383) for chat widget (list) and for chat input editor (actually all simple editor cases) * clean up dead context keys and other dead code (microsoft#213387) * inline chat for notebook cell uses the `Notebook` chat location (microsoft#213385) * inline chat for notebook cell uses the `Notebook` chat location * fix tests * show filename for compare code blocks (microsoft#213389) * check uri when combining edits from different groups (microsoft#213390) * Fix issue microsoft#212877: Use Action context for Multi Diff Editor Actions (microsoft#213293) fix microsoft#212877 * Remove configure inline chat command from menu because it isn't popular at all and takes space (microsoft#213396) also fixes https://github.com/microsoft/vscode-copilot/issues/5662 * Scope custom editor and webview context keys to editor groups and global context (microsoft#213398) Properly scope custom editor and webview context keys * Fix broken codeblocks (microsoft#213399) * Fix broken codeblocks Fix microsoft#213382 * Fix tests * fix microsoft#194105 (microsoft#213403) * Add tests for editor group model (microsoft#213405) * Add test for editor group model * user helper function * web reporter refactor and issueFormService (microsoft#212951) * web version working * change to mainWindow * PROPER MOVEMENT * working for web as well * move issueFormService to workbench/contrib/issue * cleaning up{ * more cleanup, added setting * styling * use mainwindow to open and closee * css fixes * fix css again * fix CSS and wonky applyCSS rules * change gulpfile * add and update system info * address some of the comments * move files! small changes * move JS and non window specific back to electron sandbox * fix on issueReporter.js * fix build file * fix gulp file too.... * move everything into contrib * fix workbench import * move everything else into contrib, fix import * change name to web * applying more feedback fixes :D * fix command and remove unused import: * add back issueTroubleshoot * fix gulpile outputs * fix out exclusion: * Disable web TS type acquisition (microsoft#213412) We're waiting on some perf improvement for upstream types installer before turning this on everywhere * Hook up prototype paste with imports for JS/TS (microsoft#204665) * Hook up prototype paste with imports for JS/TS For microsoft/TypeScript#57262 but with proposed changes to ts protocol * Support new api * Update * issue reporter re-open save state (microsoft#213418) if anything is typed and we call open reporter again, saves issue title and data * provide default settings (microsoft#213419) fix microsoft#213411 * add item label (microsoft#213422) * add item label * update active window label * Add "when" clause to chat participants (microsoft#213425) * Add "when" clause to chat participants Fix microsoft#212447 * Change _agents to a Map and write some tests * Fix import * Change proposal for chat participant "when" clause (microsoft#213427) * Change proposal for chat participant "when" clause * This * feat: add top level `Symbol...` to Attach Context picker (microsoft#213435) * feat: enable attaching symbols to chat via `#` * feat: add `Symbol...` to Attach Context picker * feat: easier keyboard flow for removing chat attachments (microsoft#213436) * ts - enable use code watcher by default (microsoft#213450) * Fix menu computation when compact on right side (microsoft#213459) fix menu computation when compact on right side * Add focus indication for compact menu (microsoft#213463) indicate when compact menu is focused * Debt - dispose child instantiation service (microsoft#213471) * Fix "new chat" before focusing chat panel (microsoft#213478) Fix microsoft#213353 * Sort @workspace /explain above @Terminal /explain (microsoft#213482) Fix microsoft/vscode-copilot-release#1245 This is a bit of a hack but has some advantanges over adding an 'order' field to the chat participant or something like that. We can keep the order the same in other cases except for when the user is typing to filter the / list, then @Terminal slash commands will be pushed down. * Don't show chat agent hover on empty space in header (microsoft#213486) Fix microsoft/vscode-copilot#5271 * chore: update remote node.js (microsoft#213439) * chore: update remote node.js to v20.11.1 * chore: remove io_uring workaround * chore: update checksums * temp: update distro * ci: rebuild cache * chore: bump distro * Working sets - add preserveFocus (microsoft#213397) * Working sets - preserve focus when applying the working set was initiated by an action that was taken in the panel part (ex: switching branches from the terminal) * Pull request feedback * renames and cleanup * renames and cleanup * renames and cleanup --------- Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> * Add "Open in Editor" button for chat history (microsoft#213518) Fix microsoft#213517 * fix microsoft#213526 (microsoft#213527) * fix microsoft#181407 (microsoft#213530) * Remove brackets from comments, strings and regexes before evaluating the indentation (microsoft#210641) * wip * polishing the code * adding code * adding the language * reshuffling the code to avoid cyclic dependency * polihsing code * uncommenting tests * also adopting the indentation rules within the reindentation operation * using instead the sliced line tokens instead of the scoped line tokens * polishing the code * using start indices instead * using value everywhere * using the token data to type the tokens * setting to number instead of standard token type * using token data from autoindenttest.ts * using same code in both test files * placing instantiation service into the registerLanguage method * copying object into the node js autoindent.ts * report new windo profile setting (microsoft#213531) * Add license for deviceid (microsoft#213536) * watcher - add the utility process worker to disposables (microsoft#213538) * Color theme preview not working with "window.systemColorTheme": "auto" (microsoft#213539) * watcher - more `dispose` and remove E15 workaround (microsoft#213540) * Fix comments memory leak (microsoft#213542) Fixes microsoft#213535 * Fix copyright statement (microsoft#213543) * Don't show the gutter menu in the chat diff editor. (microsoft#213546) * Fixes diff editor height issue. (microsoft#213547) Before: Always 100% of parent container. After: Uses passed in dimensions. * Fixes microsoft#209627 (microsoft#213554) * SCM - reveal resource in the source control tree (microsoft#213556) * Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#213557) Adopt ensureNoDisposablesAreLeakedInTestSuite (microsoft#200091) * Fixes microsoft#209417 (microsoft#213549) * use refs/tags/release for 1espt (microsoft#213558) * debt - fix a few leaking listeners (microsoft#213560) * Ignore indentation rules when interacting with a string (microsoft#210761) * ignore indenation when interacting with a string * changes from discussion * remove the export keyword * adding changes to the PR * removing the console log * adding one more comment * extracting the method which forces the tokenization * Add license URIs for toml_edit and toml_datetime (microsoft#213562) Add licene uri fr toml_edit and toml_datetime * fix microsoft#213563 (microsoft#213564) * report new window profile switch (microsoft#213566) * Fixes microsoft#213573 (microsoft#213574) * fix microsoft#213576 (microsoft#213577) * Add editor.findMatchForeground (microsoft#213497) * feature: make find decoration foreground color configurable * Update license and third party notices (microsoft#213580) * editors - add test for transient group model changes (microsoft#213581) * Fixes microsoft#212771 (microsoft#213584) * Fix an issue where defaultLinesDiffComputer does not pass in the timeout variable (microsoft#213035) Update defaultLinesDiffComputer.ts * fix microsoft#212674 (microsoft#213583) * Fixes diff editor height in monaco editor playground example. (microsoft#213585) * Feat: Bolder Typeface + Configurable Letter Spacing for Minimap's Section Header Labels ✨ (microsoft#209990) * Rendering Section Header Labels with space in between the characters for better readability. * Making Section Headers Bold * Added settings for the Section Header Letter Spacing of the Minimap * a more performant and non-breaking way to render characters * fixed the git problems * add test default value * Allow fine-tuning the letter spacing, minor tweaks --------- Co-authored-by: Alexandru Dima <alexdima@microsoft.com> * Support diff merge editor for Notebooks (microsoft#213602) * Add Search in Cell Selection to Notebook Find Widget (microsoft#213409) * all search scope functionality except cell decorations * fix filter icon showing fake useage * decorations + css tweaking + PR feedback * Adding accessibility help for verbose hover (microsoft#212783) * adding code in order to provide accessibility help for the hover * adding the description of the possible commands that can be used * reusing the method * joining the content and changing the text in the help view * polishing the code * removing the question mark * changing the import * removing the setting ID from imports * adding code in order to update when the hover updates * adding methods to service * adding code in order to dispose the accessible hover view * fixing bug * polishing the code * checking that action not supported for the early return * using disposable store instead * using the appropriate string * polishing the code * using instead the type help and the resolved keybindings * hiding also on the `onDidBlurEditorWidget` firing * Revert "using instead the type help and the resolved keybindings" This reverts commit 1f450dd. * use hover accessible view, provide custom help * Revert "Revert "using instead the type help and the resolved keybindings"" This reverts commit 12f0cf6. * add HoverAccessibilityHelp, BaseHoverAccessibleViewProvider * polishing the code * polishing the code * provide content at a specific index from the hover accessibility help provider * introducing method _initializeOptions * using readonly where possible * using public everywhere * using a getter for the actions --------- Co-authored-by: meganrogge <megan.rogge@microsoft.com> * Add more info to comment range error (microsoft#213578) Part of microsoft#213243 * Bump postcss from 7.0.39 to 8.4.38 (microsoft#209857) Bumps [postcss](https://github.com/postcss/postcss) from 7.0.39 to 8.4.38. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@7.0.39...8.4.38) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: dispose template data disposables in source column renderer (microsoft#202618) * fixes regression: adding a `isCheapToTokenize` check before tokenizing the line (microsoft#213674) adding a check on how it is cheap to tokenize the lines * fix windows terminal hint not showing up (microsoft#213695) fix microsoft#213693 * Missing server node module (microsoft#213712) * Fix hover padding regression (microsoft#213700) * Fix textPreformatForeground for HC themes (microsoft#213698) * Fix js/ts cross code block intellisense (microsoft#213726) We need to register support for the backing copilot scheme too, not just the panel scheme in core * Fix vscode-api-tests in stable (microsoft#213733) * debug: bump js-debug for 1.90 (microsoft#213735) * fix: render ranges for attached selections in chat (microsoft#213741) * fix accessible view kb quickpick not showing (microsoft#213745) * fix: set aria label for chat context attachments (microsoft#213747) * web issue reporter styles (microsoft#213751) remove mac from tag * defaults web issue report false and disable in Firefox (microsoft#213752) * turn off in release and in ff * update * remove global enablement message (microsoft#213128) * editors - clarify `window.restoreWindows` setting further (microsoft#213771) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) (microsoft#213776) * `Ctrl + I` does not work when chat input field has focus (fix microsoft#213637) * simplify * aux window - support Firefox (microsoft#213769) * aux window - support Firefox * add more * only use workaround for FF * enable issue repoter again * . * fix microsoft#212208 (microsoft#213779) * Make rest of terminal initial hint italic Part of microsoft#213647 * Align colors of terminal hint with editor * Use pointer cursor for whole terminal initial hint Fixes microsoft/vscode-copilot#5963 * unwrap `LanguageModelError` when invoking chat participant (microsoft#213784) re microsoft#213710 * fix https://github.com/microsoft/vscode-copilot/issues/5814 (microsoft#213787) * fixes https://github.com/microsoft/vscode-copilot/issues/5908 (microsoft#213788) * fixes microsoft#213644 (microsoft#213789) * fix microsoft#213614 (microsoft#213791) * SCM - all calls from extHostSCM to mainThreadSCM should use a sequencer to ensure that the source control object is created (microsoft#213792) * Fix multi selected tab close behavior (microsoft#213794) fix microsoft#213620 * fix microsoft#196351 (microsoft#213796) * Cannot read properties of undefined (reading 'layout') (microsoft#213797) Fixes microsoft#212235 * fix microsoft#211965 (microsoft#213801) * fix: remove temp dir if extension is installed by another source (microsoft#213379) * closing out inline chat while speech is going does not stop audio (fix microsoft#213709) (microsoft#213802) * No text to speech when a change is applied (fix microsoft#213667) (microsoft#213804) * Regression: Unsaved comment reply lost when changing editors (microsoft#213805) Fixes microsoft#213144 * Voice dictation shortcut (fix microsoft#206800) (microsoft#213806) * Enable initialHint when not stable for now Part of microsoft#213647 * fix leaking listener (microsoft#213816) re microsoft#213141 * fix: setting labels appearing in widgets (microsoft#213826) * Connor4312/issue211378 (microsoft#213829) cli: fix inverted condition not showing warning correctly Fixes microsoft#211378 * doc updates & fixes for chat/lm API (microsoft#213777) * workaround @link not working * fixes microsoft#213630 * Retain previous quick pick navigation behavior with Home and End (microsoft#213832) Fixes microsoft#213739 * Fix microsoft#213525. Move nb chat variable to service (microsoft#213835) * Added redirect * Deleted build * Added submodule * Added symlinking * Added progress * Added script progress * Added attempt to fixx packaging * Added fresh install * Changed back to code.sh * Changed name * fix: hide Attach Context for quick chat (microsoft#213841) * Hook up notebook format code action to format notebook command (microsoft#213847) hook format codeaction to format notebook command * Added extHostChatAgents2.ts * Added contributing * Add setup scripts for different environments (#87) * Add setup scripts for for cross enviroments * add calls to vscode build scripts * update function naming * reduce DRY code in setup scripts * remove old link & update gitignore --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Rob Lourens <roblourens@gmail.com> Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com> Co-authored-by: Benjamin Christopher Simmonds <44439583+benibenj@users.noreply.github.com> Co-authored-by: Robo <hop2deep@gmail.com> Co-authored-by: Connor Peet <connor@peet.io> Co-authored-by: Megan Rogge <merogge@microsoft.com> Co-authored-by: Joyce Er <joyce.er@microsoft.com> Co-authored-by: Joyce Er <joyceerhl@gmail.com> Co-authored-by: Isidor Nikolic <inikolic@microsoft.com> Co-authored-by: Johannes Rieken <johannes.rieken@gmail.com> Co-authored-by: Walker Boyle <wboyle13@gmail.com> Co-authored-by: Matt Bierner <matb@microsoft.com> Co-authored-by: David Dossett <ddossett@microsoft.com> Co-authored-by: Aaron Munger <aamunger@microsoft.com> Co-authored-by: Peng Lyu <penn.lv@gmail.com> Co-authored-by: Ladislau Szomoru <3372902+lszomoru@users.noreply.github.com> Co-authored-by: Logan Ramos <lramos15@gmail.com> Co-authored-by: Sandeep Somavarapu <sasomava@microsoft.com> Co-authored-by: Alexandru Dima <alexdima@microsoft.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: João Moreno <joao.moreno@microsoft.com> Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com> Co-authored-by: Justin Chen <54879025+justschen@users.noreply.github.com> Co-authored-by: Alex Ross <alros@microsoft.com> Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com> Co-authored-by: Simon Siefke <simon.siefke@gmail.com> Co-authored-by: Hanning Gong (Charles) <charles.gong@databricks.com> Co-authored-by: Pouya Kary ✨ <kary@gnu.org> Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com> Co-authored-by: Michael Lively <milively@microsoft.com> Co-authored-by: meganrogge <megan.rogge@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Shoham Ben Shitrit <91195275+bsShoham@users.noreply.github.com> Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com> Co-authored-by: Yesterday17 <mmf@mmf.moe> Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com> Co-authored-by: Tyler James Leonhardt <me@tylerleonhardt.com> Co-authored-by: Nathan A <nang@Nathans-MacBook-Pro-8.local> Co-authored-by: Ender <endergamingfilms@gmail.com>

jrieken assigned meganrogge May 21, 2024

jrieken added this to the May 2024 milestone May 21, 2024

meganrogge added debt Code quality issues terminal-chat Issues related to the terminal chat widget labels May 21, 2024

meganrogge added a commit that referenced this issue May 21, 2024

fix #213159

3f44453

meganrogge mentioned this issue May 21, 2024

Use ChatAgentService instead of InlineChatService for terminal chat hint #213183

Merged

meganrogge closed this as completed in #213183 May 21, 2024

meganrogge added a commit that referenced this issue May 21, 2024

Use ChatAgentService instead of InlineChatService for terminal ch…

c0c8cdd

…at hint (#213183) fix #213159

vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 21, 2024

andremmsilva pushed a commit to PIC1G55/vscodeG55 that referenced this issue May 26, 2024

Use ChatAgentService instead of InlineChatService for terminal ch…

3ddb5f1

…at hint (microsoft#213183) fix microsoft#213159

microsoft locked and limited conversation to collaborators Jul 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Terminal must not depend on `IInlineChatSessionProvider` et al #213159

Terminal must not depend on `IInlineChatSessionProvider` et al #213159

jrieken commented May 21, 2024 •

edited

Loading

jrieken commented May 21, 2024

Terminal must not depend on IInlineChatSessionProvider et al #213159

Terminal must not depend on IInlineChatSessionProvider et al #213159

Comments

jrieken commented May 21, 2024 • edited Loading

jrieken commented May 21, 2024

Terminal must not depend on `IInlineChatSessionProvider` et al #213159

Terminal must not depend on `IInlineChatSessionProvider` et al #213159

jrieken commented May 21, 2024 •

edited

Loading