Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*New OBLdepth calculation based on POP approach. Ans changes* #87

Merged
merged 2 commits into from
Feb 6, 2015

Conversation

StephenGriffies
Copy link
Contributor

Modifications to the OBLdepth calculation based now on what
is done by POP. New results found to be insensitive to the
"correction" step, since the first pass now properly accounts
for the thickness of the surface layer. This new approach
changes answers, but not by much. New algorithm is
faster (since no need to perform the correction step) and
easier to understand.

These changes need to be tested in all expts that use KPP.

Modifications to the OBLdepth calculation based now on what
is done by POP.  New results found to be insensitive to the
"correction" step, since the first pass now properly accounts
for the thickness of the surface layer.  This new approach
changes answers, but not by much.  New algorithm is
faster (since no need to perform the correction step) and
easier to understand.
@adcroft
Copy link
Collaborator

adcroft commented Feb 5, 2015

The Bulk Richardson number is part of KPP because the definition is unique to Large et al. We've always had Bulk Ri in the MOM_KPP module. What @StephenGriffies has done is fix the first guess for the average within the surface layer.

@MJHarrison-GFDL
Copy link
Contributor

I understand. Its only relevant to kpp expts and only affects first guess.
Just pointing out that we in principle should be calculating things like N2
or S2 identically across MOM6 code. Right?

On Thursday, February 5, 2015, Alistair Adcroft (GFDL) <
notifications@github.com> wrote:

The Bulk Richardson number is part of KPP because the definition is
unique to Large et al. We've always had Bulk Ri in the MOM_KPP module. What
@StephenGriffies has done is fix the first guess for the average within the
surface layer.


Reply to this email directly or view it on GitHub.<
https://ci4.googleusercontent.com/proxy/PX185Sib3YztFoFiDtpQsORsBczPp-wqlsjwKM6tBzLc8J2QcO0LpUkd9y61MX07li3wmGDrnf3feWuLGzPq1o1Fq3hjQ0m28Xvk-WbCU3k4vazLA4zn0d4zKjpo--6gi_OvTAY7IlzaK14WAbl_e1VD1BGNdw=s0-d-e1-ft#https://github.com/notifications/beacon/AGT88O_P2ew1qZguoLK8eP_pdbiR2p0sks5no-O7gaJpZM4Dccje.gif

@StephenGriffies
Copy link
Contributor Author

Hi,

Agree we should do things consistently across MOM6. Is there a common N2
calculation routine now in MOM6? If so, then we can make use of it. If
not, then let's add that to the task list.

Steve

On Thu, Feb 5, 2015 at 7:09 PM, Matthew Harrison notifications@github.com
wrote:

I understand. Its only relevant to kpp expts and only affects first guess.
Just pointing out that we in principle should be calculating things like N2
or S2 identically across MOM6 code. Right?

On Thursday, February 5, 2015, Alistair Adcroft (GFDL) <

notifications@github.com> wrote:

The Bulk Richardson number is part of KPP because the definition is
unique to Large et al. We've always had Bulk Ri in the MOM_KPP module. What
@StephenGriffies has done is fix the first guess for the average within the
surface layer.


Reply to this email directly or view it on GitHub.<

https://ci4.googleusercontent.com/proxy/PX185Sib3YztFoFiDtpQsORsBczPp-wqlsjwKM6tBzLc8J2QcO0LpUkd9y61MX07li3wmGDrnf3feWuLGzPq1o1Fq3hjQ0m28Xvk-WbCU3k4vazLA4zn0d4zKjpo--6gi_OvTAY7IlzaK14WAbl_e1VD1BGNdw=s0-d-e1-ft#https://github.com/notifications/beacon/AGT88O_P2ew1qZguoLK8eP_pdbiR2p0sks5no-O7gaJpZM4Dccje.gif


Reply to this email directly or view it on GitHub
#87 (comment)
.

Dr. Stephen M. Griffies
NOAA Geophysical Fluid Dynamics Lab
201 Forrestal Road
Princeton, NJ 08542
USA

Change default interpolation method to cubic to enable the
most accurate available calculation of the boundary layer
depth.  Changes answers.
@adcroft adcroft merged commit 145c94a into dev/master Feb 6, 2015
@StephenGriffies StephenGriffies deleted the user/smg/KPP_ala_POP branch March 12, 2015 19:40
gustavo-marques pushed a commit to gustavo-marques/MOM6 that referenced this pull request Dec 19, 2018
Introduces additional fluxes used in the CESM framework
adcroft pushed a commit that referenced this pull request Dec 10, 2020
Doxygen support for 1.8.13 through 1.8.20
Hallberg-NOAA added a commit to OlgaSergienko/MOM6 that referenced this pull request Mar 22, 2022
SMoorthi-emc pushed a commit to SMoorthi-emc/MOM6 that referenced this pull request Mar 25, 2022
…n-20220317

update to MOM6 main branch 20220317 commit
marshallward added a commit to marshallward/MOM6 that referenced this pull request May 3, 2022
Note that most of these commits are from previously squashed pull
requests, and this PR is restoring them.

- 6360dbb Merge branch 'main' into main_to_dev
- bac8031 Merge pull request mom-ocean#1566 from jiandewang/EMC-FMS-mixed-mode-20220411
- e532d86 Merge pull request mom-ocean#88 from marshallward/missing_attrib_with_class_bugfix
- d380f1d An alternate fix to class(*) issues with FMS 2022-01
- 8ecf333 Merge pull request mom-ocean#87 from jiandewang/feature/update-to-main-20220317
- ba37f94 Merge remote-tracking branch 'FSU/main' into feature/update-to-main-20220317 this is corresponding to MOM6 main 20220317 commit (hash # 399a7db)
- 44313d9 Merge pull request mom-ocean#85 from jiandewang/feature/update-to-main-20220217
- 966707f Merge remote-tracking branch 'GFDL/main' into feature/update-to-main-20220217 this is corresponding to MOM6 main branch 20220217 commit (hash # 6f6d4d6), which originally based on GFDL-candidate-20220129
- 32c0e1e Merge pull request mom-ocean#81 from jiandewang/feature/update-to-main-20211220
- 9642b1d delete external/OCEAN_stochastic_phyiscs directory as Phil re-coded in external/stochastic_physics directory
- e7c9ada solve minor conflict in mom_cap.F90 mom_ocean_model_nuopc.F90 and MOM_energetic_PBL.F90, add two new files: src/parameterizations/stochastic/MOM_stochastics.F90 and config_src/external/stochastic_physics/stochastic_physics.F90
- 90d5961 Merge pull request mom-ocean#78 from jiandewang/feature/update-to-GFDL-20211019
- fd02017 Merge remote-tracking branch 'GFDL/main' into feature/update-to-GFDL-20211019
- 36f17eb Merge pull request mom-ocean#72 from pjpegion/ocn_stoch_july2021
- a9a957e return a more accurate error message in MOM_stochasics
- 56bb41e Merge branch 'ocn_stoch_july2021' of https://github.com/pjpegion/MOM6 into ocn_stoch_july2021
- ca2ae1c update to dev/emc
- 14ca4a1 Merge pull request mom-ocean#76 from jiandewang/feature/update-to-GFDL-20210914
- 29016c2 Merge remote-tracking branch 'GFDL/main' into feature/update-to-GFDL-20210914 merge GFDL main 20210914 commit (hash # c09e199)
- a8577df Merge branch 'NOAA-EMC:dev/emc' into ocn_stoch_july2021
- f8a8e4c update to gfdl 20210806 (mom-ocean#74)
- 16e6af0 update to dev/emc
- 237a510 add comments
- 1b4273d revert logic wrt increments
- 5b2040e add logic to remove incrments from restart if outside IAU window
- c5f2b72 add write_stoch_restart_ocn to MOM_stochastics
- bdf2dc7 doxygen cleanup
- 8bc4acc move stochastics to external directory
- a3fa3a1 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch_july2021
- e4bc007 stochastic physics re-write
- 202cbd4 update to dev/emc
- 61717ee Merge remote-tracking branch 'origin/dev/emc' into ocn_stoch
- 565e0bb remove debug statements
- a4c0411 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch
- 689a73f remove PE_here from mom_ocean_model_nuopc.F90
- 8afe969 clean up of mom_ocean_model_nuopc.F90
- 25ed4fc revert MOM_domains.F90
- b8d9888 place stochastic array in fluxes container and make SPPT specific arrays allocatable
- d984a7e remove stochastics container
- eb88219 clean up of code for MOM6 coding standards
- 6e3ea1b correct coupled_driver/ocean_model_MOM.F90 and other cleanup
- 0b99c1f make stochastics optional
- 85023f8 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch
- 80f9f44 clean up MOM_domains
- 5443f8e remove blank link in MOM_diagnostics
- 1727d9a re-write of stochastic code to remove CPP directives
- 600ebf9 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch
- 6bb9d0b fix non stochastic ePBL calculation
- 1d7ffa3 clean up code
- 040e1f1 Merge pull request #13 from NOAA-EMC/dev/emc
- 2cba995 Merge branch 'dev/emc' into ocn_stoch
- 1dc0f4f Merge remote-tracking branch 'upstream/dev/emc' into dev/emc
- 4bd9b9e clean up debug statements
- 25ed5ef additions for stochy restarts
- a2a374b add stochy_restart writing to mom_cap
- 0c15f4c Update MOM_diabatic_driver.F90
- 167a62e Merge pull request #12 from pjpegion/dev/emc
- bd477a9 Update MOM_diabatic_driver.F90
- 7212400 Update MOM_diabatic_driver.F90
- 7de295c cleanup of code and enhancement of ePBL perts
- cd06356 Merge pull request #11 from NOAA-EMC/dev/emc
- 9896d61 Merge pull request #9 from pjpegion/dev/emc_merge
- 0a62737 Merge branch 'ocn_stoch' into dev/emc_merge
- 3cad1ba Merge pull request #8 from NOAA-EMC/dev/emc
- c2aa2a8 updates from dev/emc
- 182ef34 additions for stochastic physics and ePBL perts
- 671c714 Merge pull request #1 from NOAA-EMC/dev/emc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants