chore: develop -> main, attempt 2 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optional Account ID in signin flow
Aud from config
Modified the test environment to expose the signing nodes so we can actually test they're signing the right payloads
add same key test added
* return acc and pk info in signin and new acc flows * integration tests fixe
* store user keys in GCP Datastore * simplify value serialization * mock datastore with emulator in integration tests * appease clippy * rename to UserCredentials * integrate signer nodes with Datastore
* signature validation using all the keys
* err type added in failed to fetch pk
Co-authored-by: Daniyar Itegulov <ditegulov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.