Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master-2.x changes since Feb 2, 2018 #3

Open
wants to merge 66 commits into
base: last-known-2.x-update
Choose a base branch
from

Conversation

spencercorwin
Copy link

This is a PR just to show the diff in the neo-project/neo-vm repo between commit 3fd0c9f and the current master-2.x. This gives us an easy look at what has changed in the Neo repo since March 4, 2019 to see what updates to current Neo2 we may have missed since then. The commit 3fd0c9f is when Erik merged a new MapStackItem change requested by DiCarlo. Specifically this is when the VM changed to now allow ICollection values as keys in MapStackItems, which was apparently missed in our updates for the new MapStackItem. So this is the last point we should expected to begin looking for changes that we may have missed.

erikzhang and others added 30 commits February 26, 2018 19:25
* add `Map` to NeoVM

1. Add new type `Map`.
2. Add new opcodes: `NEWMAP`, `HASKEY`, `KEYS`, `VALUES`.
3. Modify the opcodes `ARRAYSIZE`, `PICKITEM`, `SETITEM`, `REMOVE` to support map.

* change the equality judgment logic of `Array` and `Map`
* move `EvaluationStack` and `AltStack` from `ExecutionEngine` to `ExecutionContext`

* move `break_points` from `ExecutionContext` to `ExecutionEngine`

* remove `push_only`

* remove `Clone` from `ExecutionContext`

* optimize code

* isolate `AltStack` in compatible mode

* automatically copy the return values to the evaluation stack when executing `RET` instruction

* add new opcode for stack isolation: `CALL_I`, `CALL_E`, `CALL_ED`, `CALL_ET`, `CALL_EDT`

* supports multiple return values

* make `ExecutionEngine.Dispose` be virtual
* First proposal of VM-UT

* Clean code

* To upper

* Organize tests

* Update neo-vm.Tests.csproj

* State to result, states in array, TOALTSTACK unit test

* Exceptions

* Show more information when one test fail
erikzhang and others added 30 commits March 26, 2019 20:43
* Improve the performance of NeoVM

* remove `CheckBigIntegerByteLength()`

* Add comment

Add a comment in order to prevent the use in the future without check the length previously

* Update Unsafe.cs

* Some ut for performance PR (neo-project#100)

* SHL and SHR

* SIZE

* Change category

* Typo

* SUBSTR ut (neo-project#101)
Prevent to compute `CurrentContext.ScriptHash` if there are none break points, this allow to use ExecutionEngine without ICrypto for small smart contracts (Benchmarks)
* Move breakpoints logic to other class

* Add `Debugger`

* format

* fix tests
…eo-project#104)"

This reverts commit 8db80d4.

There are too many changes for Neo to be made to apply this change. I will wait for .NET Standard 2.1 and make a new PR to implement this improvment.
* Unify CheckStackSize in `PICKITEM`

* Update ExecutionEngine.cs
* Small RandomAccessStack optimizations

* Small optimizations

* AggressiveInlining
* Auto stash before rebase of "origin/master"

* Readme coverage

* Neo

* Travis

* Change XUnit to MSTest
* Auto stash before rebase of "origin/master"

* Offset test
* Allow to compress syscalls api methods

* optimize
* Unit test for RandomAccessStack

* AggressiveInlining
* APPCALL and Remove non used method

* TAILCALL
* Fix breakpoints on StepOver and StepOut

* Update Debugger.cs

* Update Debugger.cs

* rename
* Use Script class for caching the instructions instead of ExecutionContext

* Same var format

* Update Script.cs

* format
* Revert some checks for 2.x

* Update ExecutionEngine.cs

This shargon@e615bf5#diff-76ae2659301a783b97ae4c99999464cc produce a difference in the storage

* Fix test

* SUBSTR revert

* Fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants