Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Freebayes Single for Germline VC #179

Merged
merged 10 commits into from
Apr 14, 2020
Merged

Adding Freebayes Single for Germline VC #179

merged 10 commits into from
Apr 14, 2020

Conversation

ggabernet
Copy link
Member

@ggabernet ggabernet commented Apr 9, 2020

nf-core/sarek pull request

Adding process Freebayes Single for Germline VC with FreeBayes

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@ggabernet
Copy link
Member Author

Note that I also updated the sarek_workflow.png image for the readme, so maybe have a look if you like it first :)

Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing.
Did you update the figure as well?

@ggabernet
Copy link
Member Author

Hi Maxime, yes I updated the figure .png, should I also update the .svg in the repository?

@maxulysse
Copy link
Member

Yes, exactly, that's what I meant

@maxulysse maxulysse merged commit 248b3ea into nf-core:dev Apr 14, 2020
@ggabernet ggabernet deleted the freebayes branch April 15, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants