src,lib: use uv_thread_setname to a better multi-thread debugging

[RafaelGSS]

Note: This PR depends libuv/libuv#4599 to be released by libuv team.

TODO:

• Work on tests

• I'm also patching uv to set the default thread name, but it's up to them to accept it, I don't know if there's a way from Node.js to access their thread or call an API to change their default thread name Done in src: set a default thread name for workers libuv/libuv#4664
• A default thread name for the inspector thread has been added
• A default thread nathe me for signal inspector has been added
• A default thread name for each one of the Node Platform Workers has been added
• I'm using worker.name to set the thread name when a worker thread gets created (it defaults to WorkerThread).

cc: @santigimeno

---

With this PR users will be able to get a more meaningful diagnostic when looking at Node.js threads, for instance, they will be able to see on which thread their app is spending more time (libuv, workers, main thread...). See the image:

Consider the following server (please do not run it in production):

const http = require('http')
const fs = require('node:fs')
const { Worker, isMainThread } = require('node:worker_threads')

if (!isMainThread) {
  console.log('Done :)')
  setTimeout(() => {
    process.exit(0);
  }, 5 * 1000);
  return;
}

let i = 0;
http.createServer((req, res) => {
  fs.readFile(__filename, () => {
    res.end('hello')
  })
  new Worker(__filename, { name: `RafaelGSS (${++i})` });
}).listen(3000)

On Node.js startup if you monitor using htop you should be able to see:

Then once it gets a request:

V8Worker and libuv threads number depends on the parameters & environments

[nodejs-github-bot]

Review requested:

• @nodejs/security-wg

[santigimeno]

The code generally looks fine to me.

• I'm also patching uv to set the default thread name, but it's up to them to accept it, I don't know if there's a way from Node.js to access their thread or call an API to change their default thread name.

The API to execute code in the the threadpool is uv_queue_work() but I don't think we want that.
Personally, I'd be ok with libuv hard-coding the name to the threads in the threadpool, but maybe a new api could be added for that like a new flag to uv_loop_configure(). I would just open an issue in the libuv repo to discuss this.

[RafaelGSS]

I wonder if that's the best place to do it.

[mcollina]

lgtm, this looks great. I needed this for a while, but never took the time for the libuv PR.

[codecov]

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.17%. Comparing base (793c793) to head (1a588eb).
Report is 37 commits behind head on main.

Files with missing lines	Patch %	Lines
src/inspector_agent.cc	0.00%	1 Missing ⚠️
src/inspector_io.cc	75.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #56416   +/-   ##
=======================================
  Coverage   89.17%   89.17%           
=======================================
  Files         665      665           
  Lines      192602   192610    +8     
  Branches    37058    37053    -5     
=======================================
+ Hits       171748   171756    +8     
+ Misses      13664    13663    -1     
- Partials     7190     7191    +1     

Files with missing lines	Coverage Δ
lib/internal/worker.js	99.81% <100.00%> (ø)
src/node.cc	73.54% <100.00%> (+0.03%)	⬆️
src/node_platform.cc	87.86% <100.00%> (+0.02%)	⬆️
src/node_worker.cc	84.28% <100.00%> (-0.30%)	⬇️
src/inspector_agent.cc	79.63% <0.00%> (-0.12%)	⬇️
src/inspector_io.cc	92.23% <75.00%> (-0.35%)	⬇️

... and 24 files with indirect coverage changes

[RafaelGSS]

Waiting for libuv/libuv#4664 to land & release

[santigimeno]

LGTM with a couple of comments

[RafaelGSS]

This is now ready to go. PTAL @mcollina @santigimeno @jasnell

[santigimeno]

Still LGTM

[BridgeAR]

Great addition!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/64604/

[jasnell]

@RafaelGSS ... there are relevant non-flaky test failures in CI

[RafaelGSS]

I had to push a fix for AIX. Could you please re-approve so I can land it?

[nodejs-github-bot]

Landed in 16dc29d...d7aacbe

[github-actions]

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @RafaelGSS.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.