-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update history of stream.Readable.toWeb() #56928
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
hkleungai:stream-Writable-fromWeb-history-update
Feb 7, 2025
Merged
doc: update history of stream.Readable.toWeb() #56928
nodejs-github-bot
merged 1 commit into
nodejs:main
from
hkleungai:stream-Writable-fromWeb-history-update
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkleungai
commented
Feb 5, 2025
- version: | ||
- v19.0.0 | ||
- v18.7.0 | ||
pr-url: https://github.com/nodejs/node/pull/43515 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there is a warning from GitHub Actions / lint-pr-url
. If this url needs to be changed please let me know.
Merged
7 tasks
lpinca
approved these changes
Feb 6, 2025
Adds the exact version for when the 2nd `options` argument is available. Refs: nodejs#43515
50e796a
to
2419b31
Compare
lpinca
approved these changes
Feb 6, 2025
jasnell
approved these changes
Feb 7, 2025
Landed in 1b2d2f7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
stream
Issues and PRs related to the stream subsystem.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the exact version for when the 2nd
options
argument is available.Refs: #43515