Closed
Conversation
It's not clear this will become an OEP, but I needed someplace to write this all down.
Contributor
Contributor
Author
|
@antoviaque yes, in the discussion on the PR itself (https://github.com/edx/edx-platform/pull/25949) we were talking about wanting to record the motivations for the information collected in the PR template. |
nedbat
force-pushed
the
nedbat/change-transparency
branch
from
1ed85b7 to
34ef518
Compare
This was referenced Sep 30, 2021
edx-community-bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Nov 1, 2021
…nal service
<!--
🍁🍁
🍁🍁🍁🍁 🍁 Note: the Maple master branch has been created. Please consider whether your change
🍁🍁🍁🍁 should also be applied to Maple. If so, make another pull request against the
🍁🍁🍁🍁 open-release/maple.master branch, or ping @nedbat for help or questions.
🍁🍁
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
This is a backport of https://github.com/edx/edx-platform/pull/27795. The idea of this PR is to make the external Codejail service feature available in the Maple release, which will help to integrate Codejail with the Tutor ecosystem. From openedx/wg-build-test-release#98 (comment) we can confirm the feature is working.
## Deadline
"None".
edx-community-bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Dec 15, 2021
<!--
🍁🍁
🍁🍁🍁🍁 🍁 Note: the Maple master branch has been created. Please consider whether your change
🍁🍁🍁🍁 should also be applied to Maple. If so, make another pull request against the
🍁🍁🍁🍁 open-release/maple.master branch, or ping @nedbat for help or questions.
🍁🍁
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
cherry-picked 39b9115 from master branch to make changes availabe in maple release.
## Supporting information
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2781
BTR issue: openedx/wg-build-test-release#105
edx-community-bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Dec 15, 2021
<!--
🍁🍁
🍁🍁🍁🍁 🍁 Note: the Maple master branch has been created. Please consider whether your change
🍁🍁🍁🍁 should also be applied to Maple. If so, make another pull request against the
🍁🍁🍁🍁 open-release/maple.master branch, or ping @nedbat for help or questions.
🍁🍁
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
cherry-picked 834dabb from master branch to make changes availabe in maple release.
## Supporting information
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2781
BTR issue: openedx/wg-build-test-release#105
edx-community-bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Dec 15, 2021
<!--
🍁🍁
🍁🍁🍁🍁 🍁 Note: the Maple master branch has been created. Please consider whether your change
🍁🍁🍁🍁 should also be applied to Maple. If so, make another pull request against the
🍁🍁🍁🍁 open-release/maple.master branch, or ping @nedbat for help or questions.
🍁🍁
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
cherry-picked 4300872 from master branch to make changes availabe in maple release.
## Supporting information
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2781
BTR issue: openedx/wg-build-test-release#105
edx-community-bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Dec 15, 2021
<!--
🍁🍁
🍁🍁🍁🍁 🍁 Note: the Maple master branch has been created. Please consider whether your change
🍁🍁🍁🍁 should also be applied to Maple. If so, make another pull request against the
🍁🍁🍁🍁 open-release/maple.master branch, or ping @nedbat for help or questions.
🍁🍁
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
cherry-picked 7aadf55 from master branch to make changes availabe in maple release.
## Supporting information
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2781
BTR issue: openedx/wg-build-test-release#105
edx-community-bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Dec 15, 2021
<!--
🍁🍁
🍁🍁🍁🍁 🍁 Note: the Maple master branch has been created. Please consider whether your change
🍁🍁🍁🍁 should also be applied to Maple. If so, make another pull request against the
🍁🍁🍁🍁 open-release/maple.master branch, or ping @nedbat for help or questions.
🍁🍁
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
cherry-picked ba75bb6 from master branch to make changes availabe in maple release.
## Supporting information
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2781
BTR issue: openedx/wg-build-test-release#105
edx-community-bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Dec 15, 2021
<!--
🍁🍁
🍁🍁🍁🍁 🍁 Note: the Maple master branch has been created. Please consider whether your change
🍁🍁🍁🍁 should also be applied to Maple. If so, make another pull request against the
🍁🍁🍁🍁 open-release/maple.master branch, or ping @nedbat for help or questions.
🍁🍁
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
cherry-picked e54fb5f from master branch to make changes availabe in maple release.
## Supporting information
Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2781
BTR issue: openedx/wg-build-test-release#105
edx-community-bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Dec 23, 2021
<!--
🍁🍁
🍁🍁🍁🍁 🍁 Note: the Maple master branch has been created. Please consider whether your change
🍁🍁🍁🍁 should also be applied to Maple. If so, make another pull request against the
🍁🍁🍁🍁 open-release/maple.master branch, or ping @nedbat for help or questions.
🍁🍁
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
cherry-picked d9dd10d from master branch to make changes availabe in maple release.
## Supporting information
BTR issue: openedx/wg-build-test-release#105
Contributor
|
@nedbat do you think we still need this high-level OEP around change transparency? |
Contributor
Author
|
Seems like not. |
This was referenced Feb 28, 2022
github-actions bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Jun 28, 2022
…r versions
<!--
🌰🌰
🌰🌰🌰🌰 🌰 Note: the Nutmeg master branch has been created. Please consider whether your change
🌰🌰🌰🌰 should also be applied to Nutmeg. If so, make another pull request against the
🌰🌰🌰🌰 open-release/nutmeg.master branch, or ping @nedbat for help or questions.
🌰🌰
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
This PR updates the problem with hint template so it works with Python3+. It simply adds parenthesis to a print statement that was causing an error while rendering this kind of problem.
## Supporting information
- This bug was reported on [this](openedx/wg-build-test-release#159 (comment)) BTR issue.
- [Master PR](#30585)
## Testing instructions
(tested on tutor Nutmeg version)
1. Install the codejail plugin following [these](https://github.com/eduNEXT/tutor-contrib-codejail) instructions
2. Create a problem with hint unit, it shouldn't throw any errors (like the one reported)
## Deadline
None
github-actions bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Aug 2, 2022
<!--
🌰🌰
🌰🌰🌰🌰 🌰 Note: the Nutmeg master branch has been created. Please consider whether your change
🌰🌰🌰🌰 should also be applied to Nutmeg. If so, make another pull request against the
🌰🌰🌰🌰 open-release/nutmeg.master branch, or ping @nedbat for help or questions.
🌰🌰
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
**Cherry pick of #30244
At Opencraft, we want to run multiple instances of celery workers in separate servers. The celery workers need to be able to share task results. Currently, the `CELERY_RESULT_BACKEND` is hard coded to use `django-cache`.
So this PR allows to setup `CELERY_RESULT_BACKEND` via configuration.
To use django ORM as celery backend, one can set `CELERY_RESULT_BACKEND` to `django-db` as described in [docs](https://docs.celeryq.dev/en/stable/django/first-steps-with-django.html#django-celery-results-using-the-django-orm-cache-as-a-result-backend).
## Supporting information
- Task: https://tasks.opencraft.com/browse/BB-6077
## Deadline
"None"
github-actions bot
added a commit
to openedx/openedx-platform
that referenced
this pull request
Aug 8, 2022
<!--
🌰🌰
🌰🌰🌰🌰 🌰 Note: the Nutmeg master branch has been created. Please consider whether your change
🌰🌰🌰🌰 should also be applied to Nutmeg. If so, make another pull request against the
🌰🌰🌰🌰 open-release/nutmeg.master branch, or ping @nedbat for help or questions.
🌰🌰
Please give your pull request a short but descriptive title.
Use conventional commits to separate and summarize commits logically:
https://open-edx-proposals.readthedocs.io/en/latest/oep-0051-bp-conventional-commits.html
Use this template as a guide. Omit sections that don't apply. You may link to information rather than copy it.
More details about the template are at openedx/openedx-proposals#180
(link will be updated when that document merges)
-->
## Description
Backport filters that didn't make it to nutmeg release:
**Add filter before certificate creation starts**
(cherry picked from commit e8fa890)
**Add cohort change filter before moving users from cohorts**
(cherry picked from commit 465e5c0)
**Add filter before certificate rendering process starts**
(cherry picked from commit 7f974d1)
**Add filter before course dashboard rendering process starts**
(cherry picked from commit 895a649)
**Add filter before course about rendering process starts**
(cherry picked from commit ccfa0b4)
**Integrate cohort assignment filter definition to cohort model**
(cherry picked from commit ec69659)
## Supporting information
Refer to the BTR wg github issue for the rationale behind this PR: openedx/wg-build-test-release#187
## Testing instructions
1. Install the needed library release: `openedx-filters==0.7.0`
2. Install the samples library:
`pip install git+https://github.com/eduNEXT/openedx-filters-samples.git@master#egg=openedx_filters_samples`
3. Then, configure each filter. If you want to test all the filters simultaneously, use this configuration and try to do each operation the filter is related to; the filter sample step will stop the operation.
```
OPEN_EDX_FILTERS_CONFIG = {
"org.openedx.learning.certificate.creation.requested.v1": {
"fail_silently": False,
"pipeline": [
"openedx_filters_samples.samples.pipeline.StopCertificateCreation"
]
},
"org.openedx.learning.cohort.change.requested.v1": {
"fail_silently": False,
"pipeline": [
"openedx_filters_samples.samples.pipeline.StopCohortChange"
]
},
"org.openedx.learning.certificate.render.started.v1": {
"fail_silently": False,
"pipeline": [
"openedx_filters_samples.samples.pipeline.RenderAlternativeCertificate",
]
},
"org.openedx.learning.dashboard.render.started.v1": {
"fail_silently": False,
"pipeline": [
"openedx_filters_samples.samples.pipeline.RenderAlternativeDashboard",
]
},
"org.openedx.learning.course_about.render.started.v1": {
"fail_silently": False,
"pipeline": [
"openedx_filters_samples.samples.pipeline.RenderAlternativeCourseAbout",
]
},
"org.openedx.learning.cohort.assignment.requested.v1": {
"fail_silently": False,
"pipeline": [
"openedx_filters_samples.samples.pipeline.StopCohortAssignment"
]
},
}
```
Please, for detailed instructions on how to test each filter, refer to each of these PR(s):
Filter for certificate creation:
#29949
Filter for cohort change:
#29964
Filter for certificate rendering:
#29976
Filter for dashboard rendering:
#29994
Filter for course about rendering:
#29996
Filter for cohort assignment:
#30431
## Deadline
For the next nutmeg release.
Contributor
|
@nedbat the PR template, https://raw.githubusercontent.com/openedx/edx-platform/master/.github/pull_request_template.md, references this PR. Is that still the right thing to do? |
Contributor
Author
|
@sarina You are right that we were too optimistic.... I'll update the template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not clear this will become an OEP, but I needed someplace to write
this all down.