♻️ Replace Grommet Button components #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-button
branch
2 times, most recently
from
5fb1fde
to
9e8067d
Compare
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-button
branch
6 times, most recently
from
3298c83
to
352bf11
Compare
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-button
branch
from
352bf11
to
5f6e07c
Compare
kernicPanel
approved these changes
Oct 19, 2023
Comment on lines
+1
to
+4
| export const tokens = { | ||
| themes: { | ||
| default: { | ||
| theme: { |
There was a problem hiding this comment.
How is this file generated ?
Can we get a flatter structure by removing tokens, themes and default ?
This way we can only use color={theme.colors['success-500']} for example
On maybe just export a specific key ?
WDYT ?
There was a problem hiding this comment.
Yes you'r right.
It is generated here:
We don't have the hand on the generated file but we can add some exports:
Easier now:
|
|
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-button
branch
from
5f6e07c
to
d2db4aa
Compare
lunika
approved these changes
Oct 24, 2023
In some cases we just want to have an icon clickable, this refacto make it possible with our component SVGIcons.
In order to do the transition to the cunningham design system, we replace the grommet Button component with the cunningham Button components.
We replace this buttons components by the cunningham Button component. This components are not used anymore.
The cunningham 2.0.0 must have some updates in the config file.
We can generate a ts cunningham-tokens file, we can access more easily some tokens in our code with the completion.
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-button
branch
from
d2db4aa
to
4a7b8cf
Compare
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Replace Grommet Button components
Proposal