Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️(frontend) replace grommet TextArea with cunningham TextArea #2500

Merged
merged 5 commits into from
Nov 13, 2023

Conversation

AntoLC
Copy link
Contributor

@AntoLC AntoLC commented Nov 9, 2023

Purpose

In order to do the transition to the cunningham design system,
we replace the grommet TextArea component with the
cunningham TextArea components.

Proposal

  • replace TextArea by cunningham one

@AntoLC AntoLC self-assigned this Nov 9, 2023
@AntoLC AntoLC force-pushed the refacto/anthony/replace-textarea-grommet branch 3 times, most recently from f2b701d to 155d5c9 Compare November 10, 2023 11:13
@AntoLC AntoLC marked this pull request as ready for review November 10, 2023 11:18
Copy link
Member

@lunika lunika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You have modified the color used in the input type text, it is black now and I don't where it has been changed in this PR... but in master it's the good color
    image

  • In the commit 🐛(lib-classroom) fix description update from another user you mention the websocket but no websocket is used for the classroom resource.

@AntoLC AntoLC force-pushed the refacto/anthony/replace-textarea-grommet branch 2 times, most recently from 39b8a52 to 5ac99fa Compare November 13, 2023 10:06
@AntoLC
Copy link
Contributor Author

AntoLC commented Nov 13, 2023

Fixes:

  • You have modified the color used in the input type text, it is black now and I don't where it has been changed in this PR... but in master it's the good color
    image

Yes, fix here: 5e2bfaa#diff-522e0e6a642a595b19b95b239ee5df0f4546d578b792267534b2abe33c29bb00R85


  • In the commit 🐛(lib-classroom) fix description update from another user you mention the websocket but no websocket is used for the classroom resource.

I replace websocket by polling in the commit description: 4c60279


I fixed the box out of screen in this commit: 5ac99fa

image

@AntoLC AntoLC requested a review from lunika November 13, 2023 10:15
In order to do the transition to the cunningham design system,
we replace the grommet TextArea component with the
cunningham TextArea components.
- If the user was a bit slow to write in the recording purpose textarea,
his input was overwritten by his own recording.
- Only the last update was sent to the backend, so if you were updated
2 toggles quickly, only the last one was updated in backend
The description textarea didn't seem to be updated when a update
occured from another user (polling).
Many custom tokens could be generated in the cunningham way,
this commit does it.
The recording dashed box was out of screen, this commit fix it.
@AntoLC AntoLC force-pushed the refacto/anthony/replace-textarea-grommet branch from 5ac99fa to d094384 Compare November 13, 2023 12:49
@AntoLC AntoLC enabled auto-merge (rebase) November 13, 2023 12:49
@AntoLC AntoLC merged commit 5ad2490 into master Nov 13, 2023
31 of 33 checks passed
@AntoLC AntoLC deleted the refacto/anthony/replace-textarea-grommet branch November 13, 2023 13:01
lunika added a commit that referenced this pull request Nov 29, 2023
Added

- Meta description and meta title on the website from the API (#2516)
- Retrieve BBB learning analytics and send them through API
- Classroom attendance analytics (#2499)
- Add a language picker for the invite link on the website (#2504)

Changed

- Replace grommet DropButton component (#2513)
- On live, can now share resource when one is already shared (#2512)
- Remove persistency on token from invite link (#2505)
- Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503)
- Refacto widgets SharedLiveMedia (#2504)
- Replace grommet Button (#2453)
- Replace grommet Box (#2484)
- Replace grommet TextArea (#2500)
- Update psycopg to version 3
- Update node to version 20
- Replace pylti with oauthlib for LTI request validation
- Replace faker with @faker-js/faker (frontend)

Fixed

- Blocking error when shared document is deleted (#2504)
- Improve render sharing picture in live (#2508)
lunika added a commit that referenced this pull request Nov 29, 2023
Added

- Meta description and meta title on the website from the API (#2516)
- Retrieve BBB learning analytics and send them through API
- Classroom attendance analytics (#2499)
- Add a language picker for the invite link on the website (#2504)

Changed

- Replace grommet DropButton component (#2513)
- On live, can now share resource when one is already shared (#2512)
- Remove persistency on token from invite link (#2505)
- Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503)
- Refacto widgets SharedLiveMedia (#2504)
- Replace grommet Button (#2453)
- Replace grommet Box (#2484)
- Replace grommet TextArea (#2500)
- Update psycopg to version 3
- Update node to version 20
- Replace pylti with oauthlib for LTI request validation
- Replace faker with @faker-js/faker (frontend)

Fixed

- Blocking error when shared document is deleted (#2504)
- Improve render sharing picture in live (#2508)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants