♻️(frontend) replace grommet TextArea with cunningham TextArea #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/anthony/replace-textarea-grommet
branch
3 times, most recently
from
f2b701d
to
155d5c9
Compare
lunika
reviewed
Nov 10, 2023
There was a problem hiding this comment.
-
You have modified the color used in the input type text, it is black now and I don't where it has been changed in this PR... but in master it's the good color
-
In the commit
🐛(lib-classroom) fix description update from another useryou mention the websocket but no websocket is used for the classroom resource.
kernicPanel
approved these changes
Nov 13, 2023
AntoLC
force-pushed
the
refacto/anthony/replace-textarea-grommet
branch
2 times, most recently
from
39b8a52
to
5ac99fa
Compare
Fixes:
Yes, fix here: 5e2bfaa#diff-522e0e6a642a595b19b95b239ee5df0f4546d578b792267534b2abe33c29bb00R85
I replace I fixed the box out of screen in this commit: 5ac99fa
|
lunika
approved these changes
Nov 13, 2023
In order to do the transition to the cunningham design system, we replace the grommet TextArea component with the cunningham TextArea components.
- If the user was a bit slow to write in the recording purpose textarea, his input was overwritten by his own recording. - Only the last update was sent to the backend, so if you were updated 2 toggles quickly, only the last one was updated in backend
The description textarea didn't seem to be updated when a update occured from another user (polling).
Many custom tokens could be generated in the cunningham way, this commit does it.
The recording dashed box was out of screen, this commit fix it.
AntoLC
force-pushed
the
refacto/anthony/replace-textarea-grommet
branch
from
5ac99fa
to
d094384
Compare
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to do the transition to the cunningham design system,
we replace the grommet TextArea component with the
cunningham TextArea components.
Proposal