✨Site config meta #2516
Merged
✨Site config meta #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/anthony/site-config-meta
branch
2 times, most recently
from
99eab28
to
128d79b
Compare
lunika
reviewed
Nov 27, 2023
| meta_title = models.TextField( | ||
| verbose_name=_("meta title"), | ||
| help_text=_("The meta title of the site"), | ||
| default="Marsha", |
There was a problem hiding this comment.
Suggested change
| default="Marsha", | |
| null=True, | |
| blank=True, |
IMO no default should be added and the field must be null
| meta_description = models.TextField( | ||
| verbose_name=_("meta description"), | ||
| help_text=_("The meta description of the site"), | ||
| default="Marsha", |
There was a problem hiding this comment.
Suggested change
| default="Marsha", | |
| null=True, | |
| blank=True, |
kernicPanel
approved these changes
Nov 28, 2023
AntoLC
force-pushed
the
feature/anthony/site-config-meta
branch
from
b1b4e7a
to
0977785
Compare
lunika
approved these changes
Nov 28, 2023
AntoLC
force-pushed
the
feature/anthony/site-config-meta
branch
from
0977785
to
1e5d8be
Compare
We can now personalize the meta title and description per site. Add the fields to the site config model and add them to the config API.
If the site config has a meta title and description, we use it for the site. Otherwise, we use the default values.
AntoLC
force-pushed
the
feature/anthony/site-config-meta
branch
from
1e5d8be
to
0a6cff3
Compare
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When we created a site, it was still the meta of the default website that was displayed.
Proposal
meta_descriptionandmeta_titleinsite_configmeta_descriptionandmeta_titlein the site if available