♻️ replace grommet box part 2 #2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-box-part-2
branch
2 times, most recently
from
43a7649
to
a1d8de7
Compare
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-box
branch
2 times, most recently
from
a955180
to
63fe7ec
Compare
Base automatically changed from
refacto/anthony/replace-grommet-box
to
master
November 3, 2023 12:03
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-box-part-2
branch
2 times, most recently
from
9c1f3eb
to
51267b9
Compare
When ThemeContext.Extend is a child of a custom Box component with a ref prop, the ThemeContext seems to lose the base theme. This happen only during tests, so with the jsdom environment. So if the base theme is undefined, we set it again to pass the test.
Some labels have to be translated again because of the change to the Cunningham Select component. We change the id of the label to help to find the one's that have to be translated.
When we refactorized the buttons, the design of the buttons when we ask the username before to access a classroom was not good. We improve the design of the buttons.
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-box-part-2
branch
5 times, most recently
from
aa78e26
to
797c938
Compare
In order to do the transition to the cunningham design system, in lti, we replace the grommet Box component with our custom Box components.
In order to do the transition to the cunningham design system, in lib-component, we replace the grommet Box component with our custom Box components. To adapt with the changes in lib-component, we also have to change some components apps and other packages.
In order to do the transition to the cunningham design system, in lib-classroom, we replace the grommet Box component with our custom Box components.
In order to do the transition to the cunningham design system, in lib-markdown, we replace the grommet Box component with our custom Box components.
In order to do the transition to the cunningham design system, in lib-video, we replace the grommet Box component with our custom Box components.
The grommet theme colors are correctly displayed only by grommet components, we change the color of the grommet components to the cunningham color.
AntoLC
force-pushed
the
refacto/anthony/replace-grommet-box-part-2
branch
from
797c938
to
11b3181
Compare
kernicPanel
approved these changes
Nov 7, 2023
lunika
approved these changes
Nov 7, 2023
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
lti_sitelib_classroomlib_commonlib_componentslib_markdownlib_video