✨(classroom) attendences analytics #2499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/anthony/classroom-attendees
branch
3 times, most recently
from
222d93d
to
e0f309f
Compare
AntoLC
requested review from
kernicPanel and
lunika
and removed request for
kernicPanel and
lunika
kernicPanel
reviewed
Nov 9, 2023
AntoLC
force-pushed
the
feature/anthony/classroom-attendees
branch
from
ee38ad3
to
48527e2
Compare
|
The changes talked during the daily. scrnli_11_9_2023_12-47-47.PM.webm |
AntoLC
requested review from
kernicPanel and
lunika
and removed request for
kernicPanel and
lunika
AntoLC
force-pushed
the
feature/anthony/classroom-attendees
branch
2 times, most recently
from
1b43eba
to
3f01ddf
Compare
scrnli_11_10_2023_3-58-04.PM.webm |
lunika
reviewed
Nov 10, 2023
| description: 'Message displayed if the live has no participant yet', | ||
| id: 'components.DashboardLiveControlPane.tab.DashboardLiveTabAttendance.DashboardLiveTabAttendanceWaiting.noParticipants', | ||
| }, | ||
| }); | ||
|
|
||
| export const DashboardLiveTabAttendanceWaiting = ({}) => { | ||
| interface TabAttendanceWaitingProps { | ||
| type: 'live' | 'classroom'; |
There was a problem hiding this comment.
Suggested change
| type: 'live' | 'classroom'; | |
| type: 'webinar' | 'classroom'; |
There was a problem hiding this comment.
| @@ -1,5 +1,5 @@ | |||
| import { Nullable, colorsTokens } from 'lib-common'; | |||
| import { Box, BoxProps } from 'lib-components'; | |||
| import { Breakpoints, Nullable, colorsTokens } from 'lib-common'; | |||
There was a problem hiding this comment.
In the commit title, replace devise by device
| @@ -180,6 +180,9 @@ describe('<ClassroomAttendance />', () => { | |||
| { | |||
| intlOptions: { | |||
| locale: 'fr', | |||
| messages: { | |||
| 'components.ClassroomAttendance.durationLabel': 'Durée', | |||
AntoLC
force-pushed
the
feature/anthony/classroom-attendees
branch
3 times, most recently
from
16981c1
to
be003c0
Compare
lunika
approved these changes
Nov 13, 2023
Add sessions interface to classroom models.
Move DashboardLiveTabAttendanceWaiting to lib-components. The component is renamed TabAttendanceWaiting, we refactorize it to be more generic and reusable for the classroom package.
We create a new tab in the classroom dashboard to show the attendance of the students in the classroom.
On the small device the margin was too big and the content was not displayed correctly. We reduce it depend the devise size, plus we remove some global margin.
We can now pass more options to the wrapInIntlProvider function. This will allow us to test easily translated texts.
AntoLC
force-pushed
the
feature/anthony/classroom-attendees
branch
from
be003c0
to
ddd6145
Compare
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Feature request: #2492
Proposal
scrnli_11_8_2023_5-07-28.PM.webm