Allow patch on allowedRoles #1143

derek-ho · 2023-10-19T14:47:45Z

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>

codecov · 2023-10-19T15:07:58Z

Codecov Report

Merging #1143 (d2af1d4) into main (7f6b95e) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d2af1d4 differs from pull request most recent head b8ef006. Consider uploading reports for the commit b8ef006 to get more accurate results

@@            Coverage Diff             @@
##             main    #1143      +/-   ##
==========================================
+ Coverage   44.20%   44.21%   +0.01%     
==========================================
  Files         327      329       +2     
  Lines       19487    19541      +54     
  Branches     4643     4719      +76     
==========================================
+ Hits         8614     8640      +26     
+ Misses      10828    10334     -494     
- Partials       45      567     +522

Flag	Coverage Δ
dashboards-observability	`44.21% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 90 files with indirect coverage changes

Signed-off-by: Derek Ho <dxho@amazon.com>

server/routes/data_connections/data_connections_router.ts

public/components/datasources/components/manage/access_control_tab.tsx

ps48

minor comments

Signed-off-by: Derek Ho <dxho@amazon.com>

* Allow patch on allowedRoles Signed-off-by: Derek Ho <dxho@amazon.com> * Change for patch Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> (cherry picked from commit cccfebf) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Allow patch on allowedRoles * Change for patch * Address PR comments --------- (cherry picked from commit cccfebf) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…ject#1143) * Fixed bug for save query and visualizations Signed-off-by: ruchika-narang <ruchika_narang@persistent.com> * updated snapshots Signed-off-by: ruchika-narang <ruchika_narang@persistent.com> * Removed extra line of codes from bar Signed-off-by: ruchika-narang <ruchika_narang@persistent.com> * Removed check for boolean and reverted dashboard json file Signed-off-by: ruchika-narang <ruchika_narang@persistent.com> * Fixed line chart add dimension issue Signed-off-by: ruchika-narang <ruchika_narang@persistent.com> * Fixed issue for stats Signed-off-by: ruchika-narang <ruchika_narang@persistent.com> * Resolved comments Signed-off-by: ruchika-narang <ruchika_narang@persistent.com> Signed-off-by: ruchika-narang <ruchika_narang@persistent.com>

…arch-project#1145)" This reverts commit 0acc0f3.

…arch-project#1145)" This reverts commit 0acc0f3. Signed-off-by: Eric <menwe@amazon.com>

* Revert "Update empty allowed roles to admin only (#1217) (#1220)" This reverts commit 4288504. Signed-off-by: Eric <menwe@amazon.com> * Revert "Increment version to 2.11.1.0 (#1190)" This reverts commit ccd5fb8. Signed-off-by: Eric <menwe@amazon.com> * Revert "Add S3 integration for Nginx and VPC (#1214) (#1216)" This reverts commit e0a509c. Signed-off-by: Eric <menwe@amazon.com> * Revert "disabling inspect and default pattern/timestamp buttons when using async data sources (#1205) (#1212)" This reverts commit ca5ad02. Signed-off-by: Eric <menwe@amazon.com> * Revert "Saved object datasource backward compatibility fixes (#1208) (#1210)" This reverts commit 467a0b3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Link integrations from datasources UI (#1203) (#1207)" This reverts commit 8e9fe5e. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Fixes for cancel button and saved object loading (#1197) (#1201)" This reverts commit f0e7a9d. Signed-off-by: Eric <menwe@amazon.com> * Revert "Correct query schema for ELB mview generation (#1196) (#1199)" This reverts commit 0b7be95. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Backport 2.11] Add integrations queries for Flint (#1195)" This reverts commit 97f46ba. Signed-off-by: Eric <menwe@amazon.com> * Revert "remove husky pre-commit checks (#1192) (#1193)" This reverts commit 25d52f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Bug fixes for observability count distribution and application analytics (#1187) (#1189)" This reverts commit e2440d2. Signed-off-by: Eric <menwe@amazon.com> * Revert "Support cancellation of async queries (#1177) (#1186)" This reverts commit 6b495f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Supports session for s3 direct query (#1178) (#1183)" This reverts commit d50047f. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Modify text in empty prompt (#1172) (#1182)" This reverts commit 95a60cc. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Feature] Match discover look and feel (#1135) (#1179)" This reverts commit b69801e. Signed-off-by: Eric <menwe@amazon.com> * Revert "config panel dark mode fix (#1169) (#1176)" This reverts commit 34696b3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Fix events home table and toast life time (#1170)" This reverts commit a9b36fc. Signed-off-by: Eric <menwe@amazon.com> * Revert "Quiet react-dnd draggableId/droppableId warnings. (#1147) (#1166)" This reverts commit a2f9a00. Signed-off-by: Eric <menwe@amazon.com> * Revert "Fix integration labeling to identify S3 integrations (#1157) (#1164)" This reverts commit 9de9aea. Signed-off-by: Eric <menwe@amazon.com> * Revert "Remove loading progress for integration setup (#1156) (#1162)" This reverts commit a08721b. Signed-off-by: Eric <menwe@amazon.com> * Revert "Switch from toast to callout for integration set up failures (#1155) (#1159)" This reverts commit e6a474a. Signed-off-by: Eric <menwe@amazon.com> * Revert "Disable integration set up button if invalid (#1152) (#1161)" This reverts commit 74aae17. Signed-off-by: Eric <menwe@amazon.com> * Revert "Update URL of create datasources, fix spacing (#1149) (#1154)" This reverts commit 0b66d83. Signed-off-by: Eric <menwe@amazon.com> * Revert "Allow patch on allowedRoles (#1143) (#1145)" This reverts commit 0acc0f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "fix for explorer data grid not paginating (#1139) (#1141)" This reverts commit c5ead50. Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com>

…ject#1144) * Allow patch on allowedRoles * Change for patch * Address PR comments --------- (cherry picked from commit cccfebf) Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit d5e7636)

Allow patch on allowedRoles

c549774

Signed-off-by: Derek Ho <dxho@amazon.com>

derek-ho requested review from pjfitzgibbons, ps48, kavithacm, joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsi-amazon, Swiddis, penghuo, seankao-az and anirudha as code owners October 19, 2023 14:47

derek-ho added backport 2.x backport 2.11 labels Oct 19, 2023

Change for patch

d2af1d4

Signed-off-by: Derek Ho <dxho@amazon.com>

Swiddis approved these changes Oct 19, 2023

View reviewed changes

ps48 reviewed Oct 19, 2023

View reviewed changes

server/routes/data_connections/data_connections_router.ts Outdated Show resolved Hide resolved

ps48 reviewed Oct 19, 2023

View reviewed changes

public/components/datasources/components/manage/access_control_tab.tsx Outdated Show resolved Hide resolved

ps48 approved these changes Oct 19, 2023

View reviewed changes

Address PR comments

b8ef006

Signed-off-by: Derek Ho <dxho@amazon.com>

derek-ho merged commit cccfebf into opensearch-project:main Oct 20, 2023
7 checks passed

This was referenced Oct 20, 2023

[Backport 2.x] Allow patch on allowedRoles #1144

Merged

[Backport 2.11] Allow patch on allowedRoles #1145

Merged

mengweieric added a commit to mengweieric/dashboards-observability that referenced this pull request Nov 8, 2023

Revert "Allow patch on allowedRoles (opensearch-project#1143) (opense…

a7ef63d

…arch-project#1145)" This reverts commit 0acc0f3.

mengweieric added a commit to mengweieric/dashboards-observability that referenced this pull request Nov 8, 2023

Revert "Allow patch on allowedRoles (opensearch-project#1143) (opense…

bc88efb

…arch-project#1145)" This reverts commit 0acc0f3. Signed-off-by: Eric <menwe@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow patch on allowedRoles #1143

Allow patch on allowedRoles #1143

derek-ho commented Oct 19, 2023

codecov bot commented Oct 19, 2023 •

edited

Loading

ps48 left a comment

Allow patch on allowedRoles #1143

Allow patch on allowedRoles #1143

Conversation

derek-ho commented Oct 19, 2023

Description

Issues Resolved

Check List

codecov bot commented Oct 19, 2023 • edited Loading

Codecov Report

ps48 left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 19, 2023 •

edited

Loading