[Backport 2.11] [Feature] Match discover look and feel #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * missing snapshots Signed-off-by: Eric Wei <menwe@amazon.com> * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * move sidebar out of explorer for match look and feel Signed-off-by: Eric <menwe@amazon.com> * sidebar panel always with full height Signed-off-by: Eric <menwe@amazon.com> * adjust padding Signed-off-by: Eric <menwe@amazon.com> * make search components wrappable Signed-off-by: Eric <menwe@amazon.com> * adjust noresult/novisualize page Signed-off-by: Eric <menwe@amazon.com> * add padding to datagrid Signed-off-by: Eric <menwe@amazon.com> * restructured sidebar fields to use exact same spacing/paneling as discover, so that field type icons look the same and field action buttons disappear if not hovered over Signed-off-by: Paul Sebastian <paulstn@amazon.com> * address datasource persistency issue Signed-off-by: Eric <menwe@amazon.com> * code changes preparing for integration with app analytics Signed-off-by: Eric <menwe@amazon.com> * resolve page crash and hide datasource for app analytics Signed-off-by: Eric <menwe@amazon.com> * saved object supports datasources, query language, and direct query Signed-off-by: Eric <menwe@amazon.com> * change saved object icon Signed-off-by: Eric <menwe@amazon.com> * bulk delete for saved query Signed-off-by: Eric <menwe@amazon.com> * change data grid to separate sort/page query to not interfere with other components Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic drag and drop added Signed-off-by: Paul Sebastian <paulstn@amazon.com> * viz config changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add margin to resizable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * wrap countdistribution with panel Signed-off-by: Eric <menwe@amazon.com> * pr requested changes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove panel wrapper for inner countdistribution Signed-off-by: Eric <menwe@amazon.com> * change datasource selector to only showopensearch/ default cluste Signed-off-by: Eric <menwe@amazon.com> * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * missing snapshots Signed-off-by: Eric Wei <menwe@amazon.com> * remove unused files Signed-off-by: Eric Wei <menwe@amazon.com> * url datasource data prsing and clean up Signed-off-by: Eric <menwe@amazon.com> * minor format Signed-off-by: Eric <menwe@amazon.com> * query bar issue when loading direct query saved object Signed-off-by: Eric <menwe@amazon.com> * minor cleanup Signed-off-by: Eric <menwe@amazon.com> * update snapshots Signed-off-by: Eric <menwe@amazon.com> * fix minor query bar issue and add types to searchMeta slice Signed-off-by: Eric <menwe@amazon.com> * stop polling when load from saved object and few related minor changes Signed-off-by: Eric <menwe@amazon.com> * fix polling cleanup issue Signed-off-by: Eric <menwe@amazon.com> * save will not trigger reload Signed-off-by: Eric <menwe@amazon.com> * add language enum Signed-off-by: Eric <menwe@amazon.com> * direct query status indicator Signed-off-by: Paul Sebastian <paulstn@amazon.com> * turn default timestamp/pattern mark to badge and on hover Signed-off-by: Paul Sebastian <paulstn@amazon.com> * flyout resize button margin fix Signed-off-by: Paul Sebastian <paulstn@amazon.com> * direct query data grid fixes Signed-off-by: Paul Sebastian <paulstn@amazon.com> * pr changes and added test Signed-off-by: Paul Sebastian <paulstn@amazon.com> * removed console logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * searchMetaData type change Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use datasource variable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed types and reduced redundancy Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fixed when data grix shows Signed-off-by: Paul Sebastian <paulstn@amazon.com> * simplify condition checking for datagrid Signed-off-by: Eric <menwe@amazon.com> * update snapshot Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> (cherry picked from commit ea2fb2c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
mengweieric
approved these changes
Oct 25, 2023
ps48
approved these changes
Oct 25, 2023
mengweieric
added a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Nov 8, 2023
…) (opensearch-project#1179)" This reverts commit b69801e.
mengweieric
added a commit
to mengweieric/dashboards-observability
that referenced
this pull request
Nov 8, 2023
…) (opensearch-project#1179)" This reverts commit b69801e. Signed-off-by: Eric <menwe@amazon.com>
mengweieric
added a commit
that referenced
this pull request
Nov 13, 2023
* Revert "Update empty allowed roles to admin only (#1217) (#1220)" This reverts commit 4288504. Signed-off-by: Eric <menwe@amazon.com> * Revert "Increment version to 2.11.1.0 (#1190)" This reverts commit ccd5fb8. Signed-off-by: Eric <menwe@amazon.com> * Revert "Add S3 integration for Nginx and VPC (#1214) (#1216)" This reverts commit e0a509c. Signed-off-by: Eric <menwe@amazon.com> * Revert "disabling inspect and default pattern/timestamp buttons when using async data sources (#1205) (#1212)" This reverts commit ca5ad02. Signed-off-by: Eric <menwe@amazon.com> * Revert "Saved object datasource backward compatibility fixes (#1208) (#1210)" This reverts commit 467a0b3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Link integrations from datasources UI (#1203) (#1207)" This reverts commit 8e9fe5e. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Fixes for cancel button and saved object loading (#1197) (#1201)" This reverts commit f0e7a9d. Signed-off-by: Eric <menwe@amazon.com> * Revert "Correct query schema for ELB mview generation (#1196) (#1199)" This reverts commit 0b7be95. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Backport 2.11] Add integrations queries for Flint (#1195)" This reverts commit 97f46ba. Signed-off-by: Eric <menwe@amazon.com> * Revert "remove husky pre-commit checks (#1192) (#1193)" This reverts commit 25d52f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Bug fixes for observability count distribution and application analytics (#1187) (#1189)" This reverts commit e2440d2. Signed-off-by: Eric <menwe@amazon.com> * Revert "Support cancellation of async queries (#1177) (#1186)" This reverts commit 6b495f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Supports session for s3 direct query (#1178) (#1183)" This reverts commit d50047f. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Modify text in empty prompt (#1172) (#1182)" This reverts commit 95a60cc. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Feature] Match discover look and feel (#1135) (#1179)" This reverts commit b69801e. Signed-off-by: Eric <menwe@amazon.com> * Revert "config panel dark mode fix (#1169) (#1176)" This reverts commit 34696b3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Fix events home table and toast life time (#1170)" This reverts commit a9b36fc. Signed-off-by: Eric <menwe@amazon.com> * Revert "Quiet react-dnd draggableId/droppableId warnings. (#1147) (#1166)" This reverts commit a2f9a00. Signed-off-by: Eric <menwe@amazon.com> * Revert "Fix integration labeling to identify S3 integrations (#1157) (#1164)" This reverts commit 9de9aea. Signed-off-by: Eric <menwe@amazon.com> * Revert "Remove loading progress for integration setup (#1156) (#1162)" This reverts commit a08721b. Signed-off-by: Eric <menwe@amazon.com> * Revert "Switch from toast to callout for integration set up failures (#1155) (#1159)" This reverts commit e6a474a. Signed-off-by: Eric <menwe@amazon.com> * Revert "Disable integration set up button if invalid (#1152) (#1161)" This reverts commit 74aae17. Signed-off-by: Eric <menwe@amazon.com> * Revert "Update URL of create datasources, fix spacing (#1149) (#1154)" This reverts commit 0b66d83. Signed-off-by: Eric <menwe@amazon.com> * Revert "Allow patch on allowedRoles (#1143) (#1145)" This reverts commit 0acc0f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "fix for explorer data grid not paginating (#1139) (#1141)" This reverts commit c5ead50. Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com>
pjfitzgibbons
added a commit
that referenced
this pull request
Nov 27, 2023
#1179 was part of the revert commit. Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ea2fb2c from #1135.