-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove loading progress for integration setup #1156
Conversation
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Depends on #1155, wanted to avoid merge conflicts later. Review that one first. |
Codecov Report
@@ Coverage Diff @@
## main #1156 +/- ##
=======================================
Coverage 44.22% 44.23%
=======================================
Files 329 329
Lines 19552 19545 -7
Branches 4723 4722 -1
=======================================
- Hits 8647 8645 -2
+ Misses 10337 10332 -5
Partials 568 568
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.11 2.11
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.11
# Create a new branch
git switch --create backport/backport-1156-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6d07d6f5badfe9955b6b3da4720d6f14e2674850
# Push it to GitHub
git push --set-upstream origin backport/backport-1156-to-2.11
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.11 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-observability/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-observability/backport-2.x
# Create a new branch
git switch --create backport/backport-1156-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6d07d6f5badfe9955b6b3da4720d6f14e2674850
# Push it to GitHub
git push --set-upstream origin backport/backport-1156-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-observability/backport-2.x Then, create a pull request where the |
* Switch from toast to callout for set up failures Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix label selection for truncated labels Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix button color Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove loading progress bar Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 6d07d6f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Switch from toast to callout for set up failures Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix label selection for truncated labels Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix button color Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Fix tests Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove loading progress bar Signed-off-by: Simeon Widdis <sawiddis@amazon.com> * Remove unused imports Signed-off-by: Simeon Widdis <sawiddis@amazon.com> --------- Signed-off-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 6d07d6f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Switch from toast to callout for set up failures * Fix label selection for truncated labels * Fix button color * Fix tests * Remove loading progress bar * Remove unused imports --------- (cherry picked from commit 6d07d6f) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Switch from toast to callout for set up failures * Fix label selection for truncated labels * Fix button color * Fix tests * Remove loading progress bar * Remove unused imports --------- (cherry picked from commit 6d07d6f) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ject#1156) (opensearch-project#1162)" This reverts commit a08721b. Signed-off-by: Eric <menwe@amazon.com>
* Revert "Update empty allowed roles to admin only (#1217) (#1220)" This reverts commit 4288504. Signed-off-by: Eric <menwe@amazon.com> * Revert "Increment version to 2.11.1.0 (#1190)" This reverts commit ccd5fb8. Signed-off-by: Eric <menwe@amazon.com> * Revert "Add S3 integration for Nginx and VPC (#1214) (#1216)" This reverts commit e0a509c. Signed-off-by: Eric <menwe@amazon.com> * Revert "disabling inspect and default pattern/timestamp buttons when using async data sources (#1205) (#1212)" This reverts commit ca5ad02. Signed-off-by: Eric <menwe@amazon.com> * Revert "Saved object datasource backward compatibility fixes (#1208) (#1210)" This reverts commit 467a0b3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Link integrations from datasources UI (#1203) (#1207)" This reverts commit 8e9fe5e. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Fixes for cancel button and saved object loading (#1197) (#1201)" This reverts commit f0e7a9d. Signed-off-by: Eric <menwe@amazon.com> * Revert "Correct query schema for ELB mview generation (#1196) (#1199)" This reverts commit 0b7be95. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Backport 2.11] Add integrations queries for Flint (#1195)" This reverts commit 97f46ba. Signed-off-by: Eric <menwe@amazon.com> * Revert "remove husky pre-commit checks (#1192) (#1193)" This reverts commit 25d52f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Bug fixes for observability count distribution and application analytics (#1187) (#1189)" This reverts commit e2440d2. Signed-off-by: Eric <menwe@amazon.com> * Revert "Support cancellation of async queries (#1177) (#1186)" This reverts commit 6b495f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Supports session for s3 direct query (#1178) (#1183)" This reverts commit d50047f. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Explorer] Modify text in empty prompt (#1172) (#1182)" This reverts commit 95a60cc. Signed-off-by: Eric <menwe@amazon.com> * Revert "[Feature] Match discover look and feel (#1135) (#1179)" This reverts commit b69801e. Signed-off-by: Eric <menwe@amazon.com> * Revert "config panel dark mode fix (#1169) (#1176)" This reverts commit 34696b3. Signed-off-by: Eric <menwe@amazon.com> * Revert "Fix events home table and toast life time (#1170)" This reverts commit a9b36fc. Signed-off-by: Eric <menwe@amazon.com> * Revert "Quiet react-dnd draggableId/droppableId warnings. (#1147) (#1166)" This reverts commit a2f9a00. Signed-off-by: Eric <menwe@amazon.com> * Revert "Fix integration labeling to identify S3 integrations (#1157) (#1164)" This reverts commit 9de9aea. Signed-off-by: Eric <menwe@amazon.com> * Revert "Remove loading progress for integration setup (#1156) (#1162)" This reverts commit a08721b. Signed-off-by: Eric <menwe@amazon.com> * Revert "Switch from toast to callout for integration set up failures (#1155) (#1159)" This reverts commit e6a474a. Signed-off-by: Eric <menwe@amazon.com> * Revert "Disable integration set up button if invalid (#1152) (#1161)" This reverts commit 74aae17. Signed-off-by: Eric <menwe@amazon.com> * Revert "Update URL of create datasources, fix spacing (#1149) (#1154)" This reverts commit 0b66d83. Signed-off-by: Eric <menwe@amazon.com> * Revert "Allow patch on allowedRoles (#1143) (#1145)" This reverts commit 0acc0f3. Signed-off-by: Eric <menwe@amazon.com> * Revert "fix for explorer data grid not paginating (#1139) (#1141)" This reverts commit c5ead50. Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com>
… (opensearch-project#1163) * Switch from toast to callout for set up failures * Fix label selection for truncated labels * Fix button color * Fix tests * Remove loading progress bar * Remove unused imports --------- (cherry picked from commit 6d07d6f) Signed-off-by: Simeon Widdis <sawiddis@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit ca1eccd)
Description
Continuing a streak of fulfilling UX feedback, this PR removes the progress bar from the loading screen, opting for the standard EmptyPrompt pattern. More work will need to be done to show progress in some form, even if the existing progress bar didn't make the cut, since leaving no progress indicator for a very long-running task seems a little mean.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.