Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explorer] Fixes for cancel button and saved object loading #1197

Merged
merged 8 commits into from
Oct 27, 2023
Merged

[Explorer] Fixes for cancel button and saved object loading #1197

merged 8 commits into from
Oct 27, 2023

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Oct 27, 2023 •
edited
Loading

Description

  • Cancel button not working
  • Saved object not picking session id up
  • Status not updated on query processing page
  • Move event explorer button out of actions

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mengweieric
remove unused files
025d3f6 
Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric
missing snapshots
307a73a 
Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric
remove unused files
28c4563 
Signed-off-by: Eric Wei <menwe@amazon.com>
@mengweieric
move explorer button out of actions
db71bcd 
Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
fix cancel button isn't working issue
394e0e0 
Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
add sessionId to saved object loader
c128e5c 
Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
update snapshots
b6265a8 
Signed-off-by: Eric <menwe@amazon.com>
@mengweieric
status update issue on object loading
185d0a3 
Signed-off-by: Eric <menwe@amazon.com>
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #1197 (185d0a3) into main (22b6fc6) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1197   +/-   ##
=======================================
  Coverage   44.01%   44.01%           
=======================================
  Files         328      328           
  Lines       19644    19644           
  Branches     4730     4730           
=======================================
  Hits         8646     8646           
  Misses      10421    10421           
  Partials      577      577
Flag Coverage Δ
dashboards-observability 44.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mengweieric mengweieric merged commit e4e2bca into opensearch-project:main Oct 27, 2023
11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 27, 2023
@github-actions
[Explorer] Fixes for cancel button and saved object loading (#1197)
5de44f9 
* remove unused files

Signed-off-by: Eric Wei <menwe@amazon.com>

* missing snapshots

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove unused files

Signed-off-by: Eric Wei <menwe@amazon.com>

* move explorer button out of actions

Signed-off-by: Eric <menwe@amazon.com>

* fix cancel button isn't working issue

Signed-off-by: Eric <menwe@amazon.com>

* add sessionId to saved object loader

Signed-off-by: Eric <menwe@amazon.com>

* update snapshots

Signed-off-by: Eric <menwe@amazon.com>

* status update issue on object loading

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
(cherry picked from commit e4e2bca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 27, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 27, 2023
@github-actions
[Explorer] Fixes for cancel button and saved object loading (#1197)
462c690 
* remove unused files

Signed-off-by: Eric Wei <menwe@amazon.com>

* missing snapshots

Signed-off-by: Eric Wei <menwe@amazon.com>

* remove unused files

Signed-off-by: Eric Wei <menwe@amazon.com>

* move explorer button out of actions

Signed-off-by: Eric <menwe@amazon.com>

* fix cancel button isn't working issue

Signed-off-by: Eric <menwe@amazon.com>

* add sessionId to saved object loader

Signed-off-by: Eric <menwe@amazon.com>

* update snapshots

Signed-off-by: Eric <menwe@amazon.com>

* status update issue on object loading

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
(cherry picked from commit e4e2bca)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 27, 2023
Merged
mengweieric pushed a commit that referenced this pull request Oct 27, 2023
@opensearch-trigger-bot @github-actions
[Explorer] Fixes for cancel button and saved object loading (#1197) (#…
f0e7a9d 
…1201)

* remove unused files



* missing snapshots



* remove unused files



* move explorer button out of actions



* fix cancel button isn't working issue



* add sessionId to saved object loader



* update snapshots



* status update issue on object loading



---------



(cherry picked from commit e4e2bca)

Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit that referenced this pull request Oct 27, 2023
@opensearch-trigger-bot @github-actions
[Explorer] Fixes for cancel button and saved object loading (#1197) (#…
a1234af 
…1200)

* remove unused files



* missing snapshots



* remove unused files



* move explorer button out of actions



* fix cancel button isn't working issue



* add sessionId to saved object loader



* update snapshots



* status update issue on object loading



---------



(cherry picked from commit e4e2bca)

Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric added a commit to mengweieric/dashboards-observability that referenced this pull request Nov 8, 2023
@mengweieric
Revert "[Explorer] Fixes for cancel button and saved object loading (o…
0f3553d 
…pensearch-project#1197) (opensearch-project#1201)"

This reverts commit f0e7a9d.
mengweieric added a commit to mengweieric/dashboards-observability that referenced this pull request Nov 8, 2023
@mengweieric
Revert "[Explorer] Fixes for cancel button and saved object loading (o…
06bbd29 
…pensearch-project#1197) (opensearch-project#1201)"

This reverts commit f0e7a9d.

Signed-off-by: Eric <menwe@amazon.com>
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert commits back to after 2.11 release (#1231)
c170e58 
* Revert "Update empty allowed roles to admin only (#1217) (#1220)"

This reverts commit 4288504.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Increment version to 2.11.1.0 (#1190)"

This reverts commit ccd5fb8.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Add S3 integration for Nginx and VPC (#1214) (#1216)"

This reverts commit e0a509c.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "disabling inspect and default pattern/timestamp buttons when using async data sources (#1205) (#1212)"

This reverts commit ca5ad02.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Saved object datasource backward compatibility fixes (#1208) (#1210)"

This reverts commit 467a0b3.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Link integrations from datasources UI (#1203) (#1207)"

This reverts commit 8e9fe5e.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "[Explorer] Fixes for cancel button and saved object loading (#1197) (#1201)"

This reverts commit f0e7a9d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Correct query schema for ELB mview generation (#1196) (#1199)"

This reverts commit 0b7be95.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "[Backport 2.11] Add integrations queries for Flint (#1195)"

This reverts commit 97f46ba.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "remove husky pre-commit checks (#1192) (#1193)"

This reverts commit 25d52f3.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Bug fixes for observability count distribution and application analytics (#1187) (#1189)"

This reverts commit e2440d2.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Support cancellation of async queries (#1177) (#1186)"

This reverts commit 6b495f3.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "[Explorer] Supports session for s3 direct query (#1178) (#1183)"

This reverts commit d50047f.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "[Explorer] Modify text in empty prompt (#1172) (#1182)"

This reverts commit 95a60cc.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "[Feature] Match discover look and feel (#1135) (#1179)"

This reverts commit b69801e.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "config panel dark mode fix (#1169) (#1176)"

This reverts commit 34696b3.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Fix events home table and toast life time (#1170)"

This reverts commit a9b36fc.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Quiet react-dnd draggableId/droppableId warnings. (#1147) (#1166)"

This reverts commit a2f9a00.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Fix integration labeling to identify S3 integrations (#1157) (#1164)"

This reverts commit 9de9aea.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Remove loading progress for integration setup (#1156) (#1162)"

This reverts commit a08721b.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Switch from toast to callout for integration set up failures (#1155) (#1159)"

This reverts commit e6a474a.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Disable integration set up button if invalid (#1152) (#1161)"

This reverts commit 74aae17.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Update URL of create datasources, fix spacing (#1149) (#1154)"

This reverts commit 0b66d83.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Allow patch on allowedRoles (#1143) (#1145)"

This reverts commit 0acc0f3.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "fix for explorer data grid not paginating (#1139) (#1141)"

This reverts commit c5ead50.

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
@mengweieric mengweieric deleted the fix/redirect-query-loading branch February 14, 2024 18:29
RyanL1997 added a commit to RyanL1997/dashboards-observability that referenced this pull request Apr 18, 2024
@opensearch-trigger-bot @RyanL1997
Add release notes for 2.4.0.0 (opensearch-project#1197) (opensearch-p…
b90232e 
…roject#1198)

Signed-off-by: Ryan Liang <jiallian@amazon.com>
(cherry picked from commit b451cb259125281de6dd081fe92331a0f47bd5ce)

Co-authored-by: Ryan Liang <109499885+RyanL1997@users.noreply.github.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
@opensearch-trigger-bot
[Explorer] Fixes for cancel button and saved object loading (opensear…
3266d53 
…ch-project#1197) (opensearch-project#1200)

* remove unused files

* missing snapshots

* remove unused files

* move explorer button out of actions

* fix cancel button isn't working issue

* add sessionId to saved object loader

* update snapshots

* status update issue on object loading

---------

(cherry picked from commit e4e2bca)

Signed-off-by: Eric Wei <menwe@amazon.com>
Signed-off-by: Eric <menwe@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit a1234af)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YANG-DB YANG-DB YANG-DB approved these changes

@Swiddis Swiddis Swiddis approved these changes

@kavithacm kavithacm kavithacm approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@ps48 ps48 Awaiting requested review from ps48

@derek-ho derek-ho Awaiting requested review from derek-ho

@joshuali925 joshuali925 Awaiting requested review from joshuali925

@dai-chen dai-chen Awaiting requested review from dai-chen

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon

@penghuo penghuo Awaiting requested review from penghuo

@seankao-az seankao-az Awaiting requested review from seankao-az

@anirudha anirudha Awaiting requested review from anirudha

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mengweieric @ps48 @kavithacm @Swiddis @YANG-DB