Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix events home table and toast life time #1170

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Fix events home table and toast life time #1170

merged 3 commits into from
Oct 24, 2023

Conversation

kavithacm
Copy link
Collaborator

@kavithacm kavithacm commented Oct 24, 2023 •
edited
Loading

Description

This is enable multi select in events home table and also decreased the toast life time for live tail

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kavithacm
Fix 2.11 UX issues
8951632 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
Change toast time life
91fc5a9 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
update snapshots
0e089dd 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #1170 (0e089dd) into 2.11 (fba6d30) will increase coverage by 0.61%.
Report is 308 commits behind head on 2.11.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             2.11    #1170      +/-   ##
==========================================
+ Coverage   43.63%   44.25%   +0.61%     
==========================================
  Files         313      329      +16     
  Lines       18594    19535     +941     
  Branches     4484     4722     +238     
==========================================
+ Hits         8114     8645     +531     
+ Misses      10438    10322     -116     
- Partials       42      568     +526
Flag Coverage Δ
dashboards-observability 44.25% <ø> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 145 files with indirect coverage changes

@kavithacm kavithacm merged commit a9b36fc into opensearch-project:2.11 Oct 24, 2023
8 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2023
@github-actions
Fix events home table and toast life time (#1170)
c8725a0 
* Fix 2.11 UX issues

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* Change toast time life

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update snapshots

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

---------

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit a9b36fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Oct 24, 2023
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 24, 2023
@github-actions
Fix events home table and toast life time (#1170)
6d471ec 
* Fix 2.11 UX issues

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* Change toast time life

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update snapshots

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

---------

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
(cherry picked from commit a9b36fc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavithacm pushed a commit that referenced this pull request Oct 24, 2023
@opensearch-trigger-bot @github-actions
Fix events home table and toast life time (#1170) (#1173)
e0f3627 
* Fix 2.11 UX issues



* Change toast time life



* update snapshots



---------


(cherry picked from commit a9b36fc)

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavithacm pushed a commit that referenced this pull request Oct 24, 2023
@opensearch-trigger-bot @github-actions
Fix events home table and toast life time (#1170) (#1174)
acb0c78 
* Fix 2.11 UX issues



* Change toast time life



* update snapshots



---------


(cherry picked from commit a9b36fc)

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric pushed a commit to mengweieric/dashboards-observability that referenced this pull request Oct 30, 2023
@SivaprasadAluri
[BUG]: Visualizations not appearing in Operational Panels fixed (open…
2a5ebe1 
…search-project#1170)

* fixed the bug for operational panel visulaization and app analytics

Signed-off-by: SivaprasadAluri <sivaprasad_aluri@persistent.com>

* updated the code as per review comments

Signed-off-by: SivaprasadAluri <sivaprasad_aluri@persistent.com>

* updated the test sanpshot

Signed-off-by: SivaprasadAluri <sivaprasad_aluri@persistent.com>

Signed-off-by: SivaprasadAluri <sivaprasad_aluri@persistent.com>
mengweieric added a commit to mengweieric/dashboards-observability that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Fix events home table and toast life time (opensearch-project…
01c6508 
…#1170)"

This reverts commit a9b36fc.
mengweieric added a commit to mengweieric/dashboards-observability that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Fix events home table and toast life time (opensearch-project…
b45f2e6 
…#1170)"

This reverts commit a9b36fc.

Signed-off-by: Eric <menwe@amazon.com>
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert commits back to after 2.11 release (#1231)
c170e58 
* Revert "Update empty allowed roles to admin only (#1217) (#1220)"

This reverts commit 4288504.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Increment version to 2.11.1.0 (#1190)"

This reverts commit ccd5fb8.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Add S3 integration for Nginx and VPC (#1214) (#1216)"

This reverts commit e0a509c.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "disabling inspect and default pattern/timestamp buttons when using async data sources (#1205) (#1212)"

This reverts commit ca5ad02.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Saved object datasource backward compatibility fixes (#1208) (#1210)"

This reverts commit 467a0b3.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Link integrations from datasources UI (#1203) (#1207)"

This reverts commit 8e9fe5e.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "[Explorer] Fixes for cancel button and saved object loading (#1197) (#1201)"

This reverts commit f0e7a9d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Correct query schema for ELB mview generation (#1196) (#1199)"

This reverts commit 0b7be95.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "[Backport 2.11] Add integrations queries for Flint (#1195)"

This reverts commit 97f46ba.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "remove husky pre-commit checks (#1192) (#1193)"

This reverts commit 25d52f3.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Bug fixes for observability count distribution and application analytics (#1187) (#1189)"

This reverts commit e2440d2.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Support cancellation of async queries (#1177) (#1186)"

This reverts commit 6b495f3.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "[Explorer] Supports session for s3 direct query (#1178) (#1183)"

This reverts commit d50047f.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "[Explorer] Modify text in empty prompt (#1172) (#1182)"

This reverts commit 95a60cc.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "[Feature] Match discover look and feel (#1135) (#1179)"

This reverts commit b69801e.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "config panel dark mode fix (#1169) (#1176)"

This reverts commit 34696b3.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Fix events home table and toast life time (#1170)"

This reverts commit a9b36fc.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Quiet react-dnd draggableId/droppableId warnings. (#1147) (#1166)"

This reverts commit a2f9a00.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Fix integration labeling to identify S3 integrations (#1157) (#1164)"

This reverts commit 9de9aea.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Remove loading progress for integration setup (#1156) (#1162)"

This reverts commit a08721b.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Switch from toast to callout for integration set up failures (#1155) (#1159)"

This reverts commit e6a474a.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Disable integration set up button if invalid (#1152) (#1161)"

This reverts commit 74aae17.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Update URL of create datasources, fix spacing (#1149) (#1154)"

This reverts commit 0b66d83.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Allow patch on allowedRoles (#1143) (#1145)"

This reverts commit 0acc0f3.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "fix for explorer data grid not paginating (#1139) (#1141)"

This reverts commit c5ead50.

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
@opensearch-trigger-bot
Fix events home table and toast life time (opensearch-project#1170) (o…
d6c2dba 
…pensearch-project#1173)

* Fix 2.11 UX issues

* Change toast time life

* update snapshots

---------

(cherry picked from commit a9b36fc)

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit e0f3627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ps48 ps48 ps48 approved these changes

@mengweieric mengweieric mengweieric approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq rupal-bq is a code owner

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon vamsi-amazon is a code owner

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
backport main backport 2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavithacm @ps48 @mengweieric