Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PulsePoint Lite adapter #1016

Merged
merged 19 commits into from
Mar 15, 2017
Merged

PulsePoint Lite adapter #1016

merged 19 commits into from
Mar 15, 2017

Conversation

anand-venkatraman
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other

Description of change

Lite version of PulsePoint adapter. The current PulsePoint adapter downloads a JS library, and then executes the bid requests. The Lite adapter does not depend on JS library. This will replace the existing PulsePoint adapter, after comparing the results, in a subsequent release.

Additionally, a minor change to the endpoint of the JS lib for the old Adapter, is also included.

  • test parameters for validating bids
{
bidder: 'pulsepointLite',
   params: { 
      cf: '300X250',
      cp: 521732,
      ct: 76835
   }
}

Copy link
Collaborator

@jaiminpanchal27 jaiminpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anand-venkatraman Please check the comments. Thanks.

};
}

function pageUrl() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend using these function utils.getTopWindowUrl() and utils.getTopWindowLocation()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed


function bidResponseAvailable(bidRequest, rawResponse) {
if (rawResponse) {
var bidResponse = JSON.parse(rawResponse);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap this in try catch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrapped in try/catch


function PulsePointLiteAdapter() {

var bidUrl = window.location.protocol + '//bid.contextweb.com/header/tag?';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using const/let is recommended.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

@anand-venkatraman
Copy link
Contributor Author

@jaiminpanchal27 Comments addressed.

@jaiminpanchal27
Copy link
Collaborator

LGTM. Thanks @anand-venkatraman

@jaiminpanchal27 jaiminpanchal27 merged commit 87914c4 into prebid:master Mar 15, 2017
@jaiminpanchal27
Copy link
Collaborator

This is merged into master. Please submit a PR to the docs repo to add a file for your adapter to the bidders directory so your adapter's params will appear on the bidders page. Thank you for contributing

outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Mar 20, 2017
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* ET-1850: Adding a "lite" adapter.

* Minor fix

* Fix for response parsing

* Minor changes

* Minor changes

* Updating JS lib endpoint

* Updating JS lib endpoint

* addressing review comments

* fixing jshint error
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Mar 20, 2017
…built

* 'master' of https://github.com/prebid/Prebid.js:
  Add GourmetAds AppNexus Alias (prebid#1057)
  fix issue calling `requestBids();` (prebid#1058)
  explicit win url response format as pixel (prebid#1001)
  OpenX Adapter: Correctly gets the page domain for cross-domain iframes (prebid#1027)
  better http/s support (prebid#1010)
  Add a new generated field transactionId to each adunits. (prebid#1040)
  Update readme (prebid#1053)
  PulsePoint Lite adapter (prebid#1016)
  Add new adapter ServerBid (by Adzerk) (prebid#1024)
  Fix Mantis tests in negative timezone (prebid#1049)
  Add deal id handling (prebid#1044)
  sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030)
  Bidfluence Adapter (prebid#1023)
  Update uglify-js version (prebid#1041)
  Add dev dependencies.
  hb_adid should be uppercase in all cases (prebid#1037)
  Add TapSense Header Bidding Adapter and tests (prebid#1004)
  iOS Referrer fix (prebid#996)
  Change identification of JavaScript user matching (prebid#1022)
  Fixed mixed tabs/spaces in wideorbit adapter (prebid#1031)
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
* ET-1691: Pulsepoint Analytics adapter for Prebid. (#1)

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: Adding pulsepoint analytics and tests for pulsepoint adapter

* ET-1691: cleanup

* ET-1691: minor

* ET-1691: revert package.json change

* Adding bidRequest to bidFactory.createBid method as per prebid#509

* ET-1765: Adding support for additional params in PulsePoint adapter (#2)

* ET-1850: Fixing prebid#866

* ET-1850: Adding a "lite" adapter.

* Minor fix

* Fix for response parsing

* Minor changes

* Minor changes

* Updating JS lib endpoint

* Updating JS lib endpoint

* addressing review comments

* fixing jshint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants