sanitize bidderRequest to rubicon adapter to ensure accountId is sent #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
reviewed
Mar 10, 2017
src/adapters/rubicon.js
Outdated
| @@ -198,6 +198,10 @@ function RubiconAdapter() { | |||
| throw "no valid sizes"; | |||
| } | |||
|
|
|||
| if(!/^\d+$/.test(accountId)) { | |||
| throw "invalid accountId provided"; | |||
There was a problem hiding this comment.
nit: we prefer single quotes for strings.
|
updated all double quotes to single quotes |
|
LGTM. |
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Mar 20, 2017
…prebid#1030) * sanitize bidderRequest to rubicon adapter to ensure accountId is sent * use all single-quotes in rubicon stuff
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Mar 20, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: Add GourmetAds AppNexus Alias (prebid#1057) fix issue calling `requestBids();` (prebid#1058) explicit win url response format as pixel (prebid#1001) OpenX Adapter: Correctly gets the page domain for cross-domain iframes (prebid#1027) better http/s support (prebid#1010) Add a new generated field transactionId to each adunits. (prebid#1040) Update readme (prebid#1053) PulsePoint Lite adapter (prebid#1016) Add new adapter ServerBid (by Adzerk) (prebid#1024) Fix Mantis tests in negative timezone (prebid#1049) Add deal id handling (prebid#1044) sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030) Bidfluence Adapter (prebid#1023) Update uglify-js version (prebid#1041) Add dev dependencies. hb_adid should be uppercase in all cases (prebid#1037) Add TapSense Header Bidding Adapter and tests (prebid#1004) iOS Referrer fix (prebid#996) Change identification of JavaScript user matching (prebid#1022) Fixed mixed tabs/spaces in wideorbit adapter (prebid#1031)
Allen-37F
added a commit
to Allen-37F/Prebid.js
that referenced
this pull request
Mar 21, 2017
* commit '0cea31cd294f380b3b7cf46dd7a4000316b71ac1': Fix Mantis tests in negative timezone (prebid#1049) Add deal id handling (prebid#1044) sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030) Bidfluence Adapter (prebid#1023)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Make sure accountId is sent in bid.params since it is required for Rubicon adapter. Also, siteId and zoneId are now optional (listed as required on bid params documentation).