iOS Referrer fix #996
Merged
iOS Referrer fix #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ckbo3hrk |
|
@mkendall07 I've changed the existing one to cover |
mkendall07
requested changes
Mar 6, 2017
src/prebid.js
Outdated
| * Check if parent iframe of passed document supports content rendering via 'srcdoc' property | ||
| * @param {HTMLDocument} doc document to check support of 'srcdoc' | ||
| */ | ||
| function isSrcdocSupported(doc) { |
There was a problem hiding this comment.
can you move into utils.js please
|
LGTM. Thanks! |
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Mar 20, 2017
* fixed leading / omission on ie11 * srcdoc rendering approach to avoid http-referrer omission prebid#977 * missing unit test for url.parse (leading slash in pathname) * move isSrcdocSupported to utils
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Mar 20, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: Add GourmetAds AppNexus Alias (prebid#1057) fix issue calling `requestBids();` (prebid#1058) explicit win url response format as pixel (prebid#1001) OpenX Adapter: Correctly gets the page domain for cross-domain iframes (prebid#1027) better http/s support (prebid#1010) Add a new generated field transactionId to each adunits. (prebid#1040) Update readme (prebid#1053) PulsePoint Lite adapter (prebid#1016) Add new adapter ServerBid (by Adzerk) (prebid#1024) Fix Mantis tests in negative timezone (prebid#1049) Add deal id handling (prebid#1044) sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030) Bidfluence Adapter (prebid#1023) Update uglify-js version (prebid#1041) Add dev dependencies. hb_adid should be uppercase in all cases (prebid#1037) Add TapSense Header Bidding Adapter and tests (prebid#1004) iOS Referrer fix (prebid#996) Change identification of JavaScript user matching (prebid#1022) Fixed mixed tabs/spaces in wideorbit adapter (prebid#1031)
mkendall07
reviewed
Apr 17, 2017
| doc.write(ad); | ||
| doc.close(); | ||
| if (isSrcdocSupported(doc)) { | ||
| doc.defaultView.frameElement.srcdoc = ad; |
There was a problem hiding this comment.
It looks like srcdoc completely wipes out any other content present in the iframe. This is causing DFP to fail to report on viewable impressions. I will be reverting this change until we can find a proper solution.
There was a problem hiding this comment.
@mkendall07, I'd like to investigate this bug. Could you please provide me a sample dfp tag to reproduce this issue ?
There was a problem hiding this comment.
@ckbo3hrk
Here is an example:
Working (filter by "activeview" in network)
[working updating links]
Not working:
dluxemburg
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Jul 17, 2018
* fixed leading / omission on ie11 * srcdoc rendering approach to avoid http-referrer omission prebid#977 * missing unit test for url.parse (leading slash in pathname) * move isSrcdocSupported to utils
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change