Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new generated field transactionId to each adunits. #1040

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

rcassan
Copy link
Contributor

@rcassan rcassan commented Mar 9, 2017

Transaction ID that must be common across all participants in
this bid request (e.g., potentially multiple exchanges) (OpenRTB v2.5).

Type of change

  • Feature

Description of change

As a buyer integrated with several adaptors, I want to be able to know when the same impression is being offered by two or more of them. The goal of this PR is to generate a unique transaction ID in prebid.js and then distributing it through adaptors and their own integrations.

Note that OpenRTB has already introduced the notion of "source" in its 2.5 version, and in particular a "tid" field to relay this impression identifier.

Other information

This feature was first requested by #877

Transaction ID that must be common across all participants in
this bid request (e.g., potentially multiple exchanges) (OpenRTB v2.5).
@mkendall07
Copy link
Member

LGTM.

@mkendall07
Copy link
Member

@protonate
can you give this a quick look?

@mkendall07 mkendall07 merged commit e8ecd12 into prebid:master Mar 20, 2017
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Mar 20, 2017
Transaction ID that must be common across all participants in
this bid request (e.g., potentially multiple exchanges) (OpenRTB v2.5).
outoftime pushed a commit to Genius/Prebid.js that referenced this pull request Mar 20, 2017
…built

* 'master' of https://github.com/prebid/Prebid.js:
  Add GourmetAds AppNexus Alias (prebid#1057)
  fix issue calling `requestBids();` (prebid#1058)
  explicit win url response format as pixel (prebid#1001)
  OpenX Adapter: Correctly gets the page domain for cross-domain iframes (prebid#1027)
  better http/s support (prebid#1010)
  Add a new generated field transactionId to each adunits. (prebid#1040)
  Update readme (prebid#1053)
  PulsePoint Lite adapter (prebid#1016)
  Add new adapter ServerBid (by Adzerk) (prebid#1024)
  Fix Mantis tests in negative timezone (prebid#1049)
  Add deal id handling (prebid#1044)
  sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030)
  Bidfluence Adapter (prebid#1023)
  Update uglify-js version (prebid#1041)
  Add dev dependencies.
  hb_adid should be uppercase in all cases (prebid#1037)
  Add TapSense Header Bidding Adapter and tests (prebid#1004)
  iOS Referrer fix (prebid#996)
  Change identification of JavaScript user matching (prebid#1022)
  Fixed mixed tabs/spaces in wideorbit adapter (prebid#1031)
dluxemburg pushed a commit to Genius/Prebid.js that referenced this pull request Jul 17, 2018
Transaction ID that must be common across all participants in
this bid request (e.g., potentially multiple exchanges) (OpenRTB v2.5).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants