Change identification of JavaScript user matching #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce they are hardcoded.
Also making sure we encode/decode site and page parameters.
# Conflicts: # package.json # src/adaptermanager.js
Fix unit tests after refactoring
Merge remote-tracking branch 'upstream/master' # Conflicts: # package.json
# Conflicts: # .gitignore # package.json # src/adapters/wideorbit.js # test/spec/adapters/wideorbit_spec.js
# Conflicts: # integrationExamples/gpt/pbjs_example_gpt.html # src/adapters/wideorbit.js
|
Looks good |
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Mar 20, 2017
* Added WideOrbit adapter * Fix User Matching code * Renamed adapter + some minor JS issues * Added flag for notifying front action is header bidding. Use returned bid. * Duplicated properties fixed. * Correcting adaptermanager after wrong merge. Now all tests passes correctly. * Seting fl and jscb directly in the pageImpression-part of the url, since they are hardcoded. * Fixed above the fold parameter * No need to modify original value. * Normalizing file regarding single or double quotes. Also, properly indenting. * Removed uneeded properties: referrer (twice) and tagId. * Slightly better readiblity for variable declarations (and definition in some cases). * Refactoring regarding function naming and the way we set rank parameter. Also making sure we encode/decode site and page parameters. * Ignoring TypeScript's typing definitions. * Added initial WideOrbit Adapter tests covering url-creation part. * Completed wide orbit adapter tests with the one regarding callback response. * Slightly better test names. * Fix support for already prepared tracking pixels * Modified indenting according to coding standard * Code review fixes * Marked required parameters * Remove unused library from package.json Fix unit tests after refactoring * Added support for referrer * Added support for referrer * Updated line endings to UNIX style * Fixed formatting issue * Fix user matching identification for JavaScript type * Duplicated WideOrbit spec after merge
outoftime
pushed a commit
to Genius/Prebid.js
that referenced
this pull request
Mar 20, 2017
…built * 'master' of https://github.com/prebid/Prebid.js: Add GourmetAds AppNexus Alias (prebid#1057) fix issue calling `requestBids();` (prebid#1058) explicit win url response format as pixel (prebid#1001) OpenX Adapter: Correctly gets the page domain for cross-domain iframes (prebid#1027) better http/s support (prebid#1010) Add a new generated field transactionId to each adunits. (prebid#1040) Update readme (prebid#1053) PulsePoint Lite adapter (prebid#1016) Add new adapter ServerBid (by Adzerk) (prebid#1024) Fix Mantis tests in negative timezone (prebid#1049) Add deal id handling (prebid#1044) sanitize bidderRequest to rubicon adapter to ensure accountId is sent (prebid#1030) Bidfluence Adapter (prebid#1023) Update uglify-js version (prebid#1041) Add dev dependencies. hb_adid should be uppercase in all cases (prebid#1037) Add TapSense Header Bidding Adapter and tests (prebid#1004) iOS Referrer fix (prebid#996) Change identification of JavaScript user matching (prebid#1022) Fixed mixed tabs/spaces in wideorbit adapter (prebid#1031)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
User matchings that are done by outputting a JavaScript were previously identified by using the string "javascript". This has been modified to instead compare to the string "js".